ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Very clever way of solving the problem! I took a look myself a few days ago
but got stuck. I like your solution. It works well and I couldn't find any
regressions.
Please get a secon
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> zzag wrote in desktop.cpp:73
> I didn't test it, but I think this one would be better:
>
> qDeleteAll(m_actions.begin() + numDesktops, m_act
zzag added inline comments.
INLINE COMMENTS
> zzag wrote in desktop.cpp:73
> Could someone please explain why this part is fine?
I didn't test it, but I think this one would be better:
qDeleteAll(m_actions.begin() + numDesktops, m_actions.end());
m_actions.resize(numDesktops);
REPOSITORY
zzag added inline comments.
INLINE COMMENTS
> zzag wrote in desktop.cpp:73
> Will this loop ever be executed?
>
> Also, why not `delete m_actions.take(i - 1);`?
Could someone please explain why this part is fine?
REPOSITORY
R120 Plasma Workspace
BRANCH
arcpatch-D15599
REVISION DETAIL
h
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
> to make d_ed happy
It worked
REPOSITORY
R120 Plasma Workspace
BRANCH
arcpatch-D15599
REVISION DETAIL
https://phabricator.kde.org/D15599
To: hein, mart, davide
ngraham updated this revision to Diff 43758.
ngraham added a comment.
Fix the Text Lines label and spinbox
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16241?vs=43712&id=43758
BRANCH
icons-page-tweaks (branched from master)
REVISION DETAIL
ht
hein updated this revision to Diff 43754.
hein added a comment.
Don't keep VirtualDesktopInfo as a static member to make d_ed happy
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15599?vs=43753&id=43754
BRANCH
arcpatch-D15599
REVISION DETAIL
hein updated this revision to Diff 43753.
hein added a comment.
Fix two more uses of arg()
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15599?vs=42600&id=43753
BRANCH
arcpatch-D15599
REVISION DETAIL
https://phabricator.kde.org/D15599
AFFEC
hein updated this revision to Diff 43752.
hein added a comment.
- Make `doSwitch` wrap again
- Don't keep the VirtualDesktopsInfo as a static member to make d_ed happy
- Use the multi-argument arg()
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
ivan requested changes to this revision.
ivan added a comment.
It is (also) a noun, though MW spells it as "pop-up" [1]
[1] https://www.merriam-webster.com/dictionary/pop-up
edit: Heh, Nate was faster :)
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.or
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
Actually, the original wording is correct--or at least more correct.
"popup" is a noun, something that can be closed, so "Close popup" is fine.
"Close Pop Up" is not correct
shubham created this revision.
shubham added a reviewer: Plasma.
shubham added a project: Plasma.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D16257
AFFECTED FILES
applets/s
ngraham planned changes to this revision.
ngraham added a comment.
Oops, found a few visual glitches. Will fix today.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D16241
To: ngraham, #plasma, #vdg, hein
Cc: abetts, thsurrel, plasma-devel, ragreen, Pitel, Zre
abetts added a comment.
+1
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D16241
To: ngraham, #plasma, #vdg, hein
Cc: abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, sebas, apol, mart
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> switch.cpp:203
> +if (desktops.contains(desktop)) {
> +const QString &name = QStringLiteral("%1:
> %2").ar
Plasma 5.14.1 is now released
https://www.kde.org/announcements/plasma-5.14.1.php
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> davidedmundson wrote in desktop.cpp:46
> In the other patch VirtualDesktopInfo has a shared d ptr across all instances.
>
> There's no point m
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.11/6/
Project:
stable-kf5-qt5 SUSEQt5.11
Date of build:
Tue, 16 Oct 2018 10:18:22 +
Build duration:
9 min 1 sec and counting
CONSOLE OUTPUT
[.
thsurrel added a comment.
That looks much better!
Any reason why the "Text lines" parameter in the Icon panel is not aligned
with the rest of the form ?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D16241
To: ngraham, #plasma, #vdg, hein
Cc: thsurrel, pla
19 matches
Mail list logo
