T8066: Fix Bug 390830 = Prevent indexing of Plasma vaults and other fuse filesystems

2018-09-25 Thread Stefan BrĂ¼ns
bruns added a comment. If you want a manual workaround, just add the vault path to excludeFolders. If you want a proper fix, handle encfs etc. properly in baloo. TASK DETAIL https://phabricator.kde.org/T8066 To: michaelh, bruns Cc: smithjd, bruns, nicolasfella, ivan, plasma-devel, alexeym

T8066: Fix Bug 390830 = Prevent indexing of Plasma vaults and other fuse filesystems

2018-09-25 Thread James Smith
smithjd added a comment. What's wrong with a .balooignore file in the root of the vault? Tracker uses .trackerignore. TASK DETAIL https://phabricator.kde.org/T8066 To: michaelh, smithjd Cc: smithjd, bruns, nicolasfella, ivan, plasma-devel, alexeymin, michaelh, ashaposhnikov, astippich, sp

[Plasma Workspace Wallpapers] [Bug 347532] preferencias de escritorio no permite establecer fondo de pantalla ni individual ni en presentacion solo las del sistenma

2018-09-25 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=347532 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #5 from Andrew Croutham

[Breeze] [Bug 356902] Starters are visually indistinguishable from listed tasks in the task manager widget on breeze light

2018-09-25 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=356902 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew Croutham

[Breeze] [Bug 346369] the password feild is not set to empty after wrong password attempt

2018-09-25 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=346369 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #4 from Andrew Croutham

[Powerdevil] [Bug 334411] Screen Energy Saving timeout on dual-monitor system starting one after another with timeout delay

2018-09-25 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=334411 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew Croutham

[Powerdevil] [Bug 341619] Screen Brightness does not change

2018-09-25 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=341619 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew Croutham

[Breeze] [Bug 350682] Double-click on GTK widgets initiates window movement, breaks control of the widget

2018-09-25 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=350682 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #11 from Andrew Croutha

[Powerdevil] [Bug 349226] battery updated not updated after suspend to memory

2018-09-25 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=349226 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #5 from Andrew Croutham

D12498: Fully remove `Application Name` from Details panel

2018-09-25 Thread Nathaniel Graham
ngraham added a comment. It landed; you wanna finish this up now? REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12498 To: sharvey, bruns, ngraham, davidedmundson Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, leslie

D15749: Add tooltips to krunner configure and close buttons

2018-09-25 Thread Andrew Crouthamel
acrouthamel added a comment. In D15749#331860 , @ngraham wrote: > would you like to do the honors and land this for him, @acrouthamel? Yes boss... Always roping me into something new. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL

D15749: Add tooltips to krunner configure and close buttons

2018-09-25 Thread Andrew Crouthamel
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f57460a61643: Add tooltips to krunner configure and close buttons (authored by slenz, committed by acrouthamel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.

D15304: [KCM] Port label-bearing controls to QQC2 to fix fractional scaling support

2018-09-25 Thread Nathaniel Graham
ngraham updated this revision to Diff 42329. ngraham added a comment. Port (almost) entirely to QQC2 REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15304?vs=41077&id=42329 BRANCH arcpatch-D15304 REVISION DETAIL https://phabricator.k

D15749: Add tooltips to krunner configure and close buttons

2018-09-25 Thread Nathaniel Graham
ngraham added a comment. Since Silas lacks commit rights (I found this out by searching on https://websvn.kde.org/trunk/kde-common/accounts?view=markup), would you like to do the honors and land this for him, @acrouthamel? Make sure the git authorship is set properly first. Land on master pl

D15749: Add tooltips to krunner configure and close buttons

2018-09-25 Thread Andrew Crouthamel
acrouthamel accepted this revision. acrouthamel added a comment. Ooh my first time being added as reviewer. ;) REPOSITORY R120 Plasma Workspace BRANCH krunner-tootlips (branched from master) REVISION DETAIL https://phabricator.kde.org/D15749 To: slenz, #vdg, acrouthamel, ngraham Cc: n

D15749: Add tooltips to krunner configure and close buttons

2018-09-25 Thread Silas Lenz
slenz updated this revision to Diff 42319. slenz added a comment. Remove "KRunner" from configure tooltip REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15749?vs=42318&id=42319 BRANCH krunner-tootlips (branched from master) REVISION DETAIL ht

D15749: Add tooltips to krunner configure and close buttons

2018-09-25 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > ngraham wrote in RunCommand.qml:64 > Hmm, good question. Let me ask #VDG . For now, let's just go with "Configure..." and we'll sort out the user-facing string at another time so we don't derail your patch. :

D14830: Add "Configure Displays" context menu entry on the desktop

2018-09-25 Thread gregormi
gregormi added a comment. In D14830#313645 , @davidedmundson wrote: > I am still waiting for a single justification. In https://phabricator.kde.org/T6875, under "Who should be our primary target groups?" we have "Windows 7 Power Users".

D15749: Add tooltips to krunner configure and close buttons

2018-09-25 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > slenz wrote in RunCommand.qml:64 > You could argue KRunner is not used as a user-facing name anywhere (Setting > calls it `Plasma Search` and `Search Bar` depending on where you look). Might > be less confusing to just keep it at `Configure...`?

D15749: Add tooltips to krunner configure and close buttons

2018-09-25 Thread Silas Lenz
slenz added inline comments. INLINE COMMENTS > ngraham wrote in RunCommand.qml:64 > Needs ellipses; see > https://hig.kde.org/style/writing/labels.html#using-ellipses-in-labels > > How about "Configure KRunner..." ? You could argue KRunner is not used as a user-facing name anywhere (Setting c

D15749: Add tooltips to krunner configure and close buttons

2018-09-25 Thread Silas Lenz
slenz updated this revision to Diff 42318. slenz added a comment. Add ellipses and KRunner to configure tooltip. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15749?vs=42316&id=42318 BRANCH krunner-tootlips (branched from master) REVISION DETA

D15749: Add tooltips to krunner configure and close buttons

2018-09-25 Thread Nathaniel Graham
ngraham added a reviewer: acrouthamel. ngraham added a comment. Wow, that was fast. One minor suggestion: INLINE COMMENTS > RunCommand.qml:64 > visible: runnerWindow.canConfigure > +tooltip: i18nd("plasma_lookandfeel_org.kde.lookandfeel", > "Configure") > }

D15749: Add tooltips to krunner configure and close buttons

2018-09-25 Thread Silas Lenz
slenz created this revision. slenz added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. slenz requested review of this revision. REVISION SUMMARY Shows tooltips for buttons left and right of the search box. FEATURE: 398943 TEST PLAN Manually tes

D15514: [libbreezecommon] Use box blur instead of FFT blur

2018-09-25 Thread Vlad Zagorodniy
zzag planned changes to this revision. zzag added a comment. Follow https://www.w3.org/TR/SVG11/filters.html#feGaussianBlurElement REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15514 To: zzag, #kwin, #plasma Cc: cfeck, ngraham, abetts, plasma-devel, ragreen, Pitel, Z

D15644: Provide option to hide menu bar for Ksysguard

2018-09-25 Thread Nathaniel Graham
ngraham added a comment. Actually, reading over this again, is it really necessary to add a `showMessage` parameter to `toggleShowMenuBar`? In general bool-only arguments are frowned upon because they're not very readable; enums are preferred in their place. But do we even need that paramete

D15093: Add WireGuard capability.

2018-09-25 Thread Nathaniel Graham
ngraham added a comment. In D15093#331505 , @andersonbruce wrote: > - Add entry widget background color change based on entry validity > - Change QSpinBoxes back to QLineEdits Awesome, +1 from me on these changes! REPOSITORY R116 Pla

D15644: Provide option to hide menu bar for Ksysguard

2018-09-25 Thread Luca Sartorelli
lsartorelli added a comment. Thank you very much, I am so happy and proud for my first patch. Here my details: Name: Luca Surname: Sartorelli Mail: dj3...@gmail.com And here is the patch for gwenview: https://phabricator.kde.org/D15747 Just added you as reviewer 2 se

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2018-09-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #30 from Nate Graham --- All right, I'll butt out now. :) -- You are receiving this mail because: You are the assignee for the bug.

D15644: Provide option to hide menu bar for Ksysguard

2018-09-25 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Wonderful. I think the warning is good enough for now until we can come up with a better way of handling this. Code looks good! Can you provide your full name and email address so I can l

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2018-09-25 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #29 from Kai Uwe Broulik --- I suspect it's an update bug somewhere, screen locker starts and then reads the information fresh on start. We have found an issue in the proxy model we use for sorting batteries but that seems unlikely to just h

D15744: [weather applet] Fix unwanted ruling of implicit icon sizes on displayed size

2018-09-25 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R114:a49908b6eaef: [weather applet] Fix unwanted ruling of implicit icon sizes on displayed size (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2018-09-25 Thread Rolf Eike Beer
https://bugs.kde.org/show_bug.cgi?id=350365 Rolf Eike Beer changed: What|Removed |Added Version|5.3.2 |5.12.5 -- You are receiving this mail because

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2018-09-25 Thread Rolf Eike Beer
https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #28 from Rolf Eike Beer --- So why does it work on the lockscreen, does that read it's information from somewhere else? -- You are receiving this mail because: You are the assignee for the bug.

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2018-09-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=350365 Nate Graham changed: What|Removed |Added CC||n...@kde.org --- Comment #27 from Nate Graham --

D15744: [weather applet] Fix unwanted ruling of implicit icon sizes on displayed size

2018-09-25 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 42309. kossebau marked an inline comment as done. kossebau added a comment. - use Repeater.count & Repeater.itemAt(i) - drop additional property preferredWidth on cell items, calculate from normal properties REPOSITORY R114 Plasma Addons CHANGES SIN

D15738: [Fonts KCM] remove filler words from anti-aliasing settings' labels

2018-09-25 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15738 To: ngraham, #vdg, #plasma Cc: abetts, svenmauch, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15744: [weather applet] Fix unwanted ruling of implicit icon sizes on displayed size

2018-09-25 Thread Friedrich W. H. Kossebau
kossebau added a comment. Thanks for look, Will update based on feedback later today. INLINE COMMENTS > broulik wrote in ForecastView.qml:38 > `Layout.preferredWidth` defaults to `implicitWidth`, see [1] on the > "preference order" > > [1] > https://doc.qt.io/qt-5/qtquicklayouts-overview.h

D15744: [weather applet] Fix unwanted ruling of implicit icon sizes on displayed size

2018-09-25 Thread Kai Uwe Broulik
broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. I think all of this could be cleaned up significantly INLINE COMMENTS > ForecastView.qml:38 > PlasmaComponents.Label { > +readonly property int preferredWid

D15744: [weather applet] Fix unwanted ruling of implicit icon sizes on displayed size

2018-09-25 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY BUG: 398960 FIXED-IN: 5.14.0 TEST PLAN Switching icon sets between newaita, Breeze, or Ox

Plasma 5.12.7 LTS

2018-09-25 Thread Jonathan Riddell
Plasma 5.12.7 LTS is now released https://www.kde.org/announcements/plasma-5.12.7.php

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2018-09-25 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=350365 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #26 from K

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2018-09-25 Thread Marco Richetta
https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #25 from Marco Richetta --- Created attachment 115218 --> https://bugs.kde.org/attachment.cgi?id=115218&action=edit Battery detected -- You are receiving this mail because: You are the assignee for the bug.

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2018-09-25 Thread Marco Richetta
https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #24 from Marco Richetta --- Created attachment 115217 --> https://bugs.kde.org/attachment.cgi?id=115217&action=edit Battery not detected -- You are receiving this mail because: You are the assignee for the bug.

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2018-09-25 Thread Marco Richetta
https://bugs.kde.org/show_bug.cgi?id=350365 Marco Richetta changed: What|Removed |Added CC||marcoriche...@gmail.com --- Comment #23 from M

D15644: Provide option to hide menu bar for Ksysguard

2018-09-25 Thread Luca Sartorelli
lsartorelli updated this revision to Diff 42298. lsartorelli added a comment. Added remainder message box with keyboard shortcut, to have back the menu bar. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42101&id=42298 REVISION DETAIL https://phabricator.kde.org/D15644 A

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator

2018-09-25 Thread Bruce Anderson
andersonbruce updated this revision to Diff 42297. andersonbruce added a comment. - Fix review comments REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15520?vs=42281&id=42297 BRANCH IP4/6validatorsUpdate REVISION DETAIL https:

D15514: [libbreezecommon] Use box blur instead of FFT blur

2018-09-25 Thread Vlad Zagorodniy
zzag updated this revision to Diff 42295. zzag added a comment. Comment on why shadows are a little bit lighter. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15514?vs=41667&id=42295 BRANCH zzag/box-shadow-helper-box-blur REVISION DETAIL https://phabri

D15093: Add WireGuard capability.

2018-09-25 Thread Bruce Anderson
andersonbruce updated this revision to Diff 42290. andersonbruce added a comment. - Add entry widget background color change based on entry validity - Change QSpinBoxes back to QLineEdits REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.

D15738: [Fonts KCM] remove filler words from anti-aliasing settings' labels

2018-09-25 Thread Sven Mauch
svenmauch added a comment. Looks good to me +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15738 To: ngraham, #vdg, #plasma Cc: svenmauch, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15616: [Comic] Handle error state correctly

2018-09-25 Thread Anthony Fieroni
anthonyfieroni updated this revision to Diff 42286. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15616?vs=42148&id=42286 REVISION DETAIL https://phabricator.kde.org/D15616 AFFECTED FILES applets/comic/comic.cpp applets/comic/comic.h dataengine