ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land.
Wonderful. I think the warning is good enough for now until we can come up with a better way of handling this. Code looks good! Can you provide your full name and email address so I can land this patch with proper authorship information? Now that you're an expert on creating warning messages when the menu bar is hidden, would you like to try your hand at doing the same thing for Gwenview? https://bugs.kde.org/show_bug.cgi?id=210620 ;-) Any concerns from #plasma <https://phabricator.kde.org/tag/plasma/> or #frameworks <https://phabricator.kde.org/tag/frameworks/> folks before I land this? REVISION DETAIL https://phabricator.kde.org/D15644 To: lsartorelli, ngraham, #plasma, #frameworks Cc: acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
