D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator

andersonbruce updated this revision to Diff 42281. andersonbruce added a comment. - Fix a case that was being reported as Acceptable rather than Intermediate REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15520?vs=41878&id=42281 BR

D15418: Dim application icon when it is not playing anything

ngraham added a comment. Maybe something like this? F6283615: Screenshot_20180924_195355.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: svenmauch, acrouthamel, a

D15598: Sort icon and cursor themes case-insensitively

ngraham added a comment. Done. :) REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D15598 To: ngraham, apol, #plasma Cc: wbauer, cfeck, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

ngraham added a comment. FYI I've submitted a new patch with only the non-controversial elements of this one: D15738: [Fonts KCM] remove filler words from anti-aliasing settings' labels REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricat

D15738: [Fonts KCM] remove filler words from anti-aliasing settings' labels

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This is a new version of D13593 with only the non-contro

D15717: Fix spelling errors

ngraham added a comment. Cherry-picked onto the `Plasma/5.14` branch now. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D15717 To: borispek, ngraham Cc: rikmills, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abet

D15684: DateTime Runner timezone and 24 hour clock time conversion.

smithjd updated this revision to Diff 42274. smithjd added a comment. - [DateTime Runner] Add two new syntaxes for conversion to and from 24 hour time. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15684?vs=42113&id=42274 BRANCH master-timeconver

D15598: Sort icon and cursor themes case-insensitively

wbauer added a comment. In D15598#328967 , @ngraham wrote: > Darn, looks like arc didn't notice my rebase on 5.14. Oh well, I guess this'll go into 5.15. Well, you could cherry-pick it into the 5.14 branch (using `git cherry-pick xxx`).

D15717: Fix spelling errors

ngraham added a comment. Because it has a string change, but I realize now that this doesn't actually preclude going into 5.14 since it's not a translated string. I'll cherry-pick it onto 5.14, and thanks for following up on this @rikmills! REPOSITORY R99 KDE Gtk Configuration Tool REVISI

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

harmathy added inline comments. INLINE COMMENTS > main.qml:221 > +QtControls.ToolTip { > +text: i18n("Type of sub-pixel rendering to use. Choose a > style that corresponds to the order of your display's pixel grid. For > example, choose RGB hinting if your display t

D15687: [Device Notifier] Avoid accessing attributes of stale UDIs

This revision was automatically updated to reflect the committed changes. bruns marked an inline comment as done. Closed by commit R120:61b2b173e8d6: [Device Notifier] Avoid accessing attributes of stale UDIs (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE htt

D15143: Allow creation of separator Actions

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. i don't think it's necessary to put separatordelegate in the public api, it can be something local in globaldrawer and contextdrawer directly, without adding new properties that will

D15724: Wait for duration to be known before registering player

This revision was automatically updated to reflect the committed changes. Closed by commit R856:bc4dad725bbb: Wait for duration to be known before registering player (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15724

D15724: Wait for duration to be known before registering player

broulik updated this revision to Diff 42229. broulik added a comment. - Fix typo - Simplify check REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15724?vs=42227&id=42229 REVISION DETAIL https://phabricator.kde.org/D15724 AFFECTED FIL

D15724: Wait for duration to be known before registering player

fvogt added inline comments. INLINE COMMENTS > broulik wrote in content-script.js:326 > We don't want to randomly switch players when they happen to change their > duration, don't we? Or are you refering to me checking for > `pendingActivePlayer` not being `null`? The latter. `player` can't be

D15724: Wait for duration to be known before registering player

broulik added inline comments. INLINE COMMENTS > fvogt wrote in content-script.js:326 > Is the `pendingActivePlayer` check necessary here? We don't want to randomly switch players when they happen to change their duration, don't we? Or are you refering to me checking for `pendingActivePlayer`

D15724: Wait for duration to be known before registering player

fvogt added inline comments. INLINE COMMENTS > content-script.js:106 > +// When a player has no duration yet, we'll wait for it becoming known > +// to determin whether to ignore it (short sound) or make it active > +var pendingActivePlayer; Missing e > content-script.js:326 > +// Defer

D15724: Wait for duration to be known before registering player

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY A player might emit a `play` signal before its `duration` is known. We wan

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

svenmauch added a comment. +1 on removing style/type from the strings I'm unsure about the anti-aliasing/font smoothing discussion and I understand both sides. However, if we were to change it to smoothing then we should also consider renaming sub-pixel rendering to be consistent. REPOS

D15418: Dim application icon when it is not playing anything

svenmauch added a comment. Ideally the volume lines would show how loud an application currently is by having an equalizer-like overlay on the blue volume bar. For now I think having the icons with less transparency is confusing. At least for me it doesn't seem intuitive enough what it m

Monday meeting notes for 2018-09-24 (week 39)

Eike DONE * [Wayland] Virtual desktops progress: ** "Switch Desktop" containment action plugin ported to libtaskmanager, bugs fixed ** "Switch Window" containment action updated to new libtaskmanager API, bugs fixed PLAN * working on making the prototype virtua

D15717: Fix spelling errors

rikmills added a comment. In D15717#330808 , @ngraham wrote: > Landed on master, so the change will show up in KDE Plasma 5.15. See https://community.kde.org/Schedules/Plasma_5 for more information. Why not in 5.14 which also has these er

D15521: Add validator for lists of IP addressesAdded as separate review per comment from Pino onreview D15093. This code will not compile withoutthe updated code in review D15520. Also includesunit te

andersonbruce abandoned this revision. andersonbruce added a comment. Changes for this revision were merged into D15520 REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D15521 To: andersonbruce, jgrulich, p

D15093: Add WireGuard capability.

jgrulich added a comment. I agree with @ngraham, I was also planning a similar approach for other connection types. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D15093 To: andersonbruce, #plasma, jgrulich, pino Cc: acrouthamel, K900, pino,

D15521: Add validator for lists of IP addressesAdded as separate review per comment from Pino onreview D15093. This code will not compile withoutthe updated code in review D15520. Also includesunit te

jgrulich added a comment. Please mark this review as abandoned. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D15521 To: andersonbruce, jgrulich, pino Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abett