D15521: Add validator for lists of IP addressesAdded as separate review per comment from Pino onreview D15093. This code will not compile withoutthe updated code in review D15520. Also includesunit te

andersonbruce created this revision. andersonbruce added reviewers: jgrulich, pino. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. andersonbruce requested review of this revision. REVISION SUMMARY CCBUG: 397572 FIXED-IN: 5.14.0 REPOSITORY R116 Plasma Network Manage

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator

ngraham added a comment. Thanks! And since I don't believe this patch on its own is sufficient to resolve 397572, please change `FEATURE: 397572` to `CCBUG: 397572`. The former will close the bug once this lands; the latter just adds the commit info as a comment, but keeps the bug open--whic

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidatorto optionally handle a CIDR or port suffix. Added capabilitiesimplemented via defaulted parameter to maintain compatibilitywith

ngraham added a comment. That huge summary needs reformatting, please. :) See https://chris.beams.io/posts/git-commit/#seven-rules REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D15520 To: andersonbruce, jgrulich, pino Cc: ngraham, plasma-de

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidatorto optionally handle a CIDR or port suffix. Added capabilitiesimplemented via defaulted parameter to maintain compatibilitywith

andersonbruce created this revision. andersonbruce added reviewers: jgrulich, pino. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. andersonbruce requested review of this revision. REVISION SUMMARY ...updated code. Opened as a separate review per comment from Pino on r

D15514: [libbreezecommon] Use box blur instead of FFT approach

cfeck added a comment. I would even say 'after' looks better, because the bottom shadow isn't as strong as 'before'. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15514 To: zzag, #kwin, #plasma Cc: cfeck, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesli

D15514: [libbreezecommon] Use box blur instead of FFT approach

zzag updated this revision to Diff 41667. zzag added a comment. Simplify code, also delete unrelated changes REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15514?vs=41666&id=41667 BRANCH zzag/box-shadow-helper-box-blur REVISION DETAIL https://phabricato

D15514: [libbreezecommon] Use box blur instead of FFT approach

zzag planned changes to this revision. zzag added a comment. Simplify it further. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15514 To: zzag, #kwin, #plasma Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D15514: [libbreezecommon] Use box blur instead of FFT approach

zzag updated this revision to Diff 41666. zzag added a comment. Code formatting REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15514?vs=41665&id=41666 BRANCH zzag/box-shadow-helper-box-blur REVISION DETAIL https://phabricator.kde.org/D15514 AFFECTED FI

D15514: [libbreezecommon] Use box blur instead of FFT approach

zzag added a comment. In D15514#326127 , @ngraham wrote: > Yeah, I also can't tell the difference. If this new way is computationally cheaper, then +1 from me. I don't want to say numbers (because in order to have proper benchmark, I hav

D15514: [libbreezecommon] Use box blur instead of FFT approach

ngraham added a comment. Yeah, I also can't tell the difference. If this new way is computationally cheaper, then +1 from me. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15514 To: zzag, #kwin, #plasma Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, les

D15514: [libbreezecommon] Use box blur instead of FFT approach

zzag updated this revision to Diff 41665. zzag added a comment. Call reserve method REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15514?vs=41663&id=41665 BRANCH zzag/box-shadow-helper-box-blur REVISION DETAIL https://phabricator.kde.org/D15514 AFFECTE

D15514: [libbreezecommon] Use box blur instead of FFT approach

abetts added a comment. Interesting, no big real differences visually IMHO REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15514 To: zzag, #kwin, #plasma Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15514: [libbreezecommon] Use box blur instead of FFT approach

zzag updated this revision to Diff 41663. zzag added a comment. Edit comments REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15514?vs=41662&id=41663 BRANCH zzag/box-shadow-helper-box-blur REVISION DETAIL https://phabricator.kde.org/D15514 AFFECTED FILE

D15514: [libbreezecommon] Use box blur instead of FFT approach

zzag created this revision. zzag added reviewers: KWin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY Creation of shadows (especially for "Large" and "Very large" sizes) is a computation expensive task

D15512: [startplasmacompositor] Add Wayland socket argument

fvogt added a comment. In D15512#326093 , @romangg wrote: > In D15512#326091 , @fvogt wrote: > > > I'm against this - `kwin_wayland` should just pick the next available socket if `wayland-0` is not a

D15512: [startplasmacompositor] Add Wayland socket argument

romangg added a comment. In D15512#326091 , @fvogt wrote: > I'm against this - `kwin_wayland` should just pick the next available socket if `wayland-0` is not available. That's also what Xorg does and is IMO the expected behaviour. Maybe

D15512: [startplasmacompositor] Add Wayland socket argument

fvogt added a comment. I'm against this - `kwin_wayland` should just pick the next available socket if `wayland-0` is not available. That's also what Xorg does and is IMO the expected behaviour. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15512 To: rom

D15512: [startplasmacompositor] Add Wayland socket argument

romangg created this revision. romangg added reviewers: KWin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Argument will be forwarded to KWin. Allows to start a full Wayland Plasma session from a

KDE CI: Plasma » kde-gtk-config » stable-kf5-qt5 FreeBSDQt5.11 - Build # 4 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/stable-kf5-qt5%20FreeBSDQt5.11/4/ Project: stable-kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 14 Sep 2018 18:42:10 + Build duration: 2 min 1 sec and counting

KDE CI: Plasma » kde-gtk-config » stable-kf5-qt5 FreeBSDQt5.11 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/stable-kf5-qt5%20FreeBSDQt5.11/3/ Project: stable-kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 14 Sep 2018 18:41:09 + Build duration: 58 sec and counting CONSOLE OUTPUT

D15509: autoconnect-priority is a 32-bit signed integer

cjlcarvalho created this revision. cjlcarvalho added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cjlcarvalho requested review of this revision. REVISION SUMMARY Fixing autoconnect-priority spinbox minimum value and including maximum value, becaus

D15495: Add Messages.sh

This revision was automatically updated to reflect the committed changes. Closed by commit R856:715ba3a22906: Add Messages.sh (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15495?vs=41650&id=41651 REVISION DETAIL htt

D15495: Add Messages.sh

aspotashev accepted this revision. aspotashev added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D15495 To: broulik, #plasma, davidedmundson, #localization, aacid, aspotashev Cc: as

D15495: Add Messages.sh

broulik updated this revision to Diff 41650. broulik added a comment. - Move `Messages.sh` into `reminder` dir REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15495?vs=41620&id=41650 REVISION DETAIL https://phabricator.kde.org/D15495 A

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.11 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/9/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 14 Sep 2018 13:15:07 + Build duration: 13 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.11 - Build # 7 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/7/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 14 Sep 2018 13:20:47 + Build duration: 2 min 24 sec and counting JUnit Tests Name: (root) Fail

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.11 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/11/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 14 Sep 2018 13:18:20 + Build duration: 2 min 7 sec and counting JUnit Tests Name: (root) Failed:

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.11 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.11/7/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 14 Sep 2018 13:16:31 + Build duration: 1 min 14 sec and counting

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.11 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.11/9/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 14 Sep 2018 13:15:25 + Build duration: 47 sec and counting

D15498: Workaround QTBUG-47066 to fix crash on startup

This revision was automatically updated to reflect the committed changes. Closed by commit R123:a21dd3486b12: Workaround QTBUG-47066 to fix crash on startup (authored by fvogt). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15498?vs=416

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.11 - Build # 6 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/6/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 14 Sep 2018 12:11:52 + Build duration: 6 min 17 sec and counting CONSOLE OUTPUT [...truncated 9

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.11 - Build # 8 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/8/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 14 Sep 2018 12:11:43 + Build duration: 2 min 34 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.11 - Build # 8 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.11/8/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 14 Sep 2018 12:11:40 + Build duration: 2 min 23 sec and counting CONSOLE OUTPUT [...trun

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.11 - Build # 10 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/10/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 14 Sep 2018 12:11:46 + Build duration: 1 min 57 sec and counting CONSOLE OUTPUT [...truncated 46.

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.11 - Build # 6 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.11/6/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 14 Sep 2018 12:11:54 + Build duration: 53 sec and counting CONSOLE OUTPUT [...truncated 6

D12827: Added process details in the process list context menu

chrisx added a comment. Any updates on whether this patch could be merged? It has been a long wait. If there are any improvements I can make to the patch I will be more than happy to put more work into it. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D12

D15504: [Output Config] Fix transformation matrix for rotation icon

broulik created this revision. broulik added reviewers: gladhorn, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The rotate left/right icons were erroneously mirrored as well TEST PLAN Tilted my head, e

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

romangg added a comment. In D7038#134955 , @graesslin wrote: > I like that refactoring 👍 - though processAt might not be the best fitting name. Don't have a good name idea, maybe findChildSurfaceAt? Maybe `findSurfaceHelper`. REPOSITORY

D15498: Workaround QTBUG-47066 to fix crash on startup

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY The lambda returns a QStringBuilder which contains dangling references. Work around that by converting to QString inside the lambda's context.

D15495: Add Messages.sh

aspotashev added a comment. We already have tabsrunner/Messages.sh so adding this Messages.sh will extract the messages from tabsrunner/* twice. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D15495 To: broulik, #plasma, davidedmundson, #localizat

D15495: Add Messages.sh

broulik planned changes to this revision. broulik added a comment. Alright, will move it to the reminder then REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D15495 To: broulik, #plasma, davidedmundson, #localization, aacid Cc: aspotashev, ltoscano,

D15495: Add Messages.sh

broulik updated this revision to Diff 41620. broulik added a comment. Fix typo.. REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15495?vs=41619&id=41620 REVISION DETAIL https://phabricator.kde.org/D15495 AFFECTED FILES CMakeLists.txt

D15495: Add Messages.sh

ltoscano added a comment. Correct: the names should be different, and so the domains. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D15495 To: broulik, #plasma, davidedmundson, #localization, aacid Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenB

D15495: Add Messages.sh

broulik updated this revision to Diff 41619. broulik added a comment. Rename to `plasma-browser-integration-native` I could have moved it to the host but I fear we will forget again should we ever use `i18n` in the host (which I did at one point) REPOSITORY R856 Plasma Browser Integration

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in surface_interface.cpp:819 > position is a float So, it would be fine to return `true` in the following case: QRectF(QPoint(0, 0), QSize(10, 10)).contains(QPointF(10, 10)); ? REPOSITORY R127 KWayland REVISION DETAIL h

D15197: Clarify docs in startkde about shtudown

This revision was automatically updated to reflect the committed changes. Closed by commit R120:af66555b0ab0: Clarify docs in startkde about shtudown (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15197?vs=40804&id=41613

D15178: Reload list of wallpaper types on install/uninstall

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5545214d4420: Reload list of wallpaper types on install/uninstall (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15178?vs=407

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in surface_interface.cpp:819 > Shouldn't it be QRect instead? position is a float REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #frameworks, graesslin Cc: davidedmundson, zzag, kde

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.11 - Build # 38 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.11/38/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 14 Sep 2018 08:10:11 + Build duration: 5 min 42 sec and counting

D15201: Move logout-greeter into it's own subdir out of ksmserver

davidedmundson updated this revision to Diff 41608. davidedmundson added a comment. Update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15201?vs=40813&id=41608 BRANCH dave2 REVISION DETAIL https://phabricator.kde.org/D15201 AFFECTED FILES

D15495: Add Messages.sh

davidedmundson added a comment. According to https://websvn.kde.org/trunk/l10n-kf5/scripts/ update_translations it seems both Messages.sh and StaticMessages.sh will be invoked. But I don't think we can use the same .pot name. REPOSITORY R856 Plasma Browser Integration REVISION DET

D15495: Add Messages.sh

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, Localization, aacid. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We have translatable strings in the reminder c++ code. TEST P

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

zzag added inline comments. INLINE COMMENTS > surface_interface.cpp:819 > + > +return !size.isEmpty() && QRectF(QPoint(0, 0), size).contains(position); > +} Shouldn't it be QRect instead? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #framewor