D14221: Keep track of multiple players

This revision was automatically updated to reflect the committed changes. Closed by commit R856:a3cf696d5777: Keep track of multiple players (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14221?vs=38057&id=41314 REVIS

D15263: Don't use older buggier versions of AppStream Qt

arfrever added a comment. This change was committed in 5.12 and 5.13, but not yet in master branch. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15263 To: apol, #plasma, hein Cc: arfrever, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jen

D15391: [Bookmarks Runner] Fix cleanup of favicon directory

bruns created this revision. bruns added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY QDir.entryInfoList(NoDotAndDotDot) always returns an empty list, as it requires one of

D15093: Add WireGuard capability.

ngraham added a comment. No new instances of `Q_FOREACH`, please. See https://www.kdab.com/goodbye-q_foreach/ REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D15093 To: andersonbruce, #plasma, jgrulich, pino Cc: acrouthamel, K900, pino, lbelt

D15093: Add WireGuard capability.

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. Thanks Bruce for all the updates, and patience! In return, I have more notes :) - I'd send the changes to the existing SimpleIpV4AddressValidator in an own review request, since

D15386: Use consistent "Suspend" terminology

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4500ff9de102: Use consistent "Suspend" terminology (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15386?vs=41286&id=41289 REVISION

Re: CI System Reorganisation

On Mon, 10 Sep 2018, 01:17 Christoph Feck, wrote: > On 09.09.2018 10:59, Ben Cooksley wrote: > > As a followup to my earlier mail sent about 3 weeks ago, i've now > > transitioned all builds on the CI system over to the folder layout > > previously described. > > > > Builds can now be found in fo

D15386: Use consistent "Suspend" terminology

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY We use "Suspend" and "Hibernate" in most places except for KRunner, where we currently use mo

D15384: [Bookmarks Runner] Remove unused define

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9be8c3c7e59b: [Bookmarks Runner] Remove unused define (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15384?vs=41281&id=41284 REVISION

D15384: [Bookmarks Runner] Remove unused define

bruns created this revision. bruns added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. TEST PLAN make REPOSITORY R120 Plasma Workspace BRANCH cleanup REVISION DETAIL https://phabricato

D15254: Fix Firefox profile location lookup after location has changed

This revision was automatically updated to reflect the committed changes. Closed by commit R120:dda9aaba2d5c: Fix Firefox profile location lookup after location has changed (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15254?vs=4

D15254: Fix Firefox profile location lookup after location has changed

bruns updated this revision to Diff 41271. bruns added a comment. Squash D15257 , otherwise the favicon DB path will not be set REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15254?vs=40943&id=41271 BRANCH pr

D15257: Set favicon DB path when when places DB path is retrieved from config

bruns abandoned this revision. bruns added a comment. Squashed REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15257 To: bruns, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

bruns added a comment. In D15357#322812 , @davidedmundson wrote: > RunnerContext::addMatches has its own duplicate check based on match.id > > We're not explicitly setting that currently. > I think we can just do match.setId(url+title); a

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

davidedmundson added a comment. RunnerContext::addMatches has it's own duplicate check based on match.id We're not explicitly setting that currently. I think we can just do match.setId("bookmarks"+url+title); and have everything handled auto-magically. If that does work it will be

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

bruns added inline comments. INLINE COMMENTS > zzag wrote in firefox.cpp:136 > Please use prefix increment. If there are more required changes, yes, else - no. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15357 To: bruns, #plasma Cc: zzag, ngraham, plasma-

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

zzag added inline comments. INLINE COMMENTS > bruns wrote in firefox.cpp:136 > It neither guarantees prefix is more efficient than postfix. Please use prefix increment. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15357 To: bruns, #plasma Cc: zzag, ngraham

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

bruns added inline comments. INLINE COMMENTS > zzag wrote in firefox.cpp:136 > Does the C++ standard guarantee that? It neither guarantees prefix is more efficient than postfix. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15357 To: bruns, #plasma Cc: zzag

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

zzag added inline comments. INLINE COMMENTS > bruns wrote in firefox.cpp:136 > Because modern compilers are clever enough do avoid any temporaries Does the C++ standard guarantee that? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15357 To: bruns, #plasma C

Re: CI System Reorganisation

On 09.09.2018 10:59, Ben Cooksley wrote: As a followup to my earlier mail sent about 3 weeks ago, i've now transitioned all builds on the CI system over to the folder layout previously described. Builds can now be found in folders following the following structure on Jenkins: / How I can vie

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

bruns added inline comments. INLINE COMMENTS > zzag wrote in firefox.cpp:136 > Why postfix increment? Because modern compilers are clever enough do avoid any temporaries REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15357 To: bruns, #plasma Cc: zzag, ngraha

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

zzag added inline comments. INLINE COMMENTS > firefox.cpp:136 > + > +for (auto result = uniqueResults.constKeyValueBegin(); result != > uniqueResults.constKeyValueEnd(); result++) { > +BookmarkMatch bookmarkMatch(m_favicon, term, (*result).second, > (*result).first); Why postfix in

CI System Reorganisation

Hi all, As a followup to my earlier mail sent about 3 weeks ago, i've now transitioned all builds on the CI system over to the folder layout previously described. Builds can now be found in folders following the following structure on Jenkins: / For those with access to run DSL Scripts: Please

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

davidedmundson added a comment. Urgh. Just read the code. We don't reset when we type a new letter. To do so would have a jumpy ui. Instead we reset when we get results back. That leaves a problem when you search for "firefo" ( with 1 result) to "firefodfhhxtffrdh" with zero results

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. No point pinging if we haven't replied to Kai's comments/question. REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D14064 To: McPain, brouli

D15093: Add WireGuard capability.

andersonbruce marked 37 inline comments as done. andersonbruce added a comment. I think I've gotten most of the fixes in. I made changes to simpleipv4addressvalidator and simpleipv6addressvalidator to add checking of addresses with CIDR and Port suffixes. Please check these carefully, I think

D15093: Add WireGuard capability.

andersonbruce updated this revision to Diff 41241. andersonbruce added a comment. - Fixed comment - Expand capabilities of SimpleIP validators. - Changes per review comments - Update for updated ip validators REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE