bruns added a comment.
In D15357#322812 <https://phabricator.kde.org/D15357#322812>, @davidedmundson wrote: > RunnerContext::addMatches has its own duplicate check based on match.id > > We're not explicitly setting that currently. > I think we can just do match.setId(url+title); and have everything handled auto-magically. > > If that does work it will be less code with the same results, faster and even handle dupes in both firefox and chrome bookmarks. Win win. hm, no: - It will not filter out the entries with empty titles - The BookmarkMatch constructor fetches the favicon for each match REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15357 To: bruns, #plasma Cc: davidedmundson, zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
