D15093: Add WireGuard capability.

jgrulich added inline comments. INLINE COMMENTS > wireguard.cpp:71 > +{ > +regexStrings.ip4Range = new QString( > +"(?:[0-1]?[0-9]?[0-9]|2[0-4][0-9]|25[0-5])"); You can use simpleipv[4,6]validator we have in plasma-nm instead of using everything below. Or maybe QHostAddress can vali

D15093: Add WireGuard capability.

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. Much better now! General notes: - there are various checks on lengths of strings like `str.length() > 0` or `str.length() != 0`: if all you need is check whether a string is

[kio-extras] [Bug 375826] Copying files to a remote SFTP folder opens a popup "Could not change permissions.."

https://bugs.kde.org/show_bug.cgi?id=375826 Andreas Schneider changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO Resolution|---

[kio-extras] [Bug 368877] log_kio_sftp log flood

https://bugs.kde.org/show_bug.cgi?id=368877 Andreas Schneider changed: What|Removed |Added Assignee|plasma-devel@kde.org|a...@cryptomilk.org CC|

[kio-extras] [Bug 375305] SFTP file create date is wrong

https://bugs.kde.org/show_bug.cgi?id=375305 Andreas Schneider changed: What|Removed |Added CC||a...@cryptomilk.org Assignee|plas

D15093: Add WireGuard capability.

acrouthamel added a comment. In D15093#319245 , @andersonbruce wrote: > I'm not sure if the author or the reviewer is supposed to check the "Done" box on the inline comments but I think that I have addressed all the various comments made, both

D15093: Add WireGuard capability.

andersonbruce added a comment. I'm not sure if the author or the reviewer is supposed to check the "Done" box on the inline comments but I think that I have addressed all the various comments made, both inline and separately. REPOSITORY R116 Plasma Network Management Applet REVISION DETA

D15093: Add WireGuard capability.

andersonbruce updated this revision to Diff 40885. andersonbruce added a comment. Updates from review comments - Add copyright notices - Delete unneeded files - Formatting changed to agree with coding standards - Changed validation method removing color overrides - Removed hard cod

D15229: Specify minimum version for KScreenlocker, use correct DBUS path

bruns created this revision. bruns added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY org.kde.screensaver.xml is only part of KScreenlocker starting with version 5.13.80, al

D15187: Merge switch user dialog into lockscreen

bruns added a comment. See D15228 for the KSCREENLOCKER_DBUS_INTERFACES_DIR part ... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15187 To: davidedmundson, #plasma, mart Cc: bruns, ngraham, mart, plasma-devel, ragreen

D15228: Export install location for DBUS interfaces via CMake

bruns created this revision. bruns added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY This is useful for any other package depending on the interface description at build ti

D15187: Merge switch user dialog into lockscreen

bruns added inline comments. INLINE COMMENTS > CMakeLists.txt:47 > > +qt5_add_dbus_interface( ksmserver_KDEINIT_SRCS > ${KDE_INSTALL_FULL_DBUSINTERFACEDIR}/org.kde.screensaver.xml > kscreenlocker_interface ) > + This breaks in two ways: - There is no specified dependency on KScreenlocker 5.

D15226: Check against QRect whether pointer is inside DecorationButton

zzag created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY If several buttons share an edge, i.e. spacing between decoration buttons is set to 0, and the pointer is on that edge, both buttons wil

D14806: [AppStream Runner] Reduce verbosity of log output

bruns added a comment. Would be nice to get this in soon, the current state logs a message everytime you type a character in KRunner. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14806 To: bruns, #plasma, apol, ngraham Cc: apol, plasma-devel, ragreen, Pi

[kio-extras] [Bug 362988] sftp connection win dolphin hangs/stops working after few seconds

https://bugs.kde.org/show_bug.cgi?id=362988 Andreas Schneider changed: What|Removed |Added Ever confirmed|0 |1 CC|

D7087: Add "Copy Info" button to the About System KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R102:c0f28efd280f: Add "Copy Info" button to the About System KCM (authored by gregormi). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7087?vs=40853&id=40854 REVI

D7087: Add "Copy Info" button to the About System KCM

gregormi updated this revision to Diff 40853. gregormi added a comment. - Use QVector instead of QList - Use the term "Operating System:" instead of "Distro" REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7087?vs=39321&id=40853 BRANCH arcpatch-D708