jgrulich added inline comments.
INLINE COMMENTS
> wireguard.cpp:71
> +{
> + regexStrings.ip4Range = new QString(
> + "(?:[0-1]?[0-9]?[0-9]|2[0-4][0-9]|25[0-5])");
You can use simpleipv[4,6]validator we have in plasma-nm instead of using
everything below. Or maybe QHostAddress can validate it for you?
> wireguard.cpp:185
> + }
> + else if (addressIn.first.protocol() ==
> QAbstractSocket::NetworkLayerProtocol::IPv6Protocol) {
> + dataMap.insert(QLatin1String(NM_WG_KEY_ADDR_IP6),
> addressList[i]);
Coding style.
> wireguard.cpp:215
> + }
> + else {
> + return result;
Coding style.
> wireguard.cpp:318
> + if (!haveAddress || !havePrivateKey || !havePublicKey ||
> !haveAllowedIps) {
> +
> + mError = VpnUiPlugin::Error;
Remove space.
> wireguard.h:34
> +public:
> + explicit WireGuardUiPlugin(QObject* parent = nullptr, const
> QVariantList& = QVariantList());
> + ~WireGuardUiPlugin() override;
Coding style. You mix funcName(Bar* foo) with funcName(Bar * foo) and
funcName(Bar *foo), plese change it all to the last one. Same goes for
functions below.
> wireguardadvancedwidget.h:55
> +
> +private Q_SLOTS:
> +
Can be removed if you don't have any private slot.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D15093
To: andersonbruce, #plasma, jgrulich, pino
Cc: acrouthamel, K900, anthonyfieroni, pino, lbeltrame, ngraham, plasma-devel,
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, mart
