D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

2018-08-19 Thread Oleg Solovyov
McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in soliddeviceengine.cpp:555 > not sure you need this timer > > 1. You should still get the job finishing with error ERR_SERVER_TIMEOUT. > (untested, but the protocol manager in the client does have some stuff doing > this) >

D14423: Mingw compile fix

2018-08-19 Thread Ralf Habacker
habacker added a comment. In D14423#310711 , @mlaurent wrote: > I can't test it. You can On a linux system with installed osc, (see https://en.opensuse.org/openSUSE:OSC for more details) run osc co home:rhabacker:branches:wind

D14437: Fix QFileDialog not remembering the last visited directory.

2018-08-19 Thread Anthony Fieroni
anthonyfieroni added a comment. +1 REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D14437 To: dfaure, anthonyfieroni, elvisangelaccio, plasma-devel, broulik, arichardson Cc: apol, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jens

D14437: Fix QFileDialog not remembering the last visited directory.

2018-08-19 Thread David Faure
dfaure added a comment. ping? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D14437 To: dfaure, anthonyfieroni, elvisangelaccio, plasma-devel, broulik, arichardson Cc: apol, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreute

D14440: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the directory too

2018-08-19 Thread David Faure
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R135:22da1e661afd: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the… (authored by dfaure). Herald add

D14440: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the directory too

2018-08-19 Thread David Faure
dfaure added a comment. I'll assume +1 and +1 = +2, and push... REVISION DETAIL https://phabricator.kde.org/D14440 To: dfaure, arichardson, anthonyfieroni, elvisangelaccio, plasma-devel, broulik

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-19 Thread Filip Fila
filipf added a comment. In D14869#311447 , @oysteins wrote: > In D14869#309949 , @rkflx wrote: > > > F6198464: kubuntu10-kubunbtu11-win10-macos.png > > >

D14933: Implemented Version checker for fwupd in FindLIBFWUPD.cmake

2018-08-19 Thread Aleix Pol Gonzalez
apol added a comment. You can extract the version from pkgconfig. CMake has macros to interact with it, or just the executable `pkg-config --modversion fwupd` meanwhile. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14933 To: abhijeet2096, apol, da

D14933: Implemented Version checker for fwupd in FindLIBFWUPD.cmake

2018-08-19 Thread Abhijeet sharma
abhijeet2096 created this revision. abhijeet2096 added reviewers: apol, davidedmundson. abhijeet2096 added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. abhijeet2096 requested review of this revision. REVISION SUMMARY Implemented Ver

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-19 Thread Øystein S . -Alværvik
oysteins added a comment. In D14869#309949 , @rkflx wrote: > F6198464: kubuntu10-kubunbtu11-win10-macos.png I feel that Windows' font rendering produces significantly sharper fonts than anything els

D14924: Prevent paste in screen locker (alternative approach)

2018-08-19 Thread David Edmundson
davidedmundson added a comment. But the bug is klipper specific behaviour. In hindsight the mimetype doesn't actually matter, there's no text/plain so klipper wouldn't save anyway. The important part is that we have something non-empty, non-useful. That should work in all clipboard man