broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, fvogt.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Currently, when starting another video, medi
ngraham added a comment.
Sorry for the delay!
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D13612
To: hoffmannrobert, mart
Cc: ngraham, amantia, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas,
ngraham closed this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D13612
To: hoffmannrobert, mart
Cc: ngraham, amantia, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
asturmlechner added a comment.
ping - could we get this in for 5.14?
REPOSITORY
R113 Oxygen Theme
REVISION DETAIL
https://phabricator.kde.org/D8267
To: ostroffjh, #plasma, apol
Cc: tfoster, apol, asturmlechner, cfeck, plasma-devel, ragreen, Pitel, ZrenBot,
lesliezhai, ali-mohamed, jensr
broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, fvogt, lbeltrame.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Don't wait for `DOMContentLoaded`
https://bugs.kde.org/show_bug.cgi?id=374300
--- Comment #4 from Alexander Schier ---
The readability issue is gone with Bug 369676.
I am not sure if the bug should stay open for the possiblity to configure
colors for better theming.
--
You are receiving this mail because:
You are the assignee f
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:58f5bb623d14: Turn OsdManager into a regular class
(authored by gladhorn).
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14166?vs=37899&id=38031
REVISION DETAIL
gladhorn created this revision.
gladhorn added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
gladhorn requested review of this revision.
REPOSITORY
R104 KScreen
BRANCH
master
REVISION DETAIL
https://phabricator.
gladhorn updated this revision to Diff 38029.
gladhorn marked 4 inline comments as done.
gladhorn added a comment.
Do not yet introduce any keyboard handling (escape snuck in) and remove
clutter (assert, visible:true).
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator
gladhorn added inline comments.
INLINE COMMENTS
> broulik wrote in osd.cpp:125
> Should we use `QmlObjectSharedEngine` here? (could be done separately later)
I think the whole OSD class is constantly being deleted/re-created (after 5
seconds of not being used iirc) so for now this is moot.
> b
It was decided at the kickoff meeting that the Qt required for Plasma
5.14 will be Qt 5.11.
KDE Frameworks will be 5.50
What I didn't do is take notes on why that version was required or
when we will make the change which is what sysadmin will want to know.
Who can say?
Jonathan
This revision was automatically updated to reflect the committed changes.
Closed by commit R856:216d5b12f7d5: Listen for player "emptied"
signal (authored by broulik).
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14209?vs=38022&id=38026
R
fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.
Didn't test myself, but LGTM
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D14209
To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, r
broulik updated this revision to Diff 38022.
broulik edited the test plan for this revision.
broulik added a comment.
- Just emit `stopped`
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14209?vs=38020&id=38022
REVISION DETAIL
https://
fvogt added a comment.
If the extension translates "emptied" to "stopped", wouldn't it be compatible
with older hosts?
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D14209
To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pit
The Kickoff meeting notes has an item we started and wanted to move to
a breakout
"separate out phab e-mails so not all plasma-devel@ is phab e-mails (breakout)"
Anyone have thoughts on how Phab e-mails for Plasma stuff could be
better organised?
Jonathan
broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, fvogt.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
This is when a website reuses their player a
hoffmannrobert added a comment.
Can somebody please land this patch for me? Thanks.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D13612
To: hoffmannrobert, mart
Cc: amantia, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
je
broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, fvogt.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
We currently only monitor the tab being clos
ngraham added a comment.
Retroactive +1 :)
REPOSITORY
R126 KDE CLI Utilities
REVISION DETAIL
https://phabricator.kde.org/D14204
To: broulik, dfaure, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R126:3a8ef4cf6d02: [KEditFileType] Show application icon in
preference list (authored by broulik).
REPOSITORY
R126 KDE CLI Utilities
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14204?vs=3800
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
So easy ;-)
REPOSITORY
R126 KDE CLI Utilities
REVISION DETAIL
https://phabricator.kde.org/D14204
To: broulik, dfaure, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali
broulik added inline comments.
INLINE COMMENTS
> osd.cpp:125
> +}
> +m_osdActionSelector = new KDeclarative::QmlObject(this);
> +m_osdActionSelector->setSource(QUrl::fromLocalFile(osdPath));
Should we use `QmlObjectSharedEngine` here? (could be done separately later)
> o
broulik created this revision.
broulik added reviewers: dfaure, ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Makes the list a lot easier to grasp at a glance
TEST PLA
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> OsdSelector.qml:107
> +} else {
> +checked = false
> +}
Given we'r
gladhorn updated this revision to Diff 38003.
gladhorn marked 4 inline comments as done.
gladhorn added a comment.
Fixed keyboard bindings breaking all the time, as indicated in review
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14165?vs=37898&id=38003
gladhorn added inline comments.
INLINE COMMENTS
> davidedmundson wrote in osd.cpp:144
> I don't understand how this hideOsd() will work, it only updates m_osdObject
> which is the other OSD.
Ouch, there you saved me :) osdtest works since it exits, with the real osd
through kded it doesn't wor
gladhorn updated this revision to Diff 37994.
gladhorn marked 2 inline comments as done.
gladhorn added a comment.
Fix hiding of osds
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14143?vs=37984&id=37994
BRANCH
arcpatch-D14143
REVISION DETAIL
https:/
28 matches
Mail list logo
