Baloo and remote file systems

2018-07-17 Thread Rainer Dorsch
Hi, I moved some of my data on a file server. As far as I understand, baloo only indexes local files, I assume it relies on inotify or something similar to avoid periodic full scans. Can anybody tell if it is possible to run baloo on a remote file system, also running a baloo client on the fil

D14143: Make the action selector OSD independent of the other OSDs

2018-07-17 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > osd.cpp:144 > Q_EMIT osdActionSelected(static_cast(action)); > hideOsd(); > } I don't understand how this hideOsd() will work, it o

D14143: Make the action selector OSD independent of the other OSDs

2018-07-17 Thread Frederik Gladhorn
gladhorn updated this revision to Diff 37984. gladhorn added a comment. return qstring without ref REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14143?vs=37923&id=37984 BRANCH arcpatch-D14143_2 REVISION DETAIL https://phabricator.kde.org/D14143 AFFE

D14165: Handle keyboard in action selector OSD

2018-07-17 Thread Frederik Gladhorn
gladhorn added a comment. Awesome! I'll incorporate the ideas, that's great. Any chance to get https://phabricator.kde.org/D14143 in? It's required for this since it changes the window type. I'd also like to make the global shortcut show and hide the osd (right now pressing it again makes th

D14152: Remove ref from returned QString

2018-07-17 Thread Frederik Gladhorn
This revision was automatically updated to reflect the committed changes. Closed by commit R104:97f7b9cff782: Remove ref from returned QString (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14152?vs=37922&id=37983 REVISION DETAIL htt

D13874: textplugin: Fix missing QTextStream include

2018-07-17 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R112:6b2036cb8a1d: textplugin: Fix missing QTextStream include (authored by alistairf, committed by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13874?vs=37123&id=37982#toc REPOSITORY

D14056: Remove FileItemActionPlugin in favor of Purpose plugin

2018-07-17 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R97:6fa60e4bf363: Remove FileItemActionPlugin in favor of Purpose plugin (authored by nicolasfella). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14056?vs=37586&id=37

D14186: Show software notifier only once startup has completed

2018-07-17 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. No. If we explicitly set the backend before calling ::sceneGraphBackend then it will have the correct result. When we're using the software renderer from th

D14186: Show software notifier only once startup has completed

2018-07-17 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `QQuickWindow::sceneGraphBackend()` is empty until

D14174: Fix blur behind folderview context menus

2018-07-17 Thread Nathaniel Graham
ngraham added a comment. In D14174#293468 , @hein wrote: > We have blurred context menus now? Wtf. > > But ok. It's an optional setting in the Breeze theme. Not really my thing, but I have to admit that user feedback has been overwhel

D14185: Disable script execution over DBus when scripting console is disabled

2018-07-17 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY There's no point in disabling the GUI for this but then still allo

Re: Discussion for Virtual Desktops and Activities future

2018-07-17 Thread Ivan Čukić
> Couldn't we teach each Swoosh how to have its own set of favorites, > recents etc, but also how to inherit the "standard" or "default" set? > Then a Swoosh could be either an Activity or a Virtual Desktop. So, configuration? That would work if it can be made pretty. Cheers, Ivan

Re: Discussion for Virtual Desktops and Activities future

2018-07-17 Thread Nate Graham
Couldn't we teach each Swoosh how to have its own set of favorites, recents etc, but also how to inherit the "standard" or "default" set? Then a Swoosh could be either an Activity or a Virtual Desktop. Nate On 07/17/2018 07:03 AM, Ivan Čukić wrote: UI-wise: We currently (let's pretend) hav

Re: Discussion for Virtual Desktops and Activities future

2018-07-17 Thread Ivan Čukić
UI-wise: We currently (let's pretend) have two options for the users (I've replaced the terms activity and VD with 'swoosh' inspired by the former Mozilla problem): - have multiple swooshes where favourites, recents etc. are shared - have multiple swooshes where favorties, recents are per-swoosh

Re: Virtual Desktop and Activities future: Partitioning proposal

2018-07-17 Thread Roman Gilg
On Tue, Jul 17, 2018 at 11:01 AM Marco Martin wrote: > > On lunedì 16 luglio 2018 20:07:40 CEST Roman Gilg wrote: > > -- > > libtaskmanager implementation: > > -- > > * Listens for VD, active VD and VD identifier changes. > > * Associates int

D14165: Handle keyboard in action selector OSD

2018-07-17 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > OsdSelector.qml:136 > Keys.onEscapePressed: clicked("dialog-cancel") > +Keys.onReturnPressed: { > +clicked(buttonRow.checkedButton.action) Also do `Keys.onEnterPressed` so that enter on numpad works > OsdSelector.qml:

D14174: Fix blur behind folderview context menus

2018-07-17 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R119:42a74c9a79ba: Fix blur behind folderview context menus (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14174?vs=37915&id=37940

Re: Discussion for Virtual Desktops and Activities future

2018-07-17 Thread David Edmundson
On Tue, Jul 17, 2018 at 8:55 AM, Marco Martin wrote: > On lunedì 16 luglio 2018 12:44:13 CEST David Edmundson wrote: > > As for my mod, in my head it's basically what you just said above. > Clicking > > + creates an activity which means KAMD then creates a N desktops. > Clicking > > - tells KAMD

Re: Virtual Desktop and Activities future: Partitioning proposal

2018-07-17 Thread Marco Martin
On lunedì 16 luglio 2018 20:07:40 CEST Roman Gilg wrote: > -- > libtaskmanager implementation: > -- > * Listens for VD, active VD and VD identifier changes. > * Associates internally VDs with Activities. hmm, i feel this association would be

Re: Discussion for Virtual Desktops and Activities future

2018-07-17 Thread Marco Martin
On lunedì 16 luglio 2018 12:44:13 CEST David Edmundson wrote: > As for my mod, in my head it's basically what you just said above. Clicking > + creates an activity which means KAMD then creates a N desktops. Clicking > - tells KAMD to delete the activity which in turn deletes N desktops. Might I t