davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > osd.cpp:144 > Q_EMIT osdActionSelected(static_cast<OsdAction::Action>(action)); > hideOsd(); > } I don't understand how this hideOsd() will work, it only updates m_osdObject which is the other OSD. > osd.cpp:137 > + auto *rootObject = m_osdActionSelector->rootObject(); > + connect(rootObject, SIGNAL(clicked(int)), > this, SLOT(onOsdActionSelected(int))); This will reconnect on the second invocation REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14143 To: gladhorn, #plasma, davidedmundson Cc: davidedmundson, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
