D12517: Wayland: when blocking remember latest config change instead of crashing

This revision was automatically updated to reflect the committed changes. Closed by commit R110:af609c37ddfd: Wayland: when blocking remember latest config change instead of crashing (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12517?vs=33067&id=37132#toc REPOSIT

D12517: Wayland: when blocking remember latest config change instead of crashing

romangg added inline comments. INLINE COMMENTS > apol wrote in waylandtestserver.cpp:155 > maybe it's a bit easier to understand if you add an else instead of a return? The coding style recommendation in general is to return as early as possible instead of using else. > apol wrote in waylandte

D13874: textplugin: Fix missing QTextStream include

kossebau added a comment. Not the maintainer, just did some commits recently :) Thanks for the patch. Seems this is needed with some newer version of Qt? Some >5.11.1? Can you commit yourself? Should go to Plasma/5.12 branch possibly, to make that one work as well with newer Qt. REPOSIT

D13874: textplugin: Fix missing QTextStream include

alistairf created this revision. alistairf added a reviewer: kossebau. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. alistairf requested review of this revision. REVISION SUMMARY Signed-off-by: Alistair Francis REPOSITORY R112 Milou

D13745: Implement support for virtual desktops on Wayland

hein added inline comments. INLINE COMMENTS > zzag wrote in taskfilterproxymodel.h:73 > Is it id or number? It's id. > zzag wrote in waylandtasksmodel.cpp:760 > How about `static_cast(data.size())`? No strong opinion :). This code is based on the one in the X11 model, which is in turn from th

Re: Discussion for Virtual Desktops and Activities future

On 07/04/2018 03:00 AM, Ivan Čukić wrote: > Wondering where the original discussion happened where 'we' decided to > merge two orthogonal concepts into one. Can you point me to the relevant > thread on plasma-devel? This is the relevant thread :-) I think this is a fair recap so far: * When M

D13745: Implement support for virtual desktops on Wayland

zzag added a comment. Oh, please ignore my comments about `reserve`. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13745 To: hein, mart, mvourlakos Cc: zzag, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D13745: Implement support for virtual desktops on Wayland

zzag added inline comments. INLINE COMMENTS > taskfilterproxymodel.h:73 > * @see setVirtualDesktop > * @returns the number of the virtual desktop used in filtering. > **/ Is it id or number? > virtualdesktopinfo.cpp:126 > { > -return KWindowSystem::numberOfDesktops(); > +

Re: Raising windows on Wayland

Am 2018-07-03 18:58, schrieb David Edmundson: Ideally this needs to be standardized so that it does not only work with our applications but with any. Even within just KDE apps, we have code like QDesktopServices spawning links in code we can't manipulate. Anything non standard, simply isn't

Re: Discussion for Virtual Desktops and Activities future

Just read the phab discussion. If I misunderstood the situation, please correct me. Wondering where the original discussion happened where 'we' decided to merge two orthogonal concepts into one. Can you point me to the relevant thread on plasma-devel?If this is about providing a unified implementa

D13871: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled

kossebau added a comment. Initial draft version of the patch for principal review. Blocks should be indented surely. Perhaps the test methods should be also separated each into in-orocess and out-of-process , so the out-of-process ones could get a QSKIP at the begin, for improved lo

D13871: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled

kossebau created this revision. kossebau added reviewers: dfaure, sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY With the movement to support running unittests pre-instal

D13853: Fix setting primary connector if primary output changed

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > screenpool.cpp:108 > } > Q_ASSERT(m_idForConnector.contains(primary)); > Either this is a valid case to be in, and this assert doe

D13870: Correct Folder View sizing and representation switch behavior

mvourlakos added a comment. In D13870#286578 , @hein wrote: > Add back useful comment. I tested the patch and I couldnt reproduce the tiny popup window with plasma, I checked also the Latte parabolic effect and it was working. +1, G

Re: Raising windows on Wayland

> > Ideally this needs to be standardized so that it does not only work with > our applications but with any. > Even within just KDE apps, we have code like QDesktopServices spawning links in code we can't manipulate. Anything non standard, simply isn't worth merging. But I don't think standardis

Re: Raising windows on Wayland

Am 2018-07-03 18:41, schrieb Aleix Pol: On Tue, Jul 3, 2018 at 6:32 PM Martin Flöser wrote: Am 2018-07-03 18:05, schrieb Aleix Pol: > On Tue, Jul 3, 2018 at 6:02 PM Martin Flöser > wrote: >> >> Am 2018-07-03 14:45, schrieb Aleix Pol: >> > Dear kwiners, >> > Would it be possible to find a way

Re: Raising windows on Wayland

On Tue, Jul 3, 2018 at 6:32 PM Martin Flöser wrote: > > Am 2018-07-03 18:05, schrieb Aleix Pol: > > On Tue, Jul 3, 2018 at 6:02 PM Martin Flöser > > wrote: > >> > >> Am 2018-07-03 14:45, schrieb Aleix Pol: > >> > Dear kwiners, > >> > Would it be possible to find a way to do so? > >> > > >> > I kn

Re: Raising windows on Wayland

The token approach sounds good. I also like the idea of generalizing it to cover startup notifications and pursuing standardization for it. Cheers, Eike

Re: Raising windows on Wayland

Am 2018-07-03 18:05, schrieb Aleix Pol: On Tue, Jul 3, 2018 at 6:02 PM Martin Flöser wrote: Am 2018-07-03 14:45, schrieb Aleix Pol: > Dear kwiners, > Would it be possible to find a way to do so? > > I know we don't want windows to be positioning themselves willy-nilly > on the window stack, bu

D13870: Correct Folder View sizing and representation switch behavior

hein updated this revision to Diff 37115. hein added a comment. Add back useful comment. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13870?vs=37114&id=37115 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13870 AFFECTED FILES c

D13870: Correct Folder View sizing and representation switch behavior

hein updated this revision to Diff 37114. hein added a comment. - Add the missing switch stuff. - Remove stray debug. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13870?vs=37113&id=37114 BRANCH master REVISION DETAIL https://phabricator.kde

D13870: Correct Folder View sizing and representation switch behavior

hein planned changes to this revision. hein added a comment. Whoops, I accidentally uploaded the wrong diff, hang on. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13870 To: hein, mart, broulik, mvourlakos Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezha

D13870: Correct Folder View sizing and representation switch behavior

hein created this revision. hein added reviewers: mart, broulik, mvourlakos. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY - Resolve inherent layout hint conflicts between full and compact representations by setting them seperately. Thi

Re: Raising windows on Wayland

On Tue, Jul 3, 2018 at 6:02 PM Martin Flöser wrote: > > Am 2018-07-03 14:45, schrieb Aleix Pol: > > Dear kwiners, > > Would it be possible to find a way to do so? > > > > I know we don't want windows to be positioning themselves willy-nilly > > on the window stack, but we certainly need to figure

Re: Raising windows on Wayland

Am 2018-07-03 14:45, schrieb Aleix Pol: Dear kwiners, Would it be possible to find a way to do so? I know we don't want windows to be positioning themselves willy-nilly on the window stack, but we certainly need to figure out his use-case. What would need to happen to do this? If you need to,

D13745: Implement support for virtual desktops on Wayland

mvourlakos added a comment. In D13745#286544 , @hein wrote: > Can we discuss this somewhere else, e.g. on plasma-devel or in one of the Plasma monday meetings? This is a review thread for a libtaskmanager code patch. of course, done...

Discussion for Virtual Desktops and Activities future

A discussion started by me at: https://phabricator.kde.org/D13745 about concerns related to future Activities / Virtual Desktops merge (I will call it MERGE in the future). As proposed the discussion can be moved here. In my opinion having a concrete draft how things are going to work from a user

D13745: Implement support for virtual desktops on Wayland

ngraham added a comment. In D13745#286544 , @hein wrote: > Can we discuss this somewhere else, e.g. on plasma-devel or in one of the Plasma monday meetings? This is a review thread for a libtaskmanager code patch. +1, let's do that elsewh

D13745: Implement support for virtual desktops on Wayland

abetts added a comment. The dev team has been in talks with the VDG about this change. We are OK with the change. We understand that before we make any visual changes, we need to, at least, provide the same functionality that we have in X11 to what we want to have in Wayland. The VDG is curr

D13745: Implement support for virtual desktops on Wayland

hein added a comment. Can we discuss this somewhere else, e.g. on plasma-devel or in one of the Plasma monday meetings? This is a review thread for a libtaskmanager code patch. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13745 To: hein, mart, mvourlakos

D13864: [Splash Screen KCM] Fix "no thumbnail" icon for "None"

This revision was automatically updated to reflect the committed changes. Closed by commit R119:50b1acf4016a: [Splash Screen KCM] Fix "no thumbnail" icon for "None" (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13864?vs=37092&id=

D13745: Implement support for virtual desktops on Wayland

mvourlakos added a comment. In D13745#286501 , @hein wrote: > A lot of this is still up in the air, but here's the rough plan: > > 0. X11 will remain unchanged. The feature set of Activities will remain unchanged. > > 1. For 5.14, we want

D13856: Fix crash on post-initial refresh()

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e1252c6e40ac: Fix crash on post-initial refresh() (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13856?vs=37105&id=37107 REVISION DETAIL

D13856: Fix crash on post-initial refresh()

hein updated this revision to Diff 37105. hein retitled this revision from "Work around KActivitiesStats' ResultsModel emitting wrong moves" to "Fix crash on post-initial refresh()". hein edited the summary of this revision. hein added a comment. Drop the hack. REPOSITORY R119 Plasma Deskto

D13745: Implement support for virtual desktops on Wayland

hein added a comment. A lot of this is still up in the air, but here's the rough plan: 0. X11 will remain unchanged. The feature set of Activities will remain unchanged. 1. For 5.14, we want to have virtual desktops working on Wayland, with feature parity to X11. Activities will not

D13745: Implement support for virtual desktops on Wayland

mvourlakos added a comment. In D13745#286491 , @hein wrote: > Michail: Please follow this review, as these API changes might impact Latte Dock, too. :) no prob... this will be a big change so it will break Latte. Latte v0.8 is a very

D13745: Implement support for virtual desktops on Wayland

hein added a reviewer: mvourlakos. hein added a comment. Michail: Please follow this review, as these API changes might impact Latte Dock, too. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13745 To: hein, mart, mvourlakos Cc: plasma-devel, ragreen, Pi

Raising windows on Wayland

Dear kwiners, Would it be possible to find a way to do so? I know we don't want windows to be positioning themselves willy-nilly on the window stack, but we certainly need to figure out his use-case. What would need to happen to do this? If you need to, I can compile a list of use-cases. Aleix

D13868: [KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address

tagorechandanreddy created this revision. tagorechandanreddy added a reviewer: Plasma. tagorechandanreddy added a project: Plasma. Restricted Application added a subscriber: plasma-devel. tagorechandanreddy requested review of this revision. REVISION SUMMARY The web address for NOAA is no longer

KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 - Build # 116 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.10/116/ Project: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 Date of build: Tue, 03 Jul 2018 11:06:16 + Build duration: 4 min 54 sec and counting JUnit Tests

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil added a comment. In D10040#286064 , @davidedmundson wrote: > @dvratil want me to finish this? @davidedmundson Yes, I'd appreciate it. I won't have time to look into this any time soon, sorry :( REPOSITORY R127 KWayland REVIS

D13752: Build solidautoeject only on FreeBSD

broulik updated this revision to Diff 37098. broulik retitled this revision from "Kill solidautoeject" to "Build solidautoeject only on FreeBSD". broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - Keep it around for FreeBSD

D13752: Kill solidautoeject

adridg added a comment. - Start systemsettings; under *workspace*, *startup and shutdown*, find *background services*. - Untick the box for *Drive Ejector*; also check status is *not running*, click *stop* button if it is still running. - Insert CD, pick *open in file manager* from the de

KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 - Build # 115 - Failure!

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ hudson.remoting.ChannelClosedException: Channel "unknown": Remo

D13863: Don't block startplasma sending DBus call to KSplash

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0470689f03de: Don't block startplasma sending DBus call to KSplash (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13863?vs=37091&id=

D13864: [Splash Screen KCM] Fix "no thumbnail" icon for "None"

broulik created this revision. broulik added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In JavaScript `undefined` does not convert to empty string, s

D13863: Don't block startplasma sending DBus call to KSplash

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Copy of D2910 f

D13852: [Device Automounter] Load kded module only if enabled

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2b9c762f9221: [Device Automounter] Load kded module only if enabled (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13852?vs=37070&id=37093#toc REPOSITORY R119 Plasma D

D10342: From 100% plasma cpu usage to normal when using vivaldi

anthonyfieroni added a comment. In D10342#286360 , @jtamate wrote: > Or perhaps is it better to try to create that cache in KServiceTypeTrader? That will be the right place, reading from disk is always costly, it will be better to make se