romangg added inline comments. INLINE COMMENTS
> apol wrote in waylandtestserver.cpp:155 > maybe it's a bit easier to understand if you add an else instead of a return? The coding style recommendation in general is to return as early as possible instead of using else. > apol wrote in waylandtestserver.cpp:160 > Won't the using code expect `configChanged` to be emitted after > `configReceived`? In `testApplyOnPending` it waits on `configReceived` and then on `configChanged`. REPOSITORY R110 KScreen Library BRANCH fixBlockingSignal REVISION DETAIL https://phabricator.kde.org/D12517 To: romangg, #plasma, davidedmundson Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
