D10342: From 100% plasma cpu usage to normal when using vivaldi

jtamate added a comment. In D10342#286023 , @hein wrote: > This patch doesn't make any sense. It's setting up a cache for something computed from data that's subject to change, and it's never evicting it when that data changes. To make i

D13856: Work around KActivitiesStats' ResultsModel emitting wrong moves

hein added a comment. FWIW: I'm not going to make changes to this revision until the KActivitiesStats bug is fixed, which as mentioned I don't have time to fix. So this revision is stuck for now (unless I go for maintainer authority, which the situation must show). REPOSITORY R119 Plasma

D13856: Work around KActivitiesStats' ResultsModel emitting wrong moves

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. The parental changes totally make sense. +1 to that. As for the reload. We shouldn't be working round KDE code. If there's a bug it should be fixed at the rig

D13776: Move remaining salt file operations into unprivileged processes

aacid added a comment. Are you saying that there are files that root can't read but the user can? REPOSITORY R107 KWallet PAM Integration REVISION DETAIL https://phabricator.kde.org/D13776 To: fvogt, #plasma, aacid Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jens

D13856: Work around KActivitiesStats' ResultsModel emitting wrong moves

hein created this revision. hein added reviewers: davidedmundson, mart. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Works around bug 396102 at negligible performance cost, in a way that won't break when KActivitiesStats gets fixed.

D13849: WIP: Add fractional scaling to wayland scaling GUI

gvarsanyi added inline comments. INLINE COMMENTS > outputconfig.cpp:145 > + > +mScale->addItem(i18nc("Scale multiplier, show everything at 200% > normal scale", "2x"), 2.0); > connect(mScale, > static_cast(&QComboBox::activated), For some extra-high DPI displays even higher se

D13853: Fix setting primary connector if primary output changed

hoffmannrobert created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY If a user logged in with one screen connected plugs in a second screen, which become

D13852: [Device Automounter] Load kded module only if enabled

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY There's no point in loading the entire module when

D13850: Remove pointless setMin/setMax size on DesktopView

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY On X, this is entirely useless.There's a spec

D13849: WIP: Add fractional scaling to wayland scaling GUI

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY DO NOT MERGE AS-IS REPOSITORY R104 KScreen

D13841: [Places Runner] Fix opening search and timeline URLs

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5a951e9a7eb8: [Places Runner] Fix opening search and timeline URLs (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13841?vs=37036&id=

D13844: [Places Runner] Add place category as subtext

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f896fb554e8e: [Places Runner] Add place category as subtext (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13844?vs=37046&id=37062

D13840: [Places Runner] Fix opening devices

This revision was automatically updated to reflect the committed changes. Closed by commit R120:12b3fb2e3b81: [Places Runner] Fix opening devices (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13840?vs=37032&id=37060#toc REPOSITORY R120 Plasma Workspace CHANGES

D10040: Add serial number and EISA ID to OutputDevice interface

davidedmundson added a comment. In another patch I'm doing a V2 of this interface in the next frameworks cycle. May as well try to merge this at the same time so we only have 1 version bump? @dvratil want me to finish this? REPOSITORY R127 KWayland REVISION DETAIL https://phabrica

D13845: Fix Enhanced Media Controls disabled state

This revision was automatically updated to reflect the committed changes. Closed by commit R856:e992f0f1c9ef: Fix Enhanced Media Controls disabled state (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13845?vs=37050&id=

D10342: From 100% plasma cpu usage to normal when using vivaldi

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. This patch doesn't make any sense. It's setting up a cache for something computed from data that's subject to change, and it's never evicting it when that data changes. REPOSITORY

D13845: Fix Enhanced Media Controls disabled state

broulik created this revision. broulik added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When this code ran, settings weren't loaded yet, so the ch

D13844: [Places Runner] Add place category as subtext

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This allows to tell between "Pictures" loc

D13818: Port from KStandardDirs to QStandardPaths

This revision was automatically updated to reflect the committed changes. Closed by commit R116:f327922e60fb: Port from KStandardDirs to QStandardPaths (authored by kossebau). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13818?vs=369

D13841: [Places Runner] Fix opening search and timeline URLs

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, franckarrecot, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `KFilePlacesModel` internal

D13840: [Places Runner] Fix opening devices

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The codepath for opening devices was never actually