broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY The codepath for opening devices was never actually entered as always a `QUrl` was set as data. This resulted in errors like "Cannot open URL /org/freedesktop/someudi". Moreover, for some reason the `run()` code created a new `KFilePlacesModel` but since devices are added delayed, searching for a device in the model right after creation doesn't work. The code is adjusted to use the one `KFilePlacesModel` instance in the helper, since `run()` is executed on the main thread anyway. TEST PLAN 5.12 branch? Typed "500", got my "500 MiB" test partition listed, clicked it, it would mount and then open Opening other locations like "Projects" still works fine REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13840 AFFECTED FILES runners/places/placesrunner.cpp runners/places/placesrunner.h To: broulik, #plasma, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
