D13774: [QDBusMenuBar] Guard m_window with a QPointer

broulik created this revision. broulik added reviewers: Plasma, davidbekham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It can be deleted without us knowing for MDI windows a

D13772: Add AppStream metadata

pino requested changes to this revision. pino added inline comments. INLINE COMMENTS > org.kde.ksysguard.appdata.xml:11 > +System Guard allows you to monitor information and statistics about > your system. > +In addition to monitoring the local system, it can connect to remote > systems

D13772: Add AppStream metadata

mak requested changes to this revision. mak added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > org.kde.ksysguard.appdata.xml:2 > + > + > + KSysGuard Nitpick: Use `desktop-application` > org.kde.ksysguard.appdata.xml:7 > + org.kde.ksysguard > + CC0-1.0 > +

D13772: Add AppStream metadata

ngraham created this revision. ngraham added reviewers: Plasma, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Add AppStream Metadata for KSysGuard, since it's currently la

D13772: Add AppStream metadata

ngraham added a comment. Also, I'd appreciate it if someone could please check my choice of licenses; I'm not 100% sure that I chose the right ones. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D13772 To: ngraham, #plasma, apol Cc: plasma-devel, ragreen, Pitel,

D13767: Touchpad KCM Pointer Speed Slider Improvement

This revision was automatically updated to reflect the committed changes. Closed by commit R119:86e674c6a2b9: Touchpad KCM Pointer Speed Slider Improvement (authored by furkantokac). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13767?vs=36801&id=36802

D13767: Touchpad KCM Pointer Speed Slider Improvement

furkantokac updated this revision to Diff 36801. furkantokac added a comment. Comment correction. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13767?vs=36783&id=36801 BRANCH arcpatch-D13767 REVISION DETAIL https://phabricator.kde.org/D13767

D13694: Fix wrong availability of profiles and ports.

akrutzler added a comment. Good. :) I don't have commit rights yet so I think I can't do it there. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D13694 To: akrutzler, nicolasfella, broulik, drosca Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliez

D13767: Touchpad KCM Pointer Speed Slider Improvement

romangg added inline comments. INLINE COMMENTS > main.qml:248 > if (touchpad != undefined && enabled && !root.loading) { > // transform slider range [1, 10] to libinput's pointer > acceleration range [-1, 1] > +// by *10 and /10, we ignor

D13770: Only show available ports in port selection

nicolasfella created this revision. nicolasfella added a reviewer: drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Unavailable ports are marked as unavailable, but ca

D13591: Set complete vectors instead of creting them at runtime

ngraham added a reviewer: Plasma. ngraham added a comment. Sadly Breeze lost its maintainer recently, so reviewing this is going to have to be a community effort. Adding more people. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D13591 To: tcanabrava, #breeze, #plasm

D7155: Implement sorting of the device tree items

This revision was automatically updated to reflect the committed changes. Closed by commit R102:7c0f85162ee9: Implement sorting of the device tree items (authored by isaact, committed by cfeck). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7155?vs=26293&

D13694: Fix wrong availability of profiles and ports.

nicolasfella added a comment. I found the issue and this patch solves it. +1 from me, but @drosca should also approve since he is the maintainer. While you're at it, can you please make the same change for https://cgit.kde.org/pulseaudio-qt.git ? It suffers from the same issue. REPOSITORY

D13767: Touchpad KCM Pointer Speed Slider Improvement

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. FWIW, you can mark those comments as done. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D13767 To: furkantokac, ngraham, romangg, #plas

D13694: Fix wrong availability of profiles and ports.

nicolasfella added a comment. It does not regress any more. I did not observe any issue with the previous code so I can't confirm it fixes things, but the change looks sensible to me. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D13694 To: akrut

D13767: Touchpad KCM Pointer Speed Slider Improvement

furkantokac updated this revision to Diff 36783. furkantokac added a comment. "value" part of last "Slider" patch is reverted since that kind of changes will be handled with another patch. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13767?vs=3678

D13767: Touchpad KCM Pointer Speed Slider Improvement

furkantokac added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:239 > Let's do this in a separate commit where we change it along with the same > value in the Mouse KCM. Sure it will be better. Thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.o

D13767: Touchpad KCM Pointer Speed Slider Improvement

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Almost perfect, just one issue below: INLINE COMMENTS > main.qml:239 > if (!enabled) { > -value = 0.1 > +value = 0.0 >

D13767: Touchpad KCM Pointer Speed Slider Improvement

furkantokac created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. furkantokac requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D13767 AFFECT

D13745: Implement support for virtual desktops on Wayland

hein added a comment. FWIW: I want to continue with this for now because under the current usage it's still better for performance and lower risk, but longer-term I might refactor VirtualDesktopInfo and ActivityInfo into {AbstractWorkspaceModel,VirtualDesktopModel,ActivityModel} and replace

D13752: Kill solidautoeject

anthonyfieroni added a comment. I have looking on https://bugs.kde.org/show_bug.cgi?id=394348 that's using same interface when ISO is mounting? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13752 To: broulik, #plasma, #frameworks, adridg, davidedmundson,

D13760: [Media Frame] Fix history length property

dfaure added inline comments. INLINE COMMENTS > davidedmundson wrote in mediaframe.cpp:336 > This could have just been an else of the branch above And then one day someone adds a check for contains() before prepend(), for instance, and you would need to come back to this structure of the code.

D13760: [Media Frame] Fix history length property

This revision was automatically updated to reflect the committed changes. Closed by commit R114:c9908d08a281: [Media Frame] Fix history length property (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13760?vs=36767&id=36768 REVISIO

D13760: [Media Frame] Fix history length property

davidedmundson accepted this revision. davidedmundson added inline comments. INLINE COMMENTS > mediaframe.cpp:336 > + > +if (oldCount != m_history.count()) { > +emit historyLengthChanged(); This could have just been an else of the branch above REPOSITORY R114 Plasma Addons REVISI

D13760: [Media Frame] Fix history length property

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Makes sense, binding needs to be updated when the value changes. Thanks for the fix! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D13760 To: broulik,

D13760: [Media Frame] Fix history length property

broulik created this revision. broulik added reviewers: Plasma, dfaure. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY An invokable cannot be notified. CCMAIL: dev.lar...@gm

Plasma 5.12.6 LTS

Plasma 5.12.6 LTS sources are available for packaging with many fixes to Discover and Plasma Desktop https://www.kde.org/announcements/plasma-5.12.6.php

D5579: Introduce QQuickItem to nest kwin_wayland

davidedmundson commandeered this revision. davidedmundson added a reviewer: bdhruve. davidedmundson added a comment. FWIW, this code now lives on in some code I'm writing (with EGL support as well as SHM). I don't think this is the right place. Kwin isn't going to be the one using it, an

KDE CI: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20powerdevil%20stable-kf5-qt5%20SUSEQt5.10/17/ Project: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Jun 2018 11:22:25 + Build duration: 12 min and counting JUnit Tests

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 - Build # 11 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20SUSEQt5.10/11/ Project: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Jun 2018 11:22:28 + Build duration: 11 min and counting JUnit Tes

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10 - Build # 9 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20FreeBSDQt5.10/9/ Project: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 27 Jun 2018 11:22:24 + Build duration: 3 min 27 sec and counting

KDE CI: Plasma systemsettings stable-kf5-qt5 SUSEQt5.10 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20systemsettings%20stable-kf5-qt5%20SUSEQt5.10/21/ Project: Plasma systemsettings stable-kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Jun 2018 11:22:16 + Build duration: 2 min 46 sec and counting JU

D13752: Kill solidautoeject

broulik added a comment. > It's not clear to me what this revision is trying to change (in terms of user-visible behavior) or how to test the change I think you could test it by disabling the "Drive Ejector" module in "Background Services" (kded settings) in System Settings. If pressing

D13752: Kill solidautoeject

adridg added a comment. It's not clear to me what this revision is trying to change (in terms of user-visible behavior) or how to test the change; what I've written above is current behavior on FreeBSD 11 with Plasma 5.12.5; HAL is running. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D13752: Kill solidautoeject

adridg added a comment. Since the ticket is rather unclear on what functionality is being tested, or how: - Put a CD with an ISO9660 filesystem in the drive (I used one with Debian from 1995 on it) - When device notifier pops up, pick "open with filemanager" (`*`) - Ensure the silesy

D13679: Fix recent toolbar layout regression

mart added a comment. In D13679#283361 , @ngraham wrote: > Aleix implemented a better version of this with https://cgit.kde.org/discover.git/commit/?id=d5f7c102854c41e4ee9eb00cfb979993f2396233 I'm still not sure about it. is it supposed

D13752: Kill solidautoeject

mart added a comment. +1 (maybe build conditionally on freebsd if it's *really* necessary there) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13752 To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin Cc: mart, plasma-devel, r

D13611: [Fonts KCM] disable "to" label when its companion controls are also disabled

broulik added inline comments. INLINE COMMENTS > main.qml:103 > Layout.preferredWidth: formLayout.maxImplicitWidth > enabled: antiAliasingComboBox.currentIndex == 0 > QtControls.SpinBox { Also could have been done here, since `enabled` propagates recursivel

D13717: Implement Seek() and Seeked()

broulik added a comment. Thanks for your patch! There's a minor issue but other than that it's good. Can you also verify this doesn't cause a loop when using Plasma's media controller applet? INLINE COMMENTS > content-script.js:177 > +if (activePlayer) { > +if (!activePlayer.se

D13752: Kill solidautoeject

fvogt added a comment. Umount on eject press still works even without the kded module loaded. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13752 To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin Cc: plasma-devel, ragreen, Pit

D13751: [Device Monitor] Create KFilePlacesModel on demand

This revision was automatically updated to reflect the committed changes. Closed by commit R97:688e04921094: [Device Monitor] Create KFilePlacesModel on demand (authored by broulik). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13751?vs=36746&id=36748 REVI

D13752: Kill solidautoeject

broulik created this revision. broulik added reviewers: Plasma, Frameworks, adridg, davidedmundson, dfaure, fvogt, ervin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Solid's

D13751: [Device Monitor] Create KFilePlacesModel on demand

broulik created this revision. broulik added reviewers: Plasma, drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Doing so can be quite expensive as it queries devices and w