D7155: Implement sorting of the device tree items

davidedmundson accepted this revision. davidedmundson added a comment. @cfeck go for it. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7155 To: isaact, #plasma, cfeck, broulik, davidedmundson Cc: davidedmundson, cfeck, broulik, anthonyfieroni, plasma-devel, rag

D7155: Implement sorting of the device tree items

cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. Looks like we lost tracking this. If nobody objects, I will commit this next week. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7155 To: isaact, #plasma, cfe

D13663: Refactor the Global ToolBar concept

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Also, this regresses the Install button width in Discover, and other main action buttons, which you can see in your screen recording. They're now very narrow and don't have enou

D13663: Refactor the Global ToolBar concept

ngraham added a comment. I don't know if it was supposed to, but FWIW this does not fix https://bugs.kde.org/show_bug.cgi?id=395455. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13663 To: mart, #kirigami Cc: IlyaBizyaev, ngraham, davidedmundson, plasma-devel, ap

D13663: Refactor the Global ToolBar concept

IlyaBizyaev added inline comments. INLINE COMMENTS > ToolBarApplicationHeader.qml:42 > > +Component.onCopleted: print("Warning: ToolbarApplicationHeader is > deprecated, remove and use the automatic internal toolbar instead.") > pageDelegate: Item { A typo :) REPOSITORY R169 Kirig

D13663: Refactor the Global ToolBar concept

ngraham added inline comments. INLINE COMMENTS > ToolBarApplicationHeader.qml:42 > > +Component.onCopleted: print("Warning: ToolbarApplicationHeader is > deprecated, remove and use the automatic internal toolbar instead.") > pageDelegate: Item { `onCompleted` REPOSITORY R169 Kirig

D13664: [WIP] Fix use of pipes in MD RAID code

fvogt updated this revision to Diff 36480. fvogt added a comment. Remove cleanup again - it breaks stuff. REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13664?vs=36477&id=36480 BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D13664 A

KDE CI: Plasma discover kf5-qt5 SUSEQt5.10 - Build # 38 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.10/38/ Project: Plasma discover kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Jun 2018 17:15:28 + Build duration: 52 sec and counting CONSOLE OUTPUT [...truncated

D13664: [WIP] Fix use of pipes in MD RAID code

fvogt updated this revision to Diff 36477. fvogt added a comment. Comment got lost - readded. REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13664?vs=36474&id=36477 BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D13664 AFFECTED FILE

D13664: [WIP] Fix use of pipes in MD RAID code

fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. fvogt requested review of this revision. REVISION SUMMARY Use pipe2 with O_CLOEXEC to not leak FDs and close the pipe after readin

D13663: Refactor the Global ToolBar concept

mart added a comment. Toolbar behavior in Desktop mode F5927004: vokoscreen-2018-06-21_17-50-18.mkv Toolbar behavior in Mobile mode, including testing of features that were already there but kinda broken F5927008: vokoscreen-2018-06-21_17-51-30.

D13481: Recommend window border size "None"

ngraham added a comment. In D13481#281295 , @graesslin wrote: > In D13481#280754 , @ngraham wrote: > > > Right. That's not a workflow I think I've ever seen anyone do with a windowed game. > >

D13663: first prototype of moval of handles into PageRow

mart added a comment. In D13663#281331 , @davidedmundson wrote: > Please can you add a description and check that the changes here are all relevant to that. sure, it was a screwup of the arc tool :) REPOSITORY R169 Kirigami REVISION

D13663: first prototype of moval of handles into PageRow

davidedmundson added a comment. Please can you add a description and check that the changes here are all relevant to that. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13663 To: mart Cc: davidedmundson, plasma-devel, apol, mart, hein

D13663: first prototype of moval of handles into PageRow

mart updated this revision to Diff 36472. mart added a comment. - deprecate ToolbarApplicationHeader REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13663?vs=36471&id=36472 BRANCH mart/pageRowHeaders REVISION DETAIL https://phabricator.kde.org/D13663

D13663: first prototype of moval of handles into PageRow

mart created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY minimally functioning toolbar fix auto hide toolbars in mobile correct resizing of the toolbar

D13481: Recommend window border size "None"

graesslin added a comment. To everyone here: you are extremely experienced developers and software users, partially working in the window manager area. Of course you understand why the dead zone happens and of course you are able to adapt to it. But please think of your users. I fear they wo

D13481: Recommend window border size "None"

graesslin added a comment. In D13481#280754 , @ngraham wrote: > Right. That's not a workflow I think I've ever seen anyone do with a windowed game. Did you read my comment? Let me quote: "please don't tell me that nobody would use a fps

D13656: Show release date inline with version string

This revision was automatically updated to reflect the committed changes. Closed by commit R134:c4a74b532cd2: Show release date inline with version string (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13656?vs=36458&id=3

D13656: Show release date inline with version string

ngraham added inline comments. INLINE COMMENTS > apol wrote in ApplicationPage.qml:305 > how about: > > text: version.length === 0 ? "" > : releaseDate.length === 0 ? version > : i18n("%1, released on %2", version, releaseDate) Clever, but IMHO a bit less readable. REPOS

D13656: Show release date inline with version string

apol added inline comments. INLINE COMMENTS > ApplicationPage.qml:305 > elide: Text.ElideRight > -text: version ? version : "" > +text: versionString() > } how about: text: version.length === 0 ? "" : releaseDate.length

D13656: Show release date inline with version string

ngraham created this revision. ngraham added a reviewer: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The release date is inherently tied to a specific

KDE CI: Plasma discover kf5-qt5 SUSEQt5.10 - Build # 35 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.10/35/ Project: Plasma discover kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Jun 2018 13:02:33 + Build duration: 51 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma discover kf5-qt5 SUSEQt5.10 - Build # 34 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.10/34/ Project: Plasma discover kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Jun 2018 12:36:43 + Build duration: 18 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma discover stable-kf5-qt5 SUSEQt5.10 - Build # 52 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20SUSEQt5.10/52/ Project: Plasma discover stable-kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Jun 2018 12:23:52 + Build duration: 4 min 42 sec and counting CONSOLE OUTPUT

KDE CI: Plasma discover stable-kf5-qt5 SUSEQt5.10 - Build # 51 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20SUSEQt5.10/51/ Project: Plasma discover stable-kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Jun 2018 12:17:28 + Build duration: 53 sec and counting CONSOLE OUTPUT