D12835: Draw borders around side panels by default

2018-05-12 Thread Henrik Fehlauer
rkflx added a comment. If you revert a design decision, your summary should include a reference to the arguments of the original decision, a justification for changing it back again based on those, and you should try to get consent from the original authors and designers. In general it'

D12835: Draw borders around side panels by default

2018-05-12 Thread Nathaniel Graham
ngraham added a subscriber: abetts. ngraham added a comment. I wasn't around for the KDE4/oxygen days, so I wasn't aware this represented a reversion of anything; I just think this patch results in better visual design that the status quo. Breeze may be a minimalistic theme, but minimali

D12837: Split replaceAccount from addAccountToCache

2018-05-12 Thread Valeriy Malov
valeriymalov created this revision. valeriymalov added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. valeriymalov requested review of this revision. REVISION SUMMARY We were accidentally overwriting first account in t

D12835: Draw borders around side panels by default

2018-05-12 Thread Henrik Fehlauer
rkflx added a comment. Is it really necessary to revert design decisions made for Breeze (compared to its predecessor Oxygen)? FWIW, I find the "after" screenshots look quite dated, and I cannot see any functional or visual improvement. In addition, I find the overall design direction qu

D12835: Draw borders around side panels by default

2018-05-12 Thread Christoph Feck
cfeck added a comment. While I also use this setting, we probably should not make it default, unless the QtQuick dialogs (try desktop RMB > Configure Desktop ...) also respects this setting. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D12835 To: ngraham Cc: cfeck,

D12102: Port Language KCM to Qt Quick

2018-05-12 Thread Eike Hein
hein added a comment. In D12102#261174 , @mart wrote: > if i select more than one language, only one will be added, the others will be added as "unknown" I can't reproduce this, but will have a look. REPOSITORY R119 Plasma Desktop REV

D12835: Draw borders around side panels by default

2018-05-12 Thread Nathaniel Graham
ngraham created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch changes the defaults to draw borders around side panels in settings windows. Drawin

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

2018-05-12 Thread Martin Kostolný
martinkostolny added a comment. Hello after some time. I finally manage to more or less finish the layout rework I was planning. I tried to work in most of what we discussed here. @Pitel Radek, if You have some time, can You please check out `layout-rework` branch and try if You manage t

D12823: Workaround for binding loop in Material Theme

2018-05-12 Thread Aleix Pol Gonzalez
apol added a comment. I've seen this warning, never seen it crash. This looks like a workaround though. Do you know why it's happening? Why's theme.Material.accent changing? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12823 To: Dax Cc: apol, plasma-devel,

D12822: Added null check in OverlayDrawer

2018-05-12 Thread Aleix Pol Gonzalez
apol added a comment. Already done in https://phabricator.kde.org/D12741. Or I'm missing something? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12822 To: Dax Cc: apol, plasma-devel, davidedmundson, mart, hein