ngraham created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch changes the defaults to draw borders around side panels in 
settings windows.
  
  Drawing the full border makes the window feel less muddy and imparts clarity 
by visually separating the navigation panel from the content. I think it's a 
pretty clear visual improvement.

TEST PLAN
  Log in with a new user account and check out various KDE apps settings 
windows:
  
  Breeze Light
  ------------
  
  Dolphin settings window, before:
  
  Dolphin settings window, after:
  
  Gwenview settings window, before:
  
  Gwenview settings window, after:
  
  Kate settings window, before:
  
  Kate settings window, after:
  
  Okular settings window, before:
  
  Okular settings window, after:
  
  Spectacle settings window, before:
  
  Spectacle settings window, after:
  
  Breeze Dark
  -----------
  
  Dolphin settings window, before:
  
  Dolphin settings window, after:
  
  Gwenview settings window, before:
  
  Gwenview settings window, after:
  
  Kate settings window, before:
  
  Kate settings window, after:
  
  Okular settings window, before:
  
  Okular settings window, after:
  
  Spectacle settings window, before:
  
  Spectacle settings window, after:

REPOSITORY
  R31 Breeze

BRANCH
  borders-around-settings-window-side-panels (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12835

AFFECTED FILES
  kstyle/breeze.kcfg

To: ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to