D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

ngraham added a comment. In D12252#254928 , @zzag wrote: > I've just noticed that it's calling `setMinimumSize`. Why? (especially, with such a big minimum size) > > What about icon based view mode, i.e. the old settings layout? Hmm, t

D12498: Fully remove `Application Name` from Details panel

sharvey added inline comments. INLINE COMMENTS > bruns wrote in AuthDialog.cpp:349 > According to > https://www.freedesktop.org/software/polkit/docs/latest/polkit.8.html#polkit-rules > `description` is not optional, so the correct statement is "Missing" I was checking to see if this was still o

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey added a comment. In D12252#254928 , @zzag wrote: > I've just noticed that it's calling `setMinimumSize`. Why? (especially, with such a big minimum size) > > What about icon based view mode, i.e. the old settings layout? The new setti

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey updated this revision to Diff 33667. sharvey marked an inline comment as done. sharvey added a comment. - Remove redundant size setting REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12252?vs=33208&id=33667 BRANCH arcpatch-D12252 REVISIO

KDE CI: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10 - Build # 9 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20SUSEQt5.10/9/ Project: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10 Date of build: Fri, 04 May 2018 21:47:36 + Build duration: 2 min 22 sec and counting

KDE CI: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10 - Build # 8 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20SUSEQt5.10/8/ Project: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.10 Date of build: Thu, 03 May 2018 14:11:57 + Build duration: 1 day 7 hr and counting C

D12702: Avoid giving an stderr to kwallet

maximilianocuria updated this revision to Diff 33663. maximilianocuria added a comment. A somewhat simpler version, just delay the close(2) call. I was testing this and trying to look for some documentation about the use of the fds in pam modules. I'm pretty sure that you can't keep them, b

D12702: Avoid giving an stderr to kwallet

davidedmundson added a comment. Thanks for investigating. Might be cleaner to explicitly open the stderr FD earlier and not do anything with it, which would force the socket() call to give us an unused one. But if that doesn't work...+1 from me. REPOSITORY R107 KWallet PAM Integra

D12702: Avoid giving an stderr to kwallet

maximilianocuria created this revision. maximilianocuria added reviewers: Plasma, aacid. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. maximilianocuria requested review of this revision. REVISION SUMMARY The fixes for CVE-2018-10380 intr

D12701: Remove D10890 workaround

aleksejshilin created this revision. aleksejshilin added reviewers: Plasma, broulik, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aleksejshilin requested review of this revision. REVISION SUMMARY D10890

D12091: HIG entry for On-demand pattern and swipe list item

colomar added inline comments. INLINE COMMENTS > fabianr wrote in ondemand.rst:27 > My intention was to suggest switching to a navigation pattern like > "Master-Detail" or "Column-based navigation", so each item has its own > content page where more actions could easily be displayed. > > What

D12699: Don't allow showing/hiding the drawer when there's no handle

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY If there's no handle and the drawer is modal, we can understand th

D12694: Properly fix the native messaging host file

mwolff added a comment. It compiles, how do I test it? Can you please also add a `README` to the root of this project that explains what this is, does and how to use it? thanks REPOSITORY R856 Plasma Browser Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D1

Re: D12698: WIP; advert

​I hate arc sometimes. I pressed control+c to cancel and it thought that meant "send anyway" with a garbage title :(

D12698: WIP; advert

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY squashme REPOSITORY R856 Plasma Browser Integration BRANCH store_link_popup REV

D12091: HIG entry for On-demand pattern and swipe list item

fabianr updated this revision to Diff 33631. fabianr added a comment. - Fixed typo REPOSITORY R985 KDE Human Interface Guidelines CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12091?vs=33609&id=33631 BRANCH swipe REVISION DETAIL https://phabricator.kde.org/D12091 AFFECTED

D12091: HIG entry for On-demand pattern and swipe list item

fabianr marked an inline comment as done. fabianr added inline comments. INLINE COMMENTS > colomar wrote in ondemand.rst:27 > Since this is a command pattern, shouldn't this link to command patterns > instead of navigation patterns? My intention was to suggest switching to a navigation pattern

D12091: HIG entry for On-demand pattern and swipe list item

colomar added a comment. See inline comments. Otherwise it looks good! INLINE COMMENTS > ondemand.rst:27 > + on-demand controls. If you need more actions, choose a different > + :doc:`navigation pattern `. > +- Only use on-demand controls, if the actions are the same for each item. Sin

D12686: Fix sidebar view regression of not prompting about unsaved changes

davidedmundson updated this revision to Diff 33629. davidedmundson added a comment. Remove debug stupid arc. Spend ages selectively choosing the hunks I want, and then it goes and adds them back anyway to "help". REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://ph

D12686: Fix sidebar view regression of not prompting about unsaved changes

davidedmundson updated this revision to Diff 33628. davidedmundson added a comment. Remove debug stupid arc. Spend ages selectively choosing the hunks I want, and then it goes and adds them back anyway to "help". REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://p

D12686: Fix sidebar view regression of not prompting about unsaved changes

davidedmundson updated this revision to Diff 33627. davidedmundson added a comment. Also fixes the UI on cancel Checkable property would be updated internally on clicked, breaking our binding and becoming checked on clicked regardless The background color is set by if (checked || hig

D12683: Guard BookmarksRunner thread use

This revision was automatically updated to reflect the committed changes. Closed by commit R120:947b03d674e8: Guard BookmarksRunner thread use (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12683?vs=33556&id=33624 REVISI

D12694: Properly fix the native messaging host file

bshah created this revision. bshah added reviewers: mwolff, broulik, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY - Previous approch broke the installation for th

D12091: HIG entry for On-demand pattern and swipe list item

fabianr updated this revision to Diff 33609. fabianr added a comment. - Updated visuals for listview and folderview REPOSITORY R985 KDE Human Interface Guidelines CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12091?vs=32867&id=33609 BRANCH swipe REVISION DETAIL https://phab

D12091: HIG entry for On-demand pattern and swipe list item

mart added a comment. ok for the text, the screenshots would need update: both of them at the moment are desktop, which is ok (i would add the mouse cursor) and one mobile is needed, provided here: Desktop, listview: F5833032: image.png Mobile,

D12091: HIG entry for On-demand pattern and swipe list item

fabianr added inline comments. INLINE COMMENTS > mart wrote in ondemand.rst:11 > maybe add a dolphin screenshot as well with the + on hover? (or folderview) There is a dolphin screenshot with the hover in the desktop section, (line 48+) REPOSITORY R985 KDE Human Interface Guidelines REVISION