D11533: [kstyle] create shadow tiles more explicitly

2018-04-09 Thread Vlad Zagorodniy
zzag added a comment. Well, after thinking for a while, I think shadowTiles should be called in loadConfig. It doesn't make much sense to create something in reset method. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11533 To: zzag, #breeze, hpereiradacosta Cc: pla

D9792: even slimmer scrollbars

2018-04-09 Thread Vlad Zagorodniy
zzag added a comment. I'm sorry, but these scrollbars have too thin sliders. F5801991: scrollbar.png Slider occupies only 15% of space in horizontal direction, that's a "big" waste of space. REPOSITORY R31 Breeze REVISION DETAIL https://ph

D11533: [kstyle] create shadow tiles more explicitly

2018-04-09 Thread Vlad Zagorodniy
zzag updated this revision to Diff 31774. zzag added a comment. Call shadowTiles in the reset method. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11533?vs=30066&id=31774 BRANCH explicit-shadow-creation REVISION DETAIL https://phabricator.kde.org/D115

D12069: Implement a keyboard selector plasmoid

2018-04-09 Thread Eike Hein
hein added a comment. Dated shots but relevant: https://blogs.gnome.org/mclasen/2012/09/21/input-sources-in-gnome/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12069 To: apol, #plasma Cc: hein, graesslin, broulik, davidedmundson, plasma-devel, ragreen, P

D12069: Implement a keyboard selector plasmoid

2018-04-09 Thread Eike Hein
hein added a comment. In D12069#243315 , @davidedmundson wrote: > Is that something that can happen now? We have a GSoC project in the Ideas list this year that's aimed at it, and there are other Linux desktops that prove it's possible (

D12069: Implement a keyboard selector plasmoid

2018-04-09 Thread David Edmundson
davidedmundson added a comment. > once we switch to a proper model of managing input languages vs. just keyboard layouts in the workspace. Is that something that can happen now? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12069 To: apol, #plasma Cc

D12069: Implement a keyboard selector plasmoid

2018-04-09 Thread Eike Hein
hein added a comment. It's long been known that the keyboard layout switcher SNI is legacy stuff and will eventually become redundant with the Input Method Panel widget once we switch to a proper model of managing input languages vs. just keyboard layouts in the workspace. I suggest thi

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.9 - Build # 16 - Failure!

2018-04-09 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.9/16/ Project: Plasma plasma-vault kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 09 Apr 2018 17:44:52 + Build duration: 2 min 7 sec and counting CONSOLE OUTPUT

D12069: Implement a keyboard selector plasmoid

2018-04-09 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:42 > "apl" and "mao" are 3 letters. > No idea what either of those mean, it's just in the list. I'm not sure whether a substring is the correct solution anyhow. On Wayland we get a proper name like German, but t

D12072: use ConstrainedSquare as formFactor

2018-04-09 Thread Kai Uwe Broulik
broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. This doesn't work. - ```Containment::restore(KConfigGroup&)``` overwrites it with the form factor stored in config - ```SystemTrayContainer``` also overwrites it depending

D11533: [kstyle] create shadow tiles more explicitly

2018-04-09 Thread Vlad Zagorodniy
zzag added a comment. In D11533#243257 , @hpereiradacosta wrote: > Hi Vlad, Hi! :) > Second: I agree that the current code is bug prone, but your foreseen change is not satisfactory either. > The idea with the current code was t

D11289: checkable FormLayout items

2018-04-09 Thread Julian Wolff
This revision was automatically updated to reflect the committed changes. Closed by commit R169:6ac4e62002ae: checkable FormLayout items (authored by progwolff). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11289?vs=29937&id=31751 REVISION DETAIL https:/

D12072: use ConstrainedSquare as formFactor

2018-04-09 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY all systray applets will be in the constrainedsquare formfactor, as they

D11533: [kstyle] create shadow tiles more explicitly

2018-04-09 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. Hi Vlad, First sorry for the late answer ! Second: I agree that the current code is bug prone, but your foreseen change is not satisfactory either. The idea with the current code was to try create the shadows only "once" and if it fails for some reas

D12069: Implement a keyboard selector plasmoid

2018-04-09 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > main.qml:38 > +Plasmoid.preferredRepresentation: Plasmoid.compactRepresentation > +Plasmoid.compactRepresentation: PlasmaComponents.Label { > +fontSizeMode: Text.Fit Also set `height: undefined`, I've seen issues where `Text.Fit` f

D12069: Implement a keyboard selector plasmoid

2018-04-09 Thread David Edmundson
davidedmundson added a comment. > Mimics the behavior of the status notifier item The keyboard kded module when it's used on X has one more option for its SNI - show flag - show label - show label on flag "show layout indicator" and "show for single layout" become just normal

D11955: [Folder View] Set Refresh shortcut on Refresh/Reload

2018-04-09 Thread Kai Uwe Broulik
broulik planned changes to this revision. broulik added a comment. I just noticed that `setUsedByContainment` actually renames the "reload" action to "Refresh desktop", so "refresh" is essentially useless. Will refactor this to get rid of the dedicated "Refresh" action and just use "Reload"

D12069: Implement a keyboard selector plasmoid

2018-04-09 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Mimics the behavior of the status notifier item REPOSITORY R120 Plasma W

Monday meeting minutes

2018-04-09 Thread Marco Martin
Kai Uwe: * Bugfixing in Folder View * Fixed System Settings section headings font (Qt bug with font.bold vs font.weight priority) * Added "aboutToShow" signal for ToolTipArea, allows to defer heavy lifting to when the tooltip is actually shown (vs containsMouse) * Profiling in Dolphin * Tried to fi

D12003: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2

2018-04-09 Thread Alexey Min
This revision was automatically updated to reflect the committed changes. Closed by commit R102:702c7ca86e94: Fix displaying OpenGL info on wayland: do not require OpenGL 3.2 (authored by alexeymin). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12003?vs=

D12000: [ProcessModel] Return invalid QVariant() for when window is not known

2018-04-09 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R111:e3ea3c840d6f: [ProcessModel] Return invalid QVariant() for when window is not known (authored by broulik). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D12063: Add a hidden config option for showing icons on the root level of the menu

2018-04-09 Thread Albert Astals Cid
aacid updated this revision to Diff 31725. aacid added a comment. Update commit author to kdab.com hat REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12063?vs=31723&id=31725 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12063 AFFE

D12063: Add a hidden config option for showing icons on the root level of the menu

2018-04-09 Thread Albert Astals Cid
aacid created this revision. aacid added a reviewer: hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aacid requested review of this revision. TEST PLAN - Menu looks the same with new code - Menu has icons if changing default value