broulik added inline comments.
INLINE COMMENTS
> main.qml:38
> + Plasmoid.preferredRepresentation: Plasmoid.compactRepresentation
> + Plasmoid.compactRepresentation: PlasmaComponents.Label {
> + fontSizeMode: Text.Fit
Also set `height: undefined`, I've seen issues where `Text.Fit` fails to shrink
fully due to `PlasmaComponents.Label` default height
> davidedmundson wrote in main.qml:40
> can you use smallestReadableFont?
`theme.smallestFont` that is
> main.qml:48
> + anchors.fill: parent
> + hoverEnabled: true
> +
Unused
> main.qml:54
> +
> + Plasmoid.status: layout.layouts.length>1 ? PlasmaCore.Types.ActiveStatus
> : PlasmaCore.Types.PassiveStatus
> + Plasmoid.toolTipMainText: i18n("Keyboard Layout")
Coding style, spaces
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D12069
To: apol, #plasma
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
