D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

Pitel added a comment. >> show on: mouse out | mouse in | always (and possibly never show unless it is covered by other options, show on mouse out not available for buttons and appmenu) > > This one I don't fully understand. Why show on: mouse_out|mouse_in for all items is not enough to

Re: Changes to networkmanager-qt - breakage in plasma-workspace

Hi, On pátek 30. března 2018 15:39:59 CEST you wrote: > krop already fixed that > > On Thursday, March 29, 2018 6:21:41 PM EDT Ben Cooksley wrote: > > Hi Jan, > > > > It seems that as part of your recent changes to networkmanager-qt to > > increase the dependency to 1.0.0 you've made some other

D11850: modernize: use auto

zzag added a comment. In D11850#238791 , @davidedmundson wrote: > Fine, but in general I don't think this is a change worth doing in other code unless you're changing the code anyway. I can abandon the patch if you're still not sure whet

D11198: [libbreezecommon] add box shadow helper

zzag added a comment. If someone(in the future, I guess) will decide to optimize the box shadow helper or get rid of fftw, here's a patch to use box blur : https://phabricator.kde.org/P187 Even though box blur may be faster(I haven't benchmarked it), I still would prefer the "true" Gaus

D11849: [kdecoration] properly compare opacity values

zzag abandoned this revision. zzag added a comment. In D11849#238798 , @davidedmundson wrote: > Whilst qFuzzyCompare is indeed needed for comparing a calculation with a value, it's not relevant in all cases, like this. > > We want setOpacity

D6313: Support Icon Scale from Icon naming specification 0.13

ngraham added a comment. In D6313#238605 , @acrouthamel wrote: > I think both of us missed this part at the bottom of @broulik's description: > > > This way you designers can now create dedicated 2x SVGs for those usecases, ie. we can have a

D11849: [kdecoration] properly compare opacity values

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Whilst qFuzzyCompare is indeed needed for comparing a calculation with a value, it's not relevant in all cases, like this. We want setOpacity(actually zero)

D11850: modernize: use auto

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Fine, but in general I don't think this is a change worth doing in other code unless you're changing the code anyway. REPOSITORY R31 Breeze BRANCH modernize-use-auto R

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

martinkostolny added a comment. Sorry for being dark for so long, Radek. I was busy and I hope it will get better. Thanks a lot for your ideas. > Is floating really floating or just another layer of occupying? You are right, it should be another level of occupying. I haven't thought

D11876: Display star ratings

acrouthamel added a comment. Nice placement too. I really, really like how this looks. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11876 To: ngraham, apol, #discover_software_store Cc: acrouthamel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai

D6313: Support Icon Scale from Icon naming specification 0.13

acrouthamel added a comment. In D6313#238697 , @rkflx wrote: > In D6313#238605 , @acrouthamel wrote: > > > @2x-compatible > > > How will this work for 4x / 2.7x / 1.4x / etc. scaling? Of course w

D6313: Support Icon Scale from Icon naming specification 0.13

rkflx added a comment. In D6313#238599 , @ngraham wrote: > ...Unless I'm misunderstanding something obvious, in which case, feel free to ignore my deluded ramblings! You might be mixing up two separate topics: - Optimizing rendering o

D3484: Center systemmonitor window properly on multi-screen setup

valeriymalov added a comment. In D3484#238571 , @cfeck wrote: > But it does no longer remember window size now (and for whatever reason, I cannot get the kwin rules to force an initial window size to work). I thought the consensus was that

D6313: Support Icon Scale from Icon naming specification 0.13

acrouthamel added a comment. I think both of us missed this part at the bottom of @broulik's description: > This way you designers can now create dedicated 2x SVGs for those usecases, ie. we can have a 16px icon as well as a 16px@2x icon rather than it just taking the 32px icon which mig

D6313: Support Icon Scale from Icon naming specification 0.13

ngraham added a comment. In D6313#238595 , @acrouthamel wrote: > I'm just saying if you prefer colored over symbolic line art, that is something for #Breeze or #vdg

D6313: Support Icon Scale from Icon naming specification 0.13

acrouthamel added a comment. I'm just saying if you prefer colored over symbolic line art, that is something for #Breeze or #vdg to work out. Not that they are really taking advantage of anything. The bug h

D6313: Support Icon Scale from Icon naming specification 0.13

ngraham added a comment. If Breeze has been taking advantage of a bug in our implementation of this spec, then we really need to fix Breeze before we fix the bug. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #v

D6313: Support Icon Scale from Icon naming specification 0.13

acrouthamel added a comment. @ngraham and @hein, while I agree that in some instances I like the colored hi-res icons showing, this issue causes a mixture of icons to be displayed depending on the app. The examples here show a nice homogeneous selection of icons that change from A to B, so I

D3484: Center systemmonitor window properly on multi-screen setup

cfeck added a comment. But it does no longer remember window size now (and for whatever reason, I cannot get the kwin rules to force an initial window size to work). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3484 To: valeriymalov, #plasma_workspaces,

D11848: [Kickoff] Reduce hover delay before switching tabs

ngraham added a comment. In D11848#238485 , @hein wrote: > Nate, you misunderstood my original comment. The problem isn't going from tabs to content, it's going from the panel button to a tab. That's why the delay was likely added (I've never wo

D11848: [Kickoff] Reduce hover delay before switching tabs

hein added a comment. Nate, you misunderstood my original comment. The problem isn't going from tabs to content, it's going from the panel button to a tab. That's why the delay was likely added (I've never worked much on Kickoff vs. the other menus we ship, but I have vague memories). REPOS