D7481: Batch window changes events on XCB

hein added a comment. Small request: The TODO file in the lib's folder has a note about this. You can remove it now that it's done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7481 To: davidedmundson, #plasma, hein Cc: ngraham, cfeck, broulik, hein, gra

D11775: Remove dead dataengine code

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Porting clearly isn't happening. Can always

D7481: Batch window changes events on XCB

davidedmundson updated this revision to Diff 30822. davidedmundson edited the summary of this revision. davidedmundson added a comment. debug-- REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7481?vs=30800&id=30822 REVISION DETAIL https://phabric

D11774: Notification dataengine debug category

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phab

D11757: Polish sidebar header appearance

richardbowen added a comment. ok, cool. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D11757 To: ngraham, mart, #plasma, #vdg Cc: davidedmundson, abetts, richardbowen, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mar

D11757: Polish sidebar header appearance

ngraham added a comment. In D11757#236015 , @richardbowen wrote: > The greyborder around the submenu heading isn't consistent with the other main menu heading which have no border, and inconsistent with the Kirigami back button style but otherw

D11757: Polish sidebar header appearance

richardbowen added a comment. The greyborder around the submenu heading isn't consistent with the other main menu heading which have no border, and inconsistent with the Kirigami back button style but otherwise, it looks good. REPOSITORY R124 System Settings REVISION DETAIL https://phab

D7481: RFC: Batch window changes events on XCB

davidedmundson updated this revision to Diff 30800. davidedmundson added a comment. Changed to a version that only caches names as requested. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7481?vs=18588&id=30800 BRANCH master REVISION DETAIL

D7481: RFC: Batch window changes events on XCB

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in xwindowsystemeventbatcher.cpp:35 > Why emit a window change just before you emit a removal? Or is that what > `KWindowSystem` usually does and we rely on that? In a version where we cache all properties, I didn't want to h

D11757: Polish sidebar header appearance

ngraham updated this revision to Diff 30797. ngraham added a comment. Use Kirigami.Units.largeSpacing instead of a hardcoded value REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11757?vs=30794&id=30797 BRANCH polish-sidebar-header-appearance (bra

D11757: Polish sidebar header appearance

ngraham added a comment. In D11757#235930 , @abetts wrote: > I am not sure that I am catching the difference between before and after. Can you please provide screenshots of that? Just for comparison. Here's how it looks right now, without

D11757: Polish sidebar header appearance

davidedmundson added a comment. looks sensible to me REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D11757 To: ngraham, mart, #plasma, #vdg Cc: davidedmundson, abetts, richardbowen, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, seb

D11757: Polish sidebar header appearance

abetts added a comment. I am not sure that I am catching the difference between before and after. Can you please provide screenshots of that? Just for comparison. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D11757 To: ngraham, mart, #plasma, #vdg Cc: abet

D11757: Polish sidebar header appearance

ngraham updated this revision to Diff 30794. ngraham added a comment. Use a more standards-compliant back button appearance, in response to feedback REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11757?vs=30753&id=30794 BRANCH polish-sidebar-head

Re: KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 - Build # 505 - Still Failing!

Error is Solid not being synced. We must remember to wait a few days before pushing patches that rely on framework changes.

KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 - Build # 505 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/505/ Project: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 Date of build: Wed, 28 Mar 2018 10:12:21 + Build duration: 10 min and counting CONSOLE OUTPUT

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 213 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/213/ Project: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 28 Mar 2018 10:12:21 + Build duration: 8 min 36 sec and counting JUnit T

D11754: fix: Klipper notifications visually broken since plasma 5.12

This revision was automatically updated to reflect the committed changes. Closed by commit R120:896950a819ea: fix: Klipper notifications visually broken since plasma 5.12 (authored by tillschafer, committed by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11754?vs=30747&id=3078

D11754: fix: Klipper notifications visually broken since plasma 5.12

tillschafer added a comment. I do not have commit access. Could you please commit this for me? I think it should also go to 5.12 beside the master branch. REPOSITORY R120 Plasma Workspace BRANCH klipper_notification (branched from master) REVISION DETAIL https://phabricator.kde.org/D1

D11754: fix: Klipper notifications visually broken since plasma 5.12

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. I did a patch for Klipper to not use a table but it was quite awkward, I think allowing tables is fine REPOSITORY R120 Plasma Workspace BRANCH klipper_notification (branched from mas

D11764: Use font.weight instead of font.bold

broulik updated this revision to Diff 30783. broulik added a comment. - Remove comment REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11764?vs=30782&id=30783 REVISION DETAIL https://phabricator.kde.org/D11764 AFFECTED FILES sidebar/package/con

D11754: fix: Klipper notifications visually broken since plasma 5.12

broulik added a comment. Do you have commit access? REPOSITORY R120 Plasma Workspace BRANCH klipper_notification (branched from master) REVISION DETAIL https://phabricator.kde.org/D11754 To: tillschafer, davidedmundson, broulik Cc: broulik, fvogt, plasma-devel, ragreen, ZrenBot, lesli

D11764: Use font.weight instead of font.bold

This revision was automatically updated to reflect the committed changes. Closed by commit R124:541598fe398a: Use font.weight instead of font.bold (authored by broulik). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11764?vs=30783&id=30784 REVISION D

D11764: Use font.weight instead of font.bold

broulik created this revision. broulik added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `font.bold` is a pseudo property only forwarding to and readi

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30781. hein added a comment. Be opportunistic and rename InlineMessageType to MessageType. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30710&id=30781 BRANCH master REVISION DETAIL https://phabricator.kde

D10736: Do clamping in the model and add missing lower bound check

This revision was automatically updated to reflect the committed changes. Closed by commit R119:20bcc8f0501b: Do clamping in the model and add missing lower bound check (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10736?vs=27758&id