ngraham added a comment.

  In D11757#236015 <https://phabricator.kde.org/D11757#236015>, @richardbowen 
wrote:
  
  > The greyborder around the submenu heading isn't consistent with the other 
main menu heading which have no border, and inconsistent with the Kirigami back 
button style but otherwise, it looks good.
  
  
  Kirigami has multiple columnar navigation paradigms. The one whose visual 
style I'm emulating is the `ToolbarApplicationHeader`, which has gray 
toolbar-style backgrounds for the headers. System Settings previously had 
inconsistent approach: using the `ToolbarApplicationHeader` style for the main 
category list, but not the subcategory list. I think using the 
`ToolbarApplicationHeader` style for both looks better, and is a superior 
option to abandoning it for both, which presents issues for the header on the 
main category list given that it's always going to be scrollable.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D11757

To: ngraham, mart, #plasma, #vdg
Cc: davidedmundson, abetts, richardbowen, plasma-devel, ragreen, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

Reply via email to