D10992: Improve "Package removal" dialog wording

This revision was automatically updated to reflect the committed changes. Closed by commit R134:da6be2affd9d: Improve "Package removal" dialog wording (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10992?vs=28491&id=28535

D11009: Make passiveNotifications last longer, so users can actually read them

ngraham added inline comments. INLINE COMMENTS > PassiveNotification.qml:47 > if (timeout == "short") { > -timer.interval = 1000; > } else if (timeout == "long") { Not sure there was possibly a use case for a one-second textual notification. With this patch, the `s

D11009: Make passiveNotifications last longer, so users can actually read them

ngraham created this revision. ngraham added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now passiveNotifications last for 4.5 seconds by de

D11003: Fix the Add Source dialog

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11003 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11003: Fix the Add Source dialog

ngraham marked an inline comment as done. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11003 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11003: Fix the Add Source dialog

ngraham updated this revision to Diff 28533. ngraham added a comment. Use `onAccepted:` instead of manually intercepting the [Return] and [Enter] keys REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11003?vs=28523&id=28533 BRANCH fix-add-

D11003: Fix the Add Source dialog

ngraham added a comment. In D11003#217814 , @apol wrote: > Does it work to press Enter and Escape? Yep! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11003 To: ngraham, #discover_software_store

D10992: Improve "Package removal" dialog wording

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10992 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuter

D11003: Fix the Add Source dialog

apol added a comment. Does it work to press Enter and Escape? INLINE COMMENTS > AddSourceDialog.qml:62 > Layout.fillWidth: true > -Keys.onEnterPressed: newSourceDialog.accept() > +Keys.onReturnPressed: okButton.clicked() > +Keys.onEnterPressed:

D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false

kossebau added a dependent revision: D10972: [RFC] Exposing slideshow to MPRIS controllers. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11007 To: kossebau, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false

kossebau created this revision. kossebau added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Also disable "Stop" menu entry if there is nothing to stop (

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 59 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/59/ Project: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 04 Mar 2018 00:13:46 + Build duration: 2 min 52 sec and counting

D11003: Fix the Add Source dialog

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11003 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9 - Build # 31 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20FreeBSDQt5.9/31/ Project: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Mar 2018 23:43:08 + Build duration: 7 min 9 sec and counting JUnit Test

KDE CI: Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20kwindowsystem%20stable-kf5-qt5%20FreeBSDQt5.9/12/ Project: Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Mar 2018 23:43:10 + Build duration: 1 min 52 sec and counting

D11003: Fix the Add Source dialog

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11003 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11003: Fix the Add Source dialog

ngraham created this revision. ngraham added reviewers: Discover Software Store, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Fix a variety of bugs and usability issues w

D11003: Fix the Add Source dialog

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11003 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 58 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/58/ Project: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Mar 2018 20:56:46 + Build duration: 1 hr 5 min and counting JUnit Tes

KDE CI: Plasma kwayland kf5-qt5 FreeBSDQt5.9 - Build # 29 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20FreeBSDQt5.9/29/ Project: Plasma kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Mar 2018 20:56:01 + Build duration: 58 min and counting JUnit Tests Name: (root

KDE CI: Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/10/ Project: Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Mar 2018 20:55:58 + Build duration: 48 min and counting JUnit Tests Na

KDE CI: Plasma kwayland stable-kf5-qt5 SUSEQt5.9 - Build # 34 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20SUSEQt5.9/34/ Project: Plasma kwayland stable-kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 20:55:06 + Build duration: 17 min and counting JUnit Tests Nam

KDE CI: Plasma kwindowsystem stable-kf5-qt5 SUSEQt5.9 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20kwindowsystem%20stable-kf5-qt5%20SUSEQt5.9/16/ Project: Plasma kwindowsystem stable-kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 20:55:09 + Build duration: 15 min and counting JUnit Tests

KDE CI: Plasma kwindowsystem kf5-qt5 SUSEQt5.9 - Build # 49 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20kwindowsystem%20kf5-qt5%20SUSEQt5.9/49/ Project: Plasma kwindowsystem kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 20:55:08 + Build duration: 11 min and counting JUnit Tests Name: (r

KDE CI: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 - Build # 86 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20SUSEQt5.9/86/ Project: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 20:54:57 + Build duration: 10 min and counting JUnit

KDE CI: Plasma plasma-framework kf5-qt5 SUSEQt5.9 - Build # 223 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20SUSEQt5.9/223/ Project: Plasma plasma-framework kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 20:54:56 + Build duration: 10 min and counting JUnit Tests N

KDE CI: Plasma kwayland kf5-qt5 SUSEQt5.9 - Build # 90 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20SUSEQt5.9/90/ Project: Plasma kwayland kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 20:55:06 + Build duration: 7 min 47 sec and counting JUnit Tests Name: (root)

D10830: Disable SplitterProxy by default since it's broken

hpereiradacosta added a comment. In D10830#217600 , @aacid wrote: > Hmmm > > I just realized this is weird, so the splitter in the kate sidebar is exactly 1 pixel wide so as you mentioned it can be a bit hard to grab (specially if using

D10830: Disable SplitterProxy by default since it's broken

aacid planned changes to this revision. aacid added a comment. Hmmm I just realized this is weird, so the splitter in the kate sidebar is exactly 1 pixel wide so as you mentioned it can be a bit hard to grab (specially if using a touchpad) but the splitters in KMail and Konversation

D10830: Disable SplitterProxy by default since it's broken

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. ok, ship it, then. In case we get complains, we'll increase the splitter size a posteriori. REPOSITORY R31 Breeze BRANCH Plasma/5.12 REVISION DETAIL https://phab

D10992: Improve "Package removal" dialog wording

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10992 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterbe

D10992: Improve "Package removal" dialog wording

ngraham created this revision. ngraham added reviewers: Discover Software Store, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Improve the wording of the "package removal"

D10991: [mpris2 dataengine] Fix media key handling to match MediaPlayer2.Player

kossebau added a dependent revision: D10972: [RFC] Exposing slideshow to MPRIS controllers. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10991 To: kossebau, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mar

D10991: [mpris2 dataengine] Fix media key handling to match MediaPlayer2.Player

kossebau created this revision. kossebau added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY - first check CanControl property, as it overrules things -

KDE CI: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9 - Build # 30 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20FreeBSDQt5.9/30/ Project: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Mar 2018 10:36:00 + Build duration: 1 hr 13 min and counting CONSOLE OUT

KDE CI: Plasma kwayland kf5-qt5 FreeBSDQt5.9 - Build # 28 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20FreeBSDQt5.9/28/ Project: Plasma kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Mar 2018 10:35:35 + Build duration: 1 hr 12 min and counting CONSOLE OUTPUT [...

KDE CI: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 - Build # 85 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20SUSEQt5.9/85/ Project: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 11:35:30 + Build duration: 3 min 57 sec and counting

KDE CI: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 - Build # 84 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20SUSEQt5.9/84/ Project: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 09:51:28 + Build duration: 1 hr 44 min and counting C

KDE CI: Plasma plasma-framework kf5-qt5 SUSEQt5.9 - Build # 222 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20SUSEQt5.9/222/ Project: Plasma plasma-framework kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 11:09:30 + Build duration: 14 min and counting CONSOLE OUTPUT

KDE CI: Plasma kwindowsystem kf5-qt5 SUSEQt5.9 - Build # 48 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwindowsystem%20kf5-qt5%20SUSEQt5.9/48/ Project: Plasma kwindowsystem kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 11:05:37 + Build duration: 17 min and counting CONSOLE OUTPUT [...t

KDE CI: Plasma plasma-framework kf5-qt5 SUSEQt5.9 - Build # 221 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20SUSEQt5.9/221/ Project: Plasma plasma-framework kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 09:51:29 + Build duration: 1 hr 18 min and counting CONSOLE OUTPUT

KDE CI: Plasma kwindowsystem stable-kf5-qt5 SUSEQt5.9 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwindowsystem%20stable-kf5-qt5%20SUSEQt5.9/15/ Project: Plasma kwindowsystem stable-kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 09:51:12 + Build duration: 1 hr 15 min and counting CONSOLE

KDE CI: Plasma kwindowsystem kf5-qt5 SUSEQt5.9 - Build # 47 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwindowsystem%20kf5-qt5%20SUSEQt5.9/47/ Project: Plasma kwindowsystem kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 09:51:11 + Build duration: 1 hr 14 min and counting CONSOLE OUTPUT

KDE CI: Plasma kwayland stable-kf5-qt5 SUSEQt5.9 - Build # 33 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20SUSEQt5.9/33/ Project: Plasma kwayland stable-kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 09:51:06 + Build duration: 1 hr 13 min and counting CONSOLE OUTPUT

KDE CI: Plasma kwayland kf5-qt5 SUSEQt5.9 - Build # 89 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20SUSEQt5.9/89/ Project: Plasma kwayland kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 09:51:06 + Build duration: 1 hr 13 min and counting CONSOLE OUTPUT [...trunca

KDE CI: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 57 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/57/ Project: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Mar 2018 09:51:29 + Build duration: 56 min and counting CONSOLE OUTPUT

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 58 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/58/ Project: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Mar 2018 09:51:28 + Build duration: 54 min and counting

KDE CI: Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 9 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/9/ Project: Plasma kwindowsystem kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Mar 2018 09:51:12 + Build duration: 51 min and counting CONSOLE OUTPUT

KDE CI: Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwindowsystem%20stable-kf5-qt5%20FreeBSDQt5.9/11/ Project: Plasma kwindowsystem stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Mar 2018 09:51:12 + Build duration: 50 min and counting CONSOL

KDE CI: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9 - Build # 29 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwayland%20stable-kf5-qt5%20FreeBSDQt5.9/29/ Project: Plasma kwayland stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Mar 2018 09:51:06 + Build duration: 44 min and counting CONSOLE OUTPUT

KDE CI: Plasma kwayland kf5-qt5 FreeBSDQt5.9 - Build # 27 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20FreeBSDQt5.9/27/ Project: Plasma kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Mar 2018 09:51:06 + Build duration: 44 min and counting CONSOLE OUTPUT [...trunc

D10979: missing return statement in trash applet

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ee6ad6bd5a6c: missing return statement in trash applet (authored by mvourlakos). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10979?vs=28436&id=28461 REVI