ngraham created this revision. ngraham added reviewers: Discover Software Store, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision.
REVISION SUMMARY Fix a variety of bugs and usability issues with the Add Source dialog: - Make the close button actually close the dialog - Give the text field focus so you can immediately start typing - Make the return key push the Add button - Remove needless close symbol in top-right corner - Give the buttons icons BUG: 390148 TEST PLAN Tested with Flatpak backend: - Invalid URLs are rejected - Valid URLs that nonetheless don't point to a Flatpak repo trigger an error message - The close button now closes the dialog - The return key presses the Add button REPOSITORY R134 Discover Software Store BRANCH fix-add-source-dialog (branched from master) REVISION DETAIL https://phabricator.kde.org/D11003 AFFECTED FILES discover/qml/AddSourceDialog.qml To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart