KDE CI: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 - Build # 76 - Failure!

2018-02-25 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20SUSEQt5.9/76/ Project: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 Date of build: Sun, 25 Feb 2018 21:31:34 + Build duration: 9 hr 55 min and counting C

D10835: [kicker] Never execute recent documents

2018-02-25 Thread Алексей Шилин
aleksejshilin added a comment. In D10835#213787 , @broulik wrote: > Can you check whether this affects Task manager also? Task Manager runs the corresponding application explicitly by its .desktop file, so it's not affected. REPOSITORY

D10850: Rename wallpaper translation catalogs to follow pattern

2018-02-25 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY The wallpaper loading code expects the catalogs to follow the p

[Breeze] [Bug 343580] All look and feel, icons, theme are not configurable and all icons are gone

2018-02-25 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=343580 jarlgjess...@gmail.com changed: What|Removed |Added Status|NEEDSINFO |RESOLVED --- Comment #6 from jarlgjess.

[Breeze] [Bug 343580] All look and feel, icons, theme are not configurable and all icons are gone

2018-02-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=343580 Nate Graham changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|UNCONFIRMED

[Breeze] [Bug 352610] root apps use oxygen icons and widget style

2018-02-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=352610 Nate Graham changed: What|Removed |Added CC||n...@kde.org Status|UNCONFIRMED

D10802: Fix the userswitcher when using the mouse for switching

2018-02-25 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R120:1eb9ae7e33e2: Fix the userswitcher when using the mouse for switching (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10802?vs=27935&id

D9713: Add script to unlock a broken session via ConsoleKit.

2018-02-25 Thread Tobias C . Berner
tcberner added a comment. We could certainly do that by removing the wrapping `if ( NOT HAVE_LOGINCTL )`. Additionally, also the order of the if-branches in `abstractlocker.cpp` would probably need to be reordered as to prefere login1. REPOSITORY R133 KScreenLocker REVISION DETAIL ht

D9713: Add script to unlock a broken session via ConsoleKit.

2018-02-25 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > arfrever wrote in CMakeLists.txt:97 > I would suggest that this build-time detection of ConsoleKit occur always, > and as a result, that ck-unlock-session be always installed if ConsoleKit is > installed. > For example, I have both loginctl and

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

2018-02-25 Thread Martin Flöser
graesslin added a comment. In D10816#213801 , @broulik wrote: > Also I think all of this will become obsolete with Qt 5.11 where it supports multiple platform plugins as a fallback chain: https://codereview.qt-project.org/#/c/220294/ Yes

D10800: Plasma browser MPRIS canPlay shouldn't depend on the actual playing status

2018-02-25 Thread Matthijs Tijink
This revision was automatically updated to reflect the committed changes. Closed by commit R856:48a2e78b2afb: Plasma browser MPRIS canPlay shouldn't depend on the actual playing status (authored by mtijink). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabric

D9713: Add script to unlock a broken session via ConsoleKit.

2018-02-25 Thread Arfrever Frehtes Taifersar Arahesis
arfrever added inline comments. INLINE COMMENTS > CMakeLists.txt:97 > +if ( NOT HAVE_LOGINCTL ) > +find_package(ConsoleKit) > +set_package_properties(ConsoleKit PROPERTIES I would suggest that this build-time detection of ConsoleKit occur always, and as a result, that ck-unlock-session

D10838: [joystick kcm] Fix translation catalog name to follow patterns

2018-02-25 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH improvekcmjoystickcatalogname REVISION

D9414: Implement OSD to select action when unknown monitors is connected

2018-02-25 Thread Andrew Crouthamel
acrouthamel added a comment. Could this be implemented for bug 390096 ? Having the display button open this OSD would be an improvement over the current operation, in my opinion. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde

D10837: bad textarea width for rename file if filename too short

2018-02-25 Thread Painless Roaster
painlessroaster added a comment. new patch with correct rtl support REVISION DETAIL https://phabricator.kde.org/D10837 To: painlessroaster, #plasma Cc: plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10837: bad textarea width for rename file if filename too short

2018-02-25 Thread Painless Roaster
painlessroaster added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION DETAIL https://phabricator.kde.org/D10837 To: painlessroaster, #plasma Cc: plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-moh

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

2018-02-25 Thread Kai Uwe Broulik
broulik added a comment. Also I think all of this will become obsolete with Qt 5.11 where it supports multiple platform plugins as a fallback chain: https://codereview.qt-project.org/#/c/220294/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10816 To: gra

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

2018-02-25 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > kworkspace.h:161 > +* > +* This function must be invoked before the QGuiApplication instance is > constructed. > +* @since 5.13 Can you `assert` this? > kworkspace.h:164 > +**/ > + KWORKSPACE_EXPORT void platformDetection(int a

D10802: Fix the userswitcher when using the mouse for switching

2018-02-25 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10802 To: fvogt, #plasma, broulik Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10800: Plasma browser MPRIS canPlay shouldn't depend on the actual playing status

2018-02-25 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Makes sense. Thanks! REPOSITORY R856 Plasma Browser Integration BRANCH fix-mpris-canplaypause REVISION DETAIL https://phabricator.kde.org/D10800 To: mtijink, #plasma, broulik Cc:

D10835: [kicker] Never execute recent documents

2018-02-25 Thread Kai Uwe Broulik
broulik added a comment. Can you check whether this affects Task manager also? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10835 To: aleksejshilin, #plasma Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, m

D10836: Ensure _NET_CURRENT_DESKTOP is set on startup

2018-02-25 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REV

[Breeze] [Bug 350684] lock window when switching between users is very hard to use

2018-02-25 Thread Dirk Heinrichs
https://bugs.kde.org/show_bug.cgi?id=350684 Dirk Heinrichs changed: What|Removed |Added CC|dirk.heinri...@altum.de | --- Comment #3 from Dirk Heinrichs --- Well,

D10835: [kicker] Never execute recent documents

2018-02-25 Thread Алексей Шилин
aleksejshilin created this revision. aleksejshilin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aleksejshilin requested review of this revision. REVISION SUMMARY When one tried to open a recent document which h

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-25 Thread Michael Heidelbach
michaelh added a comment. In D10807#213250 , @rkflx wrote: > What about users who manually create and mount FUSE-type encrypted directories? Plasma Vault is just a nice interface for this workflow, after all. Good point. > A more gen

[Breeze] [Bug 352610] root apps use oxygen icons and widget style

2018-02-25 Thread Edmund Kasprzak
https://bugs.kde.org/show_bug.cgi?id=352610 Edmund Kasprzak changed: What|Removed |Added CC||edk...@gmail.com --- Comment #4 from Edmund K

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

2018-02-25 Thread Roman Gilg
romangg added a task: T8077: Do not set QT_QPA_PLATFORM to wayland at session startup. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10816 To: graesslin, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Breeze] [Bug 350684] lock window when switching between users is very hard to use

2018-02-25 Thread Edmund Kasprzak
https://bugs.kde.org/show_bug.cgi?id=350684 Edmund Kasprzak changed: What|Removed |Added CC||edk...@gmail.com --- Comment #2 from Edmund K

D10440: Support modifier mouse/scroll action on internal decorated windows

2018-02-25 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In D10440#213112 , @romangg wrote: > Looks fine, but making this behavior dependent on `isDecorated` seems a bit hacky to me. Wouldn't be a separate pr

D10549: Don't crash if the cursor theme fails to create

2018-02-25 Thread Martin Flöser
graesslin added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > romangg wrote in wayland_cursor_theme.cpp:69 > Can we check differently if it is the same theme? Or should we in any case > emit themeChanged when we are at this point already?

[Breeze] [Bug 343580] All look and feel, icons, theme are not configurable and all icons are gone

2018-02-25 Thread Edmund Kasprzak
https://bugs.kde.org/show_bug.cgi?id=343580 Edmund Kasprzak changed: What|Removed |Added CC||edk...@gmail.com --- Comment #4 from Edmund K

D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed

2018-02-25 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R127:2dfe16d774c7: [server] Properly handle the situation when the DataSource for a drag gets… (authored by graesslin). Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOS

D10308: Send hoverLeave or hoverMotion after touch up on decoration

2018-02-25 Thread Martin Flöser
This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was automatically updated to reflect the committed changes. Closed by commit R108:911176a887be: Send hoverLeave or hoverMotion after touch up on decoration (authored by graesslin). Restricted Applic

D10490: Add a method to dbus interface to query information about a window

2018-02-25 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:1d71292e13fc: Add a method to dbus interface to query information about a window (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHA

D10294: Init the icon in ShellClient::init

2018-02-25 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:5795fc8cc04a: Init the icon in ShellClient::init (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https:/

D10308: Send hoverLeave or hoverMotion after touch up on decoration

2018-02-25 Thread Martin Flöser
graesslin planned changes to this revision. graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. I need to rework the patch, it broke with 338c7362c9fbb37f1fb8beb9a50644b585d8135e

D10291: Add a recursion blocker in Pointer/TouchInputRedirection::update

2018-02-25 Thread Roman Gilg
romangg added a comment. Restricted Application edited projects, added KWin; removed Plasma. Note that it gave me some error, when I tried to compile this branch. `UpdateRecursionBlocker` has a generic name, but it is dependent on receiving as `T` one of the input classes with `input` as

D10830: Disable SplitterProxy by default since it's broken

2018-02-25 Thread Albert Astals Cid
aacid created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY BUGS: 389837 REPOSITORY R31 Breeze BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.o

D9713: Add script to unlock a broken session via ConsoleKit.

2018-02-25 Thread Tobias C . Berner
This revision was automatically updated to reflect the committed changes. tcberner marked an inline comment as done. Closed by commit R133:68fb0b7d3e1c: Add script to unlock a broken session via ConsoleKit. (authored by tcberner). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https

D10308: Send hoverLeave or hoverMotion after touch up on decoration

2018-02-25 Thread Roman Gilg
Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH hover-leave-on-deco-after-touch-5.12 REVISION DETAIL https://phabricator.kde.org/D10308 To: graesslin, #kwin, #plasma, ngraham, romangg Cc: plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed,

D10291: Add a recursion blocker in Pointer/TouchInputRedirection::update

2018-02-25 Thread Roman Gilg
Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10291 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, iodelay, bwowk, hard

D10549: Don't crash if the cursor theme fails to create

2018-02-25 Thread Roman Gilg
Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10549 To: graesslin, #kwin, #plasma, davidedmundson, romangg Cc: romangg, plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D10235: [server] Add support for the frame semantics of Pointer version 5

2018-02-25 Thread Roman Gilg
Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland BRANCH server-pointer-frame-semantics REVISION DETAIL https://phabricator.kde.org/D10235 To: graesslin, #kwin, #plasma, #frameworks, romangg Cc: romangg, plasma-devel, schernikov, mic

D10235: [server] Add support for the frame semantics of Pointer version 5

2018-02-25 Thread Roman Gilg
romangg edited projects, added Plasma on Wayland; removed Plasma. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland BRANCH server-pointer-frame-semantics REVISION DETAIL https://phabricator.kde.org/D10235 To: graesslin, #kwin, #plasm

D10235: [server] Add support for the frame semantics of Pointer version 5

2018-02-25 Thread Roman Gilg
romangg accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland BRANCH server-pointer-frame-semantics REVISION DETAIL https://phabricator.kde.org/D10235 To: graesslin

D10549: Don't crash if the cursor theme fails to create

2018-02-25 Thread Roman Gilg
romangg added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > graesslin wrote in wayland_cursor_theme.cpp:69 > As it returns a pointer it is impossible that we get the same pointer back. Can we check differently if it is the same theme? Or s

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

2018-02-25 Thread Martin Flöser
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY This is a preparation step to unset QT_QPA_PLATFORM from the

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-25 Thread Henrik Fehlauer
rkflx added a comment. What about users who manually create and mount FUSE-type encrypted directories? Plasma Vault is just a nice interface for this workflow, after all. A more general approach would be to look at the filesystem type in `mount` (do we have an API for that?). I'd imagine

D10549: Don't crash if the cursor theme fails to create

2018-02-25 Thread Martin Flöser
graesslin added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > romangg wrote in wayland_cursor_theme.cpp:69 > Only do if theme really changes (`theme && m_theme != theme`). As it returns a pointer it is impossible that we get the same point

D10235: [server] Add support for the frame semantics of Pointer version 5

2018-02-25 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. In D10235#213009 , @romangg wrote: > Shouldn't the sendFrame event sent by the compositor explicitly? The way it's currently send after ea