romangg added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Note that it gave me some error, when I tried to compile this branch.
  
  `UpdateRecursionBlocker` has a generic name, but it is dependent on receiving 
as `T` one of the input classes with `input` as an instance and having a member 
function `update`. I would make it fully generic by adding a std::function type 
argument to the constructer (that in our current application encapsulates 
`input->update()`) and that gets called in the destructor just like it is now. 
The template parameter `T` would then be the template argument of the 
std::function argument and m_input would be replaced by a member variable 
`m_fct` storing the std::function
  
  The class does not directly block recursions, but delays additional calls to 
the end of the first call (and then does the call only once). Therefore I would 
name it differently. Something like `BlockAndDelayCallsToOne`?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10291

To: graesslin, #kwin, #plasma
Cc: romangg, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

Reply via email to