Re: Closing old Plasma 4 bugs

Hi all, I've now put together the necessary changes and have deployed them on the Bugzilla Testbed, at bugstest.kde.org. If people could please login and verify things are working correctly for them still that would be appreciated. I've given anyone with editbugs membership currently membership o

D10622: Add multimedia sub-categories

ngraham updated this revision to Diff 27441. ngraham added a comment. Fix category icons (even though they're not currently displayed; maybe they will be, someday) REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10622?vs=27440&id=27441 BRAN

D10622: Add multimedia sub-categories

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10622 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10622: Add multimedia sub-categories

ngraham created this revision. ngraham added reviewers: Discover Software Store, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY FEATURE: 388933 TEST PLAN Tested in KDE N

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 158 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/158/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 18 Feb 2018 04:02:09 + Build duration: 12 min and counting JUnit Tests

D10620: Improve sidebar header visibility

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, s

D10620: Improve sidebar header visibility

ngraham created this revision. ngraham added reviewers: Plasma, Kirigami, mart. Restricted Application added projects: Plasma, Kirigami. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 384638 FIXED-IN: KDE Plasma 5.12.2

D10618: Fix ComboBox & mode description for image fill mode

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. 1 minor fix. Make sure you don't change the Arabic translations when pushing. INLINE COMMENTS > ConfigPaths.qml:161 > > -Label { > +

D10618: Fix ComboBox & mode description for image fill mode

sharvey added reviewers: Plasma, mart, davidedmundson. sharvey added a comment. My first bugfix. Un-mangled the ConfigGeneral.qml file for the stock Media Frame plasmoid, based on bug 390571. Hope I chose the right reviewers. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabrica

D10618: Fix ComboBox & mode description for image fill mode

sharvey created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY BUG: 390571 Reworked ConfigGeneral.qml to properly display ComboBox for image fill modes, alo

D10610: Fix favicons in firefox bookmarks runner

z3ntu marked 2 inline comments as done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10610 To: z3ntu, #plasma, broulik Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10610: Fix favicons in firefox bookmarks runner

z3ntu marked an inline comment as done. z3ntu added a comment. Thanks :) > Presumably this means it'll break on < Firefox 58? It should work FF37+ where they switched to the new database schema. > It's weird that it crashes on a table missing. Is that a Qt bug we can file? I

D10610: Fix favicons in firefox bookmarks runner

z3ntu updated this revision to Diff 27421. z3ntu added a comment. - Add m_fetchsqlite_fav to teardown REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10610?vs=27415&id=27421 BRANCH D10610 REVISION DETAIL https://phabricator.kde.org/D10610 AFF

D10079: [Draft] Port baloo krunner plugin to KDBusRunner

kossebau added inline comments. INLINE COMMENTS > michaelh wrote in baloosearchrunner.cpp:103 > Baloo can also handle these types > > - Archive > - Spreadsheet (also found with type:Document) > - Presentation (also found with type:Document) > > see basicindexingjob >

D10610: Fix favicons in firefox bookmarks runner

davidedmundson added a comment. > Firefox bookmark favicons now work and don't crash Krunner and Kickoff Oh, that's fantastic news. Thank you so much! Presumably this means it'll break on < Firefox 58? As long as it just fails to load and doesn't crash, that's probably fine.

D10610: Fix favicons in firefox bookmarks runner

anthonyfieroni added reviewers: Plasma, broulik. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10610 To: z3ntu, #plasma, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10613: Make it possible for actions to show submenus

apol created this revision. apol added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY When using the ToolBarApplicationHeader we don't show the submenu, whic

D10079: [Draft] Port baloo krunner plugin to KDBusRunner

michaelh added inline comments. INLINE COMMENTS > baloosearchrunner.cpp:103 > +matchInternal(m_searchTerm, QStringLiteral("Video"), i18n("Video")); > +matchInternal(m_searchTerm, QStringLiteral("Folder"), i18n("Folder")); > +finishMatching(); Baloo can also handle these types - Arch

D10605: Fix location of Firefox dbCacheFile

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R120 Plasma Workspace BRANCH D10605 REVISION DETAIL https://phabricator.kde.org/D10605 To: z3ntu, mlaurent Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali

D10610: Fix favicons in firefox bookmarks runner

z3ntu updated this revision to Diff 27415. z3ntu added a comment. Do the same change as in D10605 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10610?vs=27409&id=27415 BRANCH D10610 REVISION DETAIL https:

D10605: Fix location of Firefox dbCacheFile

z3ntu marked an inline comment as done. z3ntu added a comment. @mlaurent Updated the patch. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10605 To: z3ntu, mlaurent Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D10605: Fix location of Firefox dbCacheFile

z3ntu updated this revision to Diff 27414. z3ntu added a comment. Put slash directly into the QStringLiteral REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10605?vs=27403&id=27414 BRANCH D10605 REVISION DETAIL https://phabricator.kde.org/D106

D10605: Fix location of Firefox dbCacheFile

mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. Otherwise patch is correct. INLINE COMMENTS > firefox.cpp:58 > if (m_dbCacheFile.isEmpty()) { > -m_dbCacheFile = > QStandardPaths::writableLocation(QStandardPath

D10611: Put all systemwide add-ons in Plasma Addons category

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:4959871c57d7: Put all systemwide add-ons in Plasma Addons category (authored by ngraham). REPOSITORY R134 Discover S

D10611: Put all systemwide add-ons in Plasma Addons category

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10611 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10606: Show all add-ons in a single category to improve discoverability and search performance

ngraham abandoned this revision. ngraham added a comment. Closing in favor of D10611: Put all systemwide add-ons in Plasma Addons category , which makes more sense. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10

D10611: Put all systemwide add-ons in Plasma Addons category

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10611 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10611: Put all systemwide add-ons in Plasma Addons category

ngraham created this revision. ngraham added reviewers: Discover Software Store, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 390594 TEST PLAN Application Addons

D10610: Fix favicons in firefox bookmarks runner

z3ntu added a comment. Two more notes: The logic for the path of the cache file (bookmarkrunnerfirefoxfavdbfile.sqlite) is like in D10605 . If this patch doesn't get merged into the next Plasma bugfix release, then `QList faviconFound = m_fetchsqlit

D10610: Fix favicons in firefox bookmarks runner

z3ntu created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. z3ntu requested review of this revision. REVISION SUMMARY The favicons are located in the file favicons.sqlite file since FF 37 and the old table was removed in

D10610: Fix favicons in firefox bookmarks runner

z3ntu edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10610 To: z3ntu Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10485: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version

kossebau added a comment. Could not reproduce that error locally, and build.kde.org had also not reported any problems. But given it failed for at least two people and the neon CI (https://build.neon.kde.org/job/xenial_unstable_plasma_plasma-desktop_bin_amd64/528/consoleFull) there might be

D10607: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version, v2

kossebau created this revision. kossebau added reviewers: FreeBSD, tcberner, bshah, mart, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Also improves race condi

D10606: Show all add-ons in a single category to improve discoverability and search performance

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10606 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterbe

D10606: Show all add-ons in a single category to improve discoverability and search performance

ngraham created this revision. ngraham added reviewers: Discover Software Store, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 390594 Right now the Add-ons are s

D10604: Show the text by the page action tool buttons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. A clear improvement IMHO: F5715593: After.png REPOSITORY R169 Kirigami BRANCH showText REVISION DETAIL https://phabricator.kde.org/D1060

D10605: Fix location of Firefox dbCacheFile

z3ntu added a comment. I researched a bit more. The commit af0a29a185f190088af4a3a9d0d5bfb28a8feae3 caused this behaviour. A small test app results in: > Before: "/home/luca/.cache/bookmarkrunnerfirefoxdbfile.sql

D10605: Fix location of Firefox dbCacheFile

z3ntu created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. z3ntu requested review of this revision. REVISION SUMMARY Before: ~/.cache/krunnerbookmarkrunnerfirefoxdbfile.sqlite After: ~/.cache/krunner/bookmarkrunnerfiref

gtk3 integration?

Hi, I recently came across something called qt-gtk-engine (a bit of LXDE abandonware) which reminded me that I never found a satisfactory way to integrate GTk3 apps with my preferred look and feel, esp. not with more recent GTk3 versions. Oxygen-gtk3 comes closest but that project hasn't seen a

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 157 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/157/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 17 Feb 2018 11:45:51 + Build duration: 4 min 36 sec and counting CONSOLE OUT

D10604: Show the text by the page action tool buttons

apol created this revision. apol added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY An icon is not necessarily enough REPOSITORY R169 Kirigami BRANCH

D10485: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version

bshah added a comment. Unfortunately we will have to revert this it seems, CMakeFiles/kcm_lookandfeel.dir/kcm.cpp.o: In function `KCMLookandFeelFactory::KCMLookandFeelFactory()': kcm.cpp:(.text+0x2b): undefined reference to `vtable for KCMLookandFeelFactory'

D10584: fix double spacing bug

This revision was automatically updated to reflect the committed changes. Closed by commit R31:0371463b4a6f: fix double spacing bug (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10584?vs=27367&id=27391 REVISION DETAIL https://phabricator.k

D10584: fix double spacing bug

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Ship it ! Thanks for this patch, and sorry for the mess on the Blur patch (should have used arc). REPOSITORY R31 Breeze BRANCH double-space-bug REVISION DETAIL