D9225: Fix building autotest on platforms where syscalls are not available

davidk added a comment. Just adding my 2 cent: I think the filter should work fine, as SCMP_SYS is explicit available to support different platforms. If the syscall isn't available, it uses negative pseudo syscall numbers to ignore those syscalls. REPOSITORY R133 KScreenLocker REVISION DE

D9673: Guard against syscalls not available on some platforms

davidk abandoned this revision. davidk added a comment. In https://phabricator.kde.org/D9673#186294, @bshah wrote: > Uh, sorry I forgot to mention in orignial PR: but https://phabricator.kde.org/D9225 Ok, no problem. I'll close this one. REPOSITORY R133 KScreenLocker REVISION

D9673: Guard against syscalls not available on some platforms

bshah added a comment. Uh, sorry I forgot to mention in orignial PR: but https://phabricator.kde.org/D9225 REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D9673 To: davidk, bshah, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreut

D9673: Guard against syscalls not available on some platforms

davidk added reviewers: bshah, graesslin. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D9673 To: davidk, bshah, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8756: Forbid more syscalls which could modify the filesystem

davidk added a comment. In https://phabricator.kde.org/D8756#186280, @davidk wrote: > I'm not sure what happens here as well. I guess that arm64 doesn't implement many syscalls. I will prepare a patch to exclude those syscalls if they're not available. Here it is: https://phabric

D8756: Forbid more syscalls which could modify the filesystem

davidk added a comment. In https://phabricator.kde.org/D8756#176550, @bshah wrote: > Hello, > > It seems this commit doesn't seem to build on arm64 properly: https://build.neon.kde.org/job/xenial_unstable_plasma_kscreenlocker_bin_arm64/1/console > > I don't exactly understand what

Re: detecting tablet mode

I want to provide a dbus service in KWin to export the state. Apps cannot use libinput directly, one needs root for that. Cheers Martin Am 4. Januar 2018 23:22:43 MEZ schrieb Marco Martin : >Hi all, >one thing i wanted to look into, is to detect when a trasformable >laptop goes >in tablet mode

D8529: Plasma change icons should exit after its work finished.

xuetianweng added a comment. In https://phabricator.kde.org/D8529#186000, @broulik wrote: > Good to go, no? I have no problem with that. Any one have extra comment? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8529 To: xuetianweng, apol, mart,

D9201: Slightly reduce vertical gutter width.

Zren updated this revision to Diff 24677. Zren edited the summary of this revision. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9201?vs=23791&id=24677 REVISION DETAIL https://phabricator.kde.org/D9201 AFFECTED FILES containments/desktop/package/

D9201: Slightly reduce vertical gutter width.

Zren commandeered this revision. Zren added a reviewer: hein. Zren added a comment. Oh I see, "Commandeer revision" is in the "Add action..." dropdown, not the sidebar. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9201 To: Zren, #plasma, hein Cc: ngraham,

detecting tablet mode

Hi all, one thing i wanted to look into, is to detect when a trasformable laptop goes in tablet mode from applications, so that plasmashell and kirigami apps can adapt themselves and do things(tm) KWin does that (on wayland) already, and i see it uses libinput for that, like i seem to evince fro

D9201: Slightly reduce vertical gutter width.

hein added a comment. I think you have to use "Commandeer revision" and then you can upload a different diff here. Or maybe I should abandon and you refile? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9201 To: hein, #plasma Cc: ngraham, abetts, Zren, plas

D9601: Make media controls configurable

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm.cpp:136 > This won't work. > > Kpacakges don't inherit metadata, so I think if you changed to breeze-dark > you'd get the controls but lose the ability to turn them off. > You can't assume that authors should copy me

D9661: [TabBox] Don't show "Show desktop" window when cycling through application windows

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9661#186122, @broulik wrote: > Right, the enum names were confusing. I was young ;-) REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org

D9601: Make media controls configurable

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I think the change is needed and makes sense. There's a logic bug though. INLINE COMMENTS > kcm.cpp:136 > +if (md.isValid()) { > +const QS

D9631: [DBusMenuImporter] Send "opened" signal alongside about to show

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9631 To: broulik, #plasma, davidedmundson, fvogt Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D9635: [AppMenuModel] Monitor window properties

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9635 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D9655: [Kickoff] Hide tab bar if only one tab button is configured

broulik added a comment. That's what I originally had but didn't work REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9655 To: broulik, #plasma, #vdg, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D9642: [User Switcher] Workaround Connections {} not working on "plasmoid"

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I'd like to see a link to an upstream Qt bug report in the comment REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9642 To: broulik, #plasma,

D9655: [Kickoff] Hide tab bar if only one tab button is configured

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Could we use tabBar.layout.children.length directly in the state instead of a new property? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D

D9660: Add explicit protocol for colour scheme management

This revision was automatically updated to reflect the committed changes. Closed by commit R108:01d6878dc2d3: Add explicit protocol for colour scheme management (authored by davidedmundson). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES SINCE

D9661: [TabBox] Don't show "Show desktop" window when cycling through application windows

broulik planned changes to this revision. broulik added a comment. Restricted Application edited projects, added Plasma; removed KWin. Right, the enum names were confusing. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9661 To: broulik, #plasma, #vdg Cc: graesslin, pl

D9661: [TabBox] Don't show "Show desktop" window when cycling through application windows

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9661#186102, @broulik wrote: > From what I and Nate understood it makes no sense to have the Desktop window in a list of windows from the same application which t

D9478: Drop use of qtpaths in startkde

davidedmundson marked an inline comment as done. davidedmundson added inline comments. INLINE COMMENTS > apol wrote in startplasmacompositor.cmake:174 > Why is `|| true` needed now? it's syncing startkde with the wayland one. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabric

D9661: [TabBox] Don't show "Show desktop" window when cycling through application windows

broulik added a comment. Restricted Application edited projects, added Plasma; removed KWin. From what I and Nate understood it makes no sense to have the Desktop window in a list of windows from the same application which this patch addresses REPOSITORY R108 KWin REVISION DETAIL https:/

D9660: Add explicit protocol for colour scheme management

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D9660 To: davidedmundson, #plasma, graesslin Cc: plasma-dev

D9661: [TabBox] Don't show "Show desktop" window when cycling through application windows

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. I'm not sure whether you understood the feature request correctly. I understood it as for the application mode it should not be changed, but for the AllWindowsCurrentApplication the show desktop sho

D9661: [TabBox] Don't show "Show desktop" window when cycling through application windows

broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. Restricted Application edited projects, added Plasma; removed KWin. REVISION SUMMARY When I'm explicitly cycling

[Breeze] [Bug 340137] Implement support for window groups (window tabs) in Breeze

https://bugs.kde.org/show_bug.cgi?id=340137 Christoph Feck changed: What|Removed |Added Resolution|DUPLICATE |--- Status|RESOLVED

[Breeze] [Bug 340137] Implement support for window groups (window tabs) in Breeze

https://bugs.kde.org/show_bug.cgi?id=340137 Kai Uwe Broulik changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REOPENED

D9478: Drop use of qtpaths in startkde

apol added a comment. Other than that, it looks good to me. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9478 To: davidedmundson, #plasma Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D9478: Drop use of qtpaths in startkde

apol added inline comments. INLINE COMMENTS > startplasmacompositor.cmake:174 > + for file in "$prefix"/plasma-workspace/env/*.sh; do > +test -r "$file" && . "$file" || true >done Why is `|| true` needed now? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde

D9516: [libinput] Add support for switch devices and events

This revision was automatically updated to reflect the committed changes. Closed by commit R108:ac2f41c86d3b: [libinput] Add support for switch devices and events (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin CHANGES SINCE LAS

D9660: Add explicit protocol for colour scheme management

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. Restricted Application edited projects, added Plasma; removed KWin. REVISION SUMMARY To replace the dep

D9656: Fix naming inconsistency

This revision was automatically updated to reflect the committed changes. Closed by commit R127:8826e890dd44: Fix naming inconsistency (authored by davidedmundson). Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDA

D9656: Fix naming inconsistency

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D9656 To: davidedmundson, #plasma, graessl

D2314: Context Menu to Mute, Set Default Sink/Source, Active Port

broulik added a comment. This is obsolete now? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2314 To: Zren, #plasma:_design, #plasma Cc: broulik, davidedmundson, drosca, colomar, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreu

D8529: Plasma change icons should exit after its work finished.

broulik added a comment. Good to go, no? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8529 To: xuetianweng, apol, mart, #plasma Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7155: Implement sorting of the device tree items

broulik accepted this revision. broulik added a comment. Working well, thanks and sorry it took so long. Do you have commit access? You perhaps need to rebase the patch since in the meantime the code was modernized and your patch doesn't cleanly apply anymore. I can take care of this if you

D7481: RFC: Batch window changes events on XCB

broulik added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7481 To: davidedmundson, #plasma Cc: ngraham, cfeck, broulik, hein, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mar

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

broulik added a comment. Ping INLINE COMMENTS > kcmqtquicksettingswidget.ui:21 > + > + > + Not fond of abusing `KMessageWidget` for something that isn't action-feedback but this KCM doesn't need to be pretty anyway. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://ph

D8626: DDCUtil: Improved DDCUtil support for brightness control

broulik added a comment. Looking fine, cannot really comment, though. Without context makes it hard to review. INLINE COMMENTS > ddcutilbrightness.cpp:26 > { > +QVector m_usedVcp = {0x10}; > m_setBrightnessEventFilter.setInterval(100); Use initializer: DDCutilBrightness::DDCUti

D8673: Sanitize signal handling in ksmserver

broulik added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8673 To: jpalecek, #plasma Cc: broulik, graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9037: use desktop file actions instead of global shortcuts

broulik added a comment. Did you find the cause for the input lag? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9037 To: mart, #plasma Cc: broulik, apol, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, s

D9286: don't multiply svg sizes by devicepixelratio

broulik added a comment. This fixes the gigantig scroll bars I had in plasmashell on X with 2x scaling. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9286 To: mart, #plasma Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D9555: Simulate user activity on fake input events

broulik added a comment. Restricted Application edited projects, added KWin; removed Plasma. We have a final decision now, 5.12 being delayed. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9555 To: graesslin, #kwin, #plasma Cc: broulik, davidedmundson, plasma-devel, k

D9353: Fix the user switcher not updating open sessions

broulik added a comment. Oh, I'm so sorry, I missed your patch, and actually did a patch of my own. Just remove the `console.log` and your patch is good to go! Do you have commit access? INLINE COMMENTS > main.qml:244 > +if (expanded) { > +console.log("r

D9575: Only send low peripheral battery notification when in discharging state

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R122 Powerdevil BRANCH master REVISION DETAIL https://phabricator.kde.org/D9575 To: drosca, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D9391: [effects] Add 'Fullscreen' effect

zzag updated this revision to Diff 24718. zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. Updating https://phabricator.kde.org/D9391: [effects] Add 'Fullscreen' effect I think this should be rewritten in C++ for several reasons: - we need to c

D9656: Fix naming inconsistency

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

D9478: Drop use of qtpaths in startkde

davidedmundson updated this revision to Diff 24712. davidedmundson added a comment. Update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9478?vs=24293&id=24712 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9478 AFFECTED FILES

D9650: [Folder View] Add extra padding around icons also for applet

broulik abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9650 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9627: Reduce menu shadows to 25% of the window shadow size

rkflx added a comment. In https://phabricator.kde.org/D9627#185604, @rkflx wrote: > One more thing: Is the 100px max working for you? Mine is still capped at 64px Figured that one out: The problem is clearly with https://phabricator.kde.org/D9549, because it only changed `breeze

D9638: [effects] add 'Slide Desktops' effect

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Memory allocations in `SlideDesktopsEffect::paintScreen()` creep me out. We should not allocate memory during paint calls! If you have any ideas how to solve this, please let me know. Currently, I'm thin

D9637: Add jump list action for "Updates"

This revision was automatically updated to reflect the committed changes. Closed by commit R134:92d656cd56b3: Add jump list action for "Updates" (authored by broulik). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9637?vs=24663&id=24702 REVIS

D9637: Add jump list action for "Updates"

apol accepted this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9637 To: broulik, #plasma, apol, #vdg, abetts Cc: abetts, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

zzag added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > zzag wrote in slidedesktops.h:60 > Yeah, I know `slots`/`Q_SLOTS` keyword is optional with Qt 5, but I would > like to keep it to avoid some misunderstandings(e.g. "who the hell call

D9638: [effects] add 'Slide Desktops' effect

zzag updated this revision to Diff 24699. zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Updating https://phabricator.kde.org/D9638: [effects] add 'Slide Desktops' effect Squash commits. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https:

D9638: [effects] add 'Slide Desktops' effect

zzag marked 6 inline comments as done. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma Cc: graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai

D9638: [effects] add 'Slide Desktops' effect

zzag updated this revision to Diff 24698. zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Updating https://phabricator.kde.org/D9638: [effects] add 'Slide Desktops' effect Use QVector instead of QList, replace Q_FOREACH with range-based for loops.

D9638: [effects] add 'Slide Desktops' effect

zzag added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > graesslin wrote in slidedesktops.h:60 > As you use modern connect syntax you don't need the Q_SLOTS keyword anymore. Yeah, I know `slots`/`Q_SLOTS` keyword is optional with Qt 5, but

D9627: Reduce menu shadows to 25% of the window shadow size

hpereiradacosta added a comment. In https://phabricator.kde.org/D9627#185783, @ngraham wrote: > I'm working on the combobox patch, but in my KDE Neon machine, I'm having trouble getting my changes applied when I open the Breeze settings in the Window Decoration KCM. I'm building to /usr

D9516: [libinput] Add support for switch devices and events

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. Code looks good to me. At the moment there is nothing to test anyway, right? FYI Martin if you want to build libinpu

D9474: [Kickoff / Kicker] Move "Add to favorites" entry to the bottom of the context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R119:55eabda75ae6: [Kickoff / Kicker] Move "Add to favorites" entry to the bottom of the context… (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde

D9641: [Digital Clock] Add tooltip for agenda items with too long description

This revision was automatically updated to reflect the committed changes. Closed by commit R120:59ba8b8f4c5f: [Digital Clock] Add tooltip for agenda items with too long description (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D