romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.


  Code looks good to me. At the moment there is nothing to test anyway, right?
  
  FYI Martin if you want to build libinput in the future on Neon, then you need 
besides the stuff linked by @ngraham the GNOME Staging PPA 
<https://launchpad.net/~gnome3-team/+archive/ubuntu/gnome3-staging> since there 
is a GTK3 dependency. I was also able some time ago to disable building lbinput 
with its debug console (which needs the GTK3 stuff) so I didn't need the PPA, 
but with the current meson version I wasn't able to, so I got the PPA and added 
the following file to `etc/apt/preferences.d/gnome3-team-gnome3-staging` (then 
it only updates the listed four packages from the PPA):
  
    Package: *
    Pin: release o=LP-PPA-gnome3-team-gnome3-staging
    Pin-Priority: -1
    
    Package: libgtk-3-dev
    Pin: release o=LP-PPA-gnome3-team-gnome3-staging
    Pin-Priority: 500
    
    Package: libgtk-3-common
    Pin: release o=LP-PPA-gnome3-team-gnome3-staging
    Pin-Priority: 500
    
    Package: libgtk-3-0
    Pin: release o=LP-PPA-gnome3-team-gnome3-staging
    Pin-Priority: 500
    
    Package: gir1.2-gtk-3.0
    Pin: release o=LP-PPA-gnome3-team-gnome3-staging
    Pin-Priority: 500

REPOSITORY
  R108 KWin

BRANCH
  libinput-switch

REVISION DETAIL
  https://phabricator.kde.org/D9516

To: graesslin, #kwin, #plasma, romangg
Cc: romangg, ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to