D9207: Don't load KDE platform module in kglobalaccel5

2017-12-11 Thread Eike Hein
hein removed subscribers: apol, graesslin. hein added a reviewer: graesslin. hein added a comment. I consider this patch in some sense a micro-optimization. I think given our time in the release cycle it'd be OK to apply and essentially see what if anything breaks. However I also won't feel b

Plasmoid debugging

2017-12-11 Thread Mark Constable
I hope it's okay to ask a lame question about simply enabling debug output to the launching shell from a plasmoid via kpackagelauncherqml. My desktop is Ubuntu bionic with kubuntu-ci/stable packages and I am following the first example here... https://community.kde.org/Plasma/DeveloperGuide#An_Ap

D9284: Make it obvious what "Display window borders for maximized windows" is for

2017-12-11 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9284 To: ngraham, hpereiradacosta, #breeze, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9284: Make it obvious what "Display window borders for maximized windows" is for

2017-12-11 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9284 To: ngraham, hpereiradacosta, #breeze, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9284: Make it obvious what "Display window borders for maximized windows" is for

2017-12-11 Thread Nathaniel Graham
ngraham updated this revision to Diff 23783. ngraham added a comment. Change to "Allow resizing maximized windows from window edges" REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9284?vs=23737&id=23783 BRANCH master REVISION DETAIL https://phabricator.

D9284: Make it obvious what "Display window borders for maximized windows" is for

2017-12-11 Thread Nathaniel Graham
ngraham added a comment. Those are good ideas, @hpereiradacosta. How about "Allow maximized windows to be resized from window edges"? This one doesn't have a problem if you have No Borders set. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9284 To: ngraham, hperei

D6764: Use a smaller font size for digital clock plasmoid

2017-12-11 Thread Roman Gilg
romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. To be honest I think the clock should scale with the panel size. When only presenting the time it should be in all panel sizes smaller than currently as you rightfully want to c

D9207: Don't load KDE platform module in kglobalaccel5

2017-12-11 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D9207#178257, @apol wrote: > In https://phabricator.kde.org/D9207#176322, @graesslin wrote: > > > I'm against a risky change here. Especially as this becomes irrelevant with Wayland. > > > What makes it risky? The

D9288: support for defining autostart apps in lnf packages

2017-12-11 Thread Michail Vourlakos
mvourlakos added a comment. @mart I suppose this mechanism is the first step in order to load external apps (such as lattedock) through the Look N' Feel package. Fantastic news of course! :) in the future would it be possible for these apps to include also their layout in the Look N' Fe

D9237: port wallpaper config fialog to Package::fileUrl

2017-12-11 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R120:aeecbcd9f839: port wallpaper config fialog to Package::fileUrl (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9237?vs=23603&id=23766#toc REPOSITORY R120 Plasma Workspace

D9288: support for defining autostart apps in lnf packages

2017-12-11 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > kcm.cpp:387 > +//FIXME: quite ugly way to stop things, and what about non > KDE things? > +QProcess::startDetached(QStringLiteral("kquitapp5"), > {service.property(QStringLiteral("X-DBUS-ServiceName")).toString().spli

D9288: support for defining autostart apps in lnf packages

2017-12-11 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY meant to support layouts that want external apps such as lattedock or conky, it adds services (in the defaults fi

D7246: Tooltips

2017-12-11 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D7246#178385, @McPain wrote: > One more question: > > can this cause a memory leak? > > void Workspace::showTooltip(const QString& text, const QPoint &pos, bool show){ > show ? QToolTip::showText(pos, text) : QToo

Communicating need to reboot and offline updates feedback

2017-12-11 Thread Aleix Pol
Hi, I have a couple of bug reports that I'm not sure how to implement in plasma, so I decided to ask plasma to see what's the best approach. We need to notify the user about 2 instances: a) Reboot is required [1] b) After an offline update (i.e. we scheduled updates to happen at reboot) some updat

D9255: [Notifications] Add visible menu button to thumbnail strip

2017-12-11 Thread Roman Gilg
romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. I'll give this an ok, since the base functionality is there. I'm not sure if I understood the reasoning completely why the context menu can't be aligned correctly to the context menu butt

D9287: disappearing scrollbars on mobile

2017-12-11 Thread David Edmundson
davidedmundson added a comment. If we have a runtime dep, we need to make it explicit in CMakeLists.txt. INLINE COMMENTS > DefaultListItemBackground.qml:23 > import QtQuick.Controls 1.0 as Controls > import QtQuick.Controls.Private 1.0 > import org.kde.plasma.core 2.0 as PlasmaCore does t

Minutes Monday Plasma Hangout

2017-12-11 Thread Eike Hein
Minutes! Logs! We got it all! Only available as bundle. Cheers, Eike Plasma Team meeting, 11-12-2017 Present: romangg, d_ed, notmart, bshah, Sho_ romangg: Pushed Night Color / LibColorCorrect patches to KWin, plasma-workspace and plasma-desktop. Testers welcome :) There is currently still a

D9287: disappearing scrollbars on mobile

2017-12-11 Thread Marco Martin
mart created this revision. mart added reviewers: Plasma, bshah. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY like other platforms, on mobile devices make scrollbars visible only when dragging/fl

D7246: Tooltips

2017-12-11 Thread Oleg Solovyov
McPain added a comment. One more question: can this cause a memory leak? void Workspace::showTooltip(const QString& text, const QPoint &pos, bool show){ show ? QToolTip::showText(pos, text) : QToolTip::hideText(); } REPOSITORY R129 Window Decoration Library REVISION

D9286: don't multiply svg sizes by devicepixelratio

2017-12-11 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY when the native high dpi scaling is enabled, some things gets scaled two times, as sizes t

D9267: remove menubar settings

2017-12-11 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH phab/removeMenubarSett REVISION DETAIL https://phabricator.kde.org/D9267 To: mart, #plasma, davidedmundson Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezha

D9271: Fixed memory leak in new_argv

2017-12-11 Thread David Edmundson
davidedmundson requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9271 To: nathanhenry, davidedmundson Cc: anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai

D9237: port wallpaper config fialog to Package::fileUrl

2017-12-11 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Works with my awesome firework wallpaper from 2 years ago. INLINE COMMENTS > containmentconfigview.cpp:126 > +for (const KPluginMetaData &m : > KPackage::PackageLoa

D5932: KCM for controlling Night Color

2017-12-11 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes. Closed by commit R119:bd9207466a55: Add KCM for controlling KWin's Night Color module (authored by romangg). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5932?vs=23701&id=23751

D5928: Introducing Night Color - KWin's native blue light filter at nighttime

2017-12-11 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes. Closed by commit R108:82d286046907: [colorcorrection] Night Color - blue light filter at nighttime (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5928?vs=23698&id=23749#toc REPOSITORY R108

D5931: ColorCorrect Library - for configuring KWin's native color correction (in particular Night Color)

2017-12-11 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f106f53d212f: ColorCorrect Library for configuring color correction by compositors (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5931?vs=23700&id=23750#toc REPOSITORY

D9284: Make it obvious what "Display window borders for maximized windows" is for

2017-12-11 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. Hello Nat, I agree the text of the option could be made better. However, the formilation you suggest make it sound as if you cannot resize maximized window without checking the option, which is not quite true: you can use the window menu, shortcuts, in case

D5928: Introducing Night Color - KWin's native blue light filter at nighttime

2017-12-11 Thread Roman Gilg
romangg marked an inline comment as done. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5928 To: romangg, #kwin, graesslin Cc: maspons, evpokp, HuShifang, jriddell, ngraham, leezu, behrmann, cfeck, graesslin, davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, alexeymin,

Re: kdesrc-build setup for building qt5 before plasma

2017-12-11 Thread Roman Gilg
Not sure how you can compile Qt with kdesrc-build, but you can compile Qt easily with this guide: https://wiki.qt.io/Building_Qt_5_from_Git Cheers Roman On Thu, Nov 30, 2017 at 9:55 AM, Stéphane Ancelot wrote: > Hi, > > using kdesrc-build , I dont manage to compile qt before kde5 > > I setted u

D9197: experimental support for rcc files loading in kpackage

2017-12-11 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Needs tests and docs INLINE COMMENTS > package.cpp:407 > +QString path = filePath(fileType, filename); > +//consytruct a qrc:/ url or a file:/ url, the onl