apol added inline comments.

INLINE COMMENTS

> kcm.cpp:387
> +                //FIXME: quite ugly way to stop things, and what about non 
> KDE things?
> +                QProcess::startDetached(QStringLiteral("kquitapp5"), 
> {service.property(QStringLiteral("X-DBUS-ServiceName")).toString().split(QChar('.')).last()});
> +            }

Use splitRef or section

> kcm.cpp:387
> +                //FIXME: quite ugly way to stop things, and what about non 
> KDE things?
> +                QProcess::startDetached(QStringLiteral("kquitapp5"), 
> {service.property(QStringLiteral("X-DBUS-ServiceName")).toString().split(QChar('.')).last()});
> +            }

Also I'm not sure if it works, but something along the lines of `systemctl 
--user stop servicename` should work. Or at least it's a thing.

> kcm.cpp:400
> +                as.setAutostarts(true);
> +                KRun::runApplication(service, QList<QUrl>(), nullptr);
> +            }

`{}`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9288

To: mart, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

Reply via email to