rpelorosso added a comment.
In https://phabricator.kde.org/D8361#165581, @abetts wrote:
> In https://phabricator.kde.org/D8361#165580, @ngraham wrote:
>
> > Yeah, maybe a combobox toggling between Glow and Shadow styles/blending
modes would be more intuitive here.
>
>
> That's w
graesslin added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in orientation_sensor.cpp:106
> m_userEnabled = m_config &&
> m_config->group("OrientationSensor").readEntry("Enabled", true);
>
> ?
I might want to extend the loadConfig with further options (who knows) and then
it wou
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:46aaa0e76c7b: Preserve the order in dbus menu when doing
action reusing. (authored by xuetianweng).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8585?vs=
anthonyfieroni added inline comments.
INLINE COMMENTS
> orientation_sensor.cpp:106
> +}
> +m_userEnabled =
> m_config->group("OrientationSensor").readEntry("Enabled", true);
> +}
m_userEnabled = m_config &&
m_config->group("OrientationSensor").readEntry("Enabled", true);
?
REPOSITORY
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
Plasma/5.11
REVISION DETAIL
https://phabricator.kde.org/D8585
To: xuetianweng, #plasma, davidedmundson, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
xuetianweng added a reviewer: broulik.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8585
To: xuetianweng, #plasma, davidedmundson, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
graesslin created this revision.
graesslin added reviewers: KWin, Plasma, sebas, davidedmundson.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The initial state for user enabled is now read from config. In addition
graesslin added a comment.
Please see https://phabricator.kde.org/D8738 - I hope this addresses your
concerns and can us allow to unblock this change.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8731
To: graesslin, #kwin, #plasma, sebas, davidedmundson
Cc: davidedm
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:0ad10ec7c185: revise the tab upload dialog to direct
people at the kde store (authored by sitter).
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8735?vs=22117&id
sitter added a comment.
Mh. Please make sure to merge into master as well next time ;)
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D8153
To: fvogt, #plasma, sebas
Cc: sitter, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, seb
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8608
To: davidedmundson, #plasma, hein
Cc: anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
je
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:fdead6c30886: use OCS to retrieve Tabs from the KDE store
(authored by sitter).
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8734?vs=22116&id=22118
REVISION DE
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R106 KSysguard
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8735
To: sitter, #plasma, jriddell, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abett
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R106 KSysguard
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D8734
To: sitter, #plasma, leinir, jriddell, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuter
sitter created this revision.
sitter added reviewers: Plasma, jriddell.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
previously the dialog would ask users to mail John Tapsell who I think
doesn't maintain ksysguard an
sitter added a comment.
Targets 5.8, 5.11 and master.
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D8734
To: sitter, #plasma, leinir, jriddell
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
sitter added a reviewer: jriddell.
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D8734
To: sitter, #plasma, leinir, jriddell
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
sitter created this revision.
sitter added reviewers: Plasma, leinir.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
newstuff.kde.org has been shut down for a while and as a result the KNS
intergation was entirely broke
davidedmundson added a dependent revision: D8732: Fix race that starts
kactivitymanagerd multiple times.
REPOSITORY
R161 KActivity Manager Service
REVISION DETAIL
https://phabricator.kde.org/D8733
To: davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterbe
davidedmundson updated this revision to Diff 22114.
davidedmundson added a comment.
stupid arc
REPOSITORY
R161 KActivity Manager Service
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8733?vs=22113&id=22114
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8733
AFF
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
See related commit in kactivities.
TEST PLAN
qdbus org.kde.ActivityManager
appeared on bus
REPOSITORY
R161 KActivity Manager Ser
davidedmundson updated this revision to Diff 22111.
davidedmundson marked 4 inline comments as done.
davidedmundson added a comment.
Update
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8608?vs=21739&id=22111
BRANCH
master
REVISION DETAIL
http
22 matches
Mail list logo
