graesslin added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in orientation_sensor.cpp:106
>   m_userEnabled = m_config && 
> m_config->group("OrientationSensor").readEntry("Enabled", true);
> 
> ?

I might want to extend the loadConfig with further options (who knows) and then 
it wouldn't help any more. Also I find the code easier to read if it's spread 
around more lines.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8738

To: graesslin, #kwin, #plasma, sebas, davidedmundson
Cc: anthonyfieroni, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

Reply via email to