graesslin added a comment.
In https://phabricator.kde.org/D8699#165474, @davidedmundson wrote:
> > if auto rotation is enabled you cannot manually rotate the screen and
vice versa.
>
> Yeah, that's great...but kscreen needs to have that information.
>
> It's going to be especially
graesslin added a comment.
5.11 yes, 5.8 no
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8706
To: apol, #plasma, davidedmundson
Cc: graesslin, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff,
lesliezhai, ali-mohamed, hardening, jensreuterberg,
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:df78989bb287: text improvements for Colors, Icons, Style,
and Workspace KCMs (authored by ngraham).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8684?vs=22
abetts accepted this revision.
REPOSITORY
R119 Plasma Desktop
BRANCH
arcpatch-D8684
REVISION DETAIL
https://phabricator.kde.org/D8684
To: ngraham, abetts, #vdg, #plasma, #documentation, apol
Cc: lueck, apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterber
abetts added a comment.
In https://phabricator.kde.org/D8361#165580, @ngraham wrote:
> Yeah, maybe a combobox toggling between Glow and Shadow styles/blending
modes would be more intuitive here.
That's what I mean.
REPOSITORY
R113 Oxygen Theme
REVISION DETAIL
https://phabric
ngraham added a comment.
Yeah, maybe a combobox toggling between Glow and Shadow styles/blending modes
would be more intuitive here.
REPOSITORY
R113 Oxygen Theme
REVISION DETAIL
https://phabricator.kde.org/D8361
To: rpelorosso, #vdg, broulik, aacid, abetts
Cc: abetts, rkflx, aacid, ngra
abetts accepted this revision as: abetts.
abetts added a comment.
This revision is now accepted and ready to land.
I like this change, I think it makes sense. However, if there is a way to
know that the user "means" to use shadow then lets do this. If the user means
to do "glow" this behavior
davidedmundson added a comment.
This was re-added recently for "other desktops".
It shouldn't run on plasma though. It has both:
NotShowIn=KDE;
and
X-KDE-autostart-condition=klipperrc:General:AutoStart:false
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phab
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
In fact it fails, also isn't it a plasmoid now? This is a KStatusNotifierItem.
TEST PLAN
Removed it from my auto
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8706
To: apol, #plasma, davidedmundson
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8707
To: apol, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreu
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Doesn't rely on it adding a QWidgetList include
See https://phabricator.kde.org/D8705
REPOSITORY
R120 Plasma W
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
Fixes the build with https://phabricator.kde.org/D8705
TEST PLAN
Just adds includes, I wonder if it sho
ngraham added a reviewer: abetts.
ngraham added a subscriber: abetts.
ngraham added a comment.
@abetts, what do you think?
REPOSITORY
R113 Oxygen Theme
REVISION DETAIL
https://phabricator.kde.org/D8361
To: rpelorosso, #vdg, broulik, aacid, abetts
Cc: abetts, rkflx, aacid, ngraham, plasma
davidedmundson added a comment.
> if auto rotation is enabled you cannot manually rotate the screen and vice
versa.
Yeah, that's great...but kscreen needs to have that information.
It's going to be especially difficult if you do want to support X.
kscreen there is following any ext
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:b806915d5d5e: Print screen scale in supportInformation
(authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8703?vs=22045&id=22049#toc
REPOSITORY
R108 KWin
CHANGES S
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:92e5db1ffe6a: Debug output for platforms (authored by
davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8702?vs=22044&id=22050
REVISION DETAIL
https:/
Am 2017-11-07 19:03, schrieb Sebastian Kügler:
On dinsdag 7 november 2017 18:28:40 CET Martin Flöser wrote:
> upside down works, 90 and 270 do nothing on my system.
>
> Debian Unstable
> Linux manta 4.13.0-1-amd64 #1 SMP Debian 4.13.4-1 (2017-10-01)
> x86_64 GNU/ Linux
>
> 00:02.0 VGA compatible
graesslin added a comment.
That reminds me: https://phabricator.kde.org/tag/vdg/ how can I request two
new status notifier icons? I need: "automatic-screen-rotation-enabled" and
"automatic-screen-rotation-disabled"
BRANCH
automatic-rotation
REVISION DETAIL
https://phabricator.kde.org/D8
graesslin added a comment.
In https://phabricator.kde.org/D8699#165399, @sebas wrote:
> Ah, btw ... we have icons: They're in
breeze-icons/applets/*/osd-rotate-{ccw,cw,flip,normal].svg
>
> These should probably be used for the statusnotifier then.
No, the idea for the status n
graesslin added a comment.
In https://phabricator.kde.org/D8699#165407, @davidedmundson wrote:
> I don't see how the interaction with KScreen is going to work; you rotate
the screen in kscreen, kscreen will consider that a completely different config
change and save it.
My sugges
graesslin added a comment.
In https://phabricator.kde.org/D8699#165395, @sebas wrote:
> Code-wise, looks good.
>
> Have you thought about a way to switch it on and off? Perhaps a simple dbus
interface that allows checking its state and turning it on and off is
sufficient.
The
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8702
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8703
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed, hardening, jens
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
TEST PLAN
Printed support info.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
Mostly so DRM can report if it has AMS or not
TEST PLAN
Ran on my DRM setup, printe
On dinsdag 7 november 2017 18:28:40 CET Martin Flöser wrote:
> > upside down works, 90 and 270 do nothing on my system.
> >
> > Debian Unstable
> > Linux manta 4.13.0-1-amd64 #1 SMP Debian 4.13.4-1 (2017-10-01)
> > x86_64 GNU/ Linux
> >
> > 00:02.0 VGA compatible controller: Intel Corporation HD
sebas added a comment.
Or ... kwin has two modes: 1) kwin auto-rotates, tells kscreen that it
doesn't do any other transforms, 2) kwin hands over to kscreen, not
auto-rotating...
Perhaps adding "auto" is the best option, though.
BRANCH
automatic-rotation
REVISION DETAIL
https://pha
davidedmundson added a comment.
I don't see how the interaction with KScreen is going to work; you rotate the
screen in kscreen, kscreen will consider that a completely different config
change and save it.
Then we completely lose track of what comes from a user setting and what
doesn't.
sebas accepted this revision.
sebas added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> outputdevice.h:244
> + * @returns The transformations supported on this OutputDevice
> + * @since 5.XX
> + * @see supportedTransformationAdded
5.40 I guess :)
sebas accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
drm-supported-transformations
REVISION DETAIL
https://phabricator.kde.org/D8645
To: graesslin, #kwin, #plasma, subdiff, sebas
Cc: broulik, plasma-devel, kwin, ZrenBot, progwolff, les
sebas added a comment.
Ah, btw ... we have icons: They're in
breeze-icons/applets/*/osd-rotate-{ccw,cw,flip,normal].svg
These should probably be used for the statusnotifier then.
BRANCH
automatic-rotation
REVISION DETAIL
https://phabricator.kde.org/D8699
To: graesslin, #kwin, #plas
sebas accepted this revision.
sebas added a comment.
This revision is now accepted and ready to land.
Code-wise, looks good.
Have you thought about a way to switch it on and off? Perhaps a simple dbus
interface that allows checking its state and turning it on and off is
sufficient.
BRAN
Am 2017-11-07 18:27, schrieb Sebastian Kügler:
On maandag 6 november 2017 16:54:26 CET Martin Flöser wrote:
Hi all,
I am currently working on screen rotation on Wayland. Unfortunately my
systems do not support vertical rotation (rotate by 90 or 270
degrees). Thus I do not know whether my code w
Am 2017-11-07 09:03, schrieb Sebastian Kügler:
Hi Drew,
Thanks for reaching out!
On zaterdag 4 november 2017 15:10:33 CET Drew DeVault wrote:
As part of our effort to reuse existing Wayland protocols for common
desktop features in Sway (and wlroots), we're taking a look at KDE's
output-managem
On maandag 6 november 2017 16:54:26 CET Martin Flöser wrote:
> Hi all,
>
> I am currently working on screen rotation on Wayland. Unfortunately my
> systems do not support vertical rotation (rotate by 90 or 270
> degrees). Thus I do not know whether my code works or what needs
> fixing.
>
> I need
Am 2017-11-07 17:46, schrieb David Edmundson:
Linux david-laptop 4.10.17-2-MANJARO #1 SMP PREEMPT Sun May 21
11:02:41 UTC 2017 x86_64 GNU/Linux
On Intel it's not yet enabled by default with 4.10. Please do the
following:
1. Edit /etc/default/grub
and add "i915.nuclear_pageflip=1" to GRUB_CM
Linux david-laptop 4.10.17-2-MANJARO #1 SMP PREEMPT Sun May 21 11:02:41
UTC 2017 x86_64 GNU/Linux
Renderer:
Compositing
===
Compositing is active
Compositing Type: OpenGL
OpenGL vendor string: Intel Open Source Technology Center
OpenGL renderer string: Mesa DRI Intel(R) Haswell Mobile
Ope
graesslin added a dependent revision: D8699: Support automatic screen rotation
based on orientation sensor.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8645
To: graesslin, #kwin, #plasma, subdiff
Cc: broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-moha
graesslin added a dependency: D8645: [platforms/drm] Determine the supported
transformation on a plane.
REVISION DETAIL
https://phabricator.kde.org/D8699
To: graesslin, #kwin, #plasma, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, ma
graesslin created this revision.
graesslin added reviewers: KWin, Plasma, sebas.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This change introduces an OrientationSensor class which wraps a
QOrientationSensor. The Ori
Am 2017-11-06 19:07, schrieb David Edmundson:
I am not :(
drmSetClientCap fails
Is there much I can do?
Could you please tell me which kernel version and which gpu driver you
are using?
Cheers
Martin
mart updated this revision to Diff 22033.
mart added a comment.
- add heuristic to exclude repeaters from layout
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8641?vs=21991&id=22033
BRANCH
mart/formlayout
REVISION DETAIL
https://phabricator.kde.org/
corentinr added inline comments.
INLINE COMMENTS
> adridg wrote in Workspace.cpp:142
> Are you sure this won't affect tabs that *do* have shortcuts, and need them?
> How about after a save/restart cycle, are the ampersands re-doubled?
There is no default tab with shortcut and I felt there was n
corentinr edited the summary of this revision.
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D8695
To: corentinr
Cc: adridg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
adridg added inline comments.
INLINE COMMENTS
> Workspace.cpp:142
> +// Title ampersands must be doubled or will not be displayed and used as
> QT shortcut
> +insertTab(-1, sheet, dlg.sheetTitle().replace( "&", "&&" ) );
> mSheetList.append( sheet );
Are you sure this won't affect
adridg created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R106 KSysguard
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8694
AFFECTED FILES
.arcconfig
To: adridg
Cc: plasma-devel, ZrenBo
corentinr created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R106 KSysguard
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8695
AFFECTED FILES
gui/Workspace.cpp
To: corentinr
Cc: plasma-
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:1f8fec738573: Add .arcconfig (authored by adridg).
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8694?vs=22030&id=22031
REVISION DETAIL
https://phabricator.kde
Plasma 5.11.3 fixes Network Manager passwords and Discover repo loading
https://www.kde.org/announcements/plasma-5.11.3.php
ngraham added a comment.
Even though that window is narrow, looks like we have room for another
column; we should use it. If this view is capable of resizing itself to fit in
very narrow windows, that will make a bit difference in letting System Settings
be more compact over time, which is i
ngraham marked 3 inline comments as done.
REPOSITORY
R119 Plasma Desktop
BRANCH
arcpatch-D8684
REVISION DETAIL
https://phabricator.kde.org/D8684
To: ngraham, abetts, #vdg, #plasma, #documentation, apol
Cc: lueck, apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai,
ali-mohamed, je
ngraham updated this revision to Diff 22027.
ngraham added a comment.
Update dobcook dates and release versions
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8684?vs=22015&id=22027
BRANCH
arcpatch-D8684
REVISION DETAIL
https://phabricator.kde.
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
BRANCH
phab/moduledata
REVISION DETAIL
https://phabricator.kde.org/D8691
To: mart, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, al
subdiff added a comment.
- Open the kcm with kcmshell5 kcm_cursortheme opens it in a very small view
with only one column
- There is no white background to the list view
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8692
To: mart, #plasma
Cc: subdiff, pla
mart updated this revision to Diff 22026.
mart added a comment.
- make use of the separed kcm modules
- use Q_DECL_OVERRIDE
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8692?vs=22024&id=22026
BRANCH
kcm-redesign/cursorTheme
REVISION DETAIL
mart updated this revision to Diff 22024.
mart added a comment.
- use Q_DECL_OVERRIDE
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8692?vs=22023&id=22024
BRANCH
kcm-redesign/cursorTheme
REVISION DETAIL
https://phabricator.kde.org/D8692
AFFEC
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
introduce a cursor theme kcm ported to QML, following the new
design guidelines, alongside generic components tha
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
accessible by the qml implementations
TEST PLAN
the properties kcm.name and kcm.descriptio
davidedmundson added inline comments.
INLINE COMMENTS
> FormLayout.qml:71
> +itemContainer.parent = lay;
> +//if section, wee need another placeholder
> +if (item.Kirigami.FormData.isSection) {
typo
> FormLayout.qml:85-86
> +property var item
> +
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in FormLayout.qml:8
> Why do we inherit from Control?
I tend to have them controls by default as they have the padding properties
that can be very convenient sometimes (as well, if one needs to put a
background on the back of i
Hi Drew,
Thanks for reaching out!
On zaterdag 4 november 2017 15:10:33 CET Drew DeVault wrote:
> As part of our effort to reuse existing Wayland protocols for common
> desktop features in Sway (and wlroots), we're taking a look at KDE's
> output-management.xml. However, we feel like the related
>
62 matches
Mail list logo
