davidedmundson added a comment.

  I don't see how the interaction with KScreen is going to work; you rotate the 
screen in kscreen, kscreen will consider that a completely different config 
change and save it.
  Then we completely lose track of what comes from a user setting and what 
doesn't.
  
  The only way I can see it working is if we don't update the OutputDevice when 
the rotation was triggered by kwin. 
  (or it gains an 'auto' enum value which kscreen-daemon ignores)

INLINE COMMENTS

> drm_output.cpp:282
> +            [this] {
> +                connect(screens()->orientationSensor(), 
> &OrientationSensor::orientationChanged, this, &DrmOutput::automaticRotation);
> +            }

what about the the initial position?

BRANCH
  automatic-rotation

REVISION DETAIL
  https://phabricator.kde.org/D8699

To: graesslin, #kwin, #plasma, sebas
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to