[Plasma Workspace Wallpapers] [Bug 386093] New: Kubuntu KDE Desktop Icons shown like Memorydump (wild colors) after start from sleep mode

2017-10-22 Thread Sven Ullmann
https://bugs.kde.org/show_bug.cgi?id=386093 Bug ID: 386093 Summary: Kubuntu KDE Desktop Icons shown like Memorydump (wild colors) after start from sleep mode Product: Plasma Workspace Wallpapers Version: 5.10.5 Platform: Ot

D8424: Folder View location properties: Improve visual layout

2017-10-22 Thread Jonathan Marten
marten added a comment. Thanks! - yes, I have push access. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8424 To: marten, #plasma, hein Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

2017-10-22 Thread Jan Grulich
jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Good to go. Thank you. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D8405 To: Martchus, #plasma, jgrulich Cc: jgrulich, ngraham, pla

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-22 Thread Jan Grulich
jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Good to go. Thank you. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D8402 To: Martchus, #plasma, jgrulich Cc: jgrulich, plasma-devel, #frameworks, Z

D8429: Constify

2017-10-22 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R104 KScreen BRANCH constify REVISION DETAIL https://phabricator.kde.org/D8429 To: mlaurent, afiestas, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, je

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-22 Thread Marius Kittler
Martchus updated this revision to Diff 21153. Martchus added a comment. Add "domainSuffixMatch" to auto tests REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8402?vs=21149&id=21153 REVISION DETAIL https://phabricator.kde.org/D8402 AFFECTED FILES

D8429: Constify

2017-10-22 Thread Laurent Montel
mlaurent added reviewers: afiestas, sebas. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8429 To: mlaurent, afiestas, sebas Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8429: Constify

2017-10-22 Thread Laurent Montel
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN build :) REPOSITORY R104 KScreen BRANCH constify REVISION DETAIL https://phabricator.kde.org/D8429 AFFECTED FILES kded/device.cpp kded/

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-22 Thread Jan Grulich
jgrulich requested changes to this revision. jgrulich added a comment. This revision now requires changes to proceed. Now it looks good. Just one thing I forgot is a unit test for this property. You can add it to autotests/settings/8021xsettingtest.cpp and build the tests with "-DBUILD_TESTIN

D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

2017-10-22 Thread Marius Kittler
Martchus updated this revision to Diff 21150. Martchus added a comment. Adapt to updated https://phabricator.kde.org/D8402 REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8405?vs=21071&id=21150 REVISION DETAIL https://phabricator.

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-22 Thread Marius Kittler
Martchus updated this revision to Diff 21149. Martchus added a comment. Changed the method names REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8402?vs=21069&id=21149 REVISION DETAIL https://phabricator.kde.org/D8402 AFFECTED FILES src/settin

D8380: Modernize: use nullptr

2017-10-22 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R104:33f7c637d737: Modernize: use nullptr (authored by mlaurent). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8380?vs=21009&id=21148#toc REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE ht

D8344: Add physicalSize to the Screens API

2017-10-22 Thread Bhushan Shah
bshah added a comment. In https://phabricator.kde.org/D8344#158566, @graesslin wrote: > Maybe there is no need to have that method static? > > Sorry about the build failure... Yeah, going by that theory, will put patch in phab in moment. REPOSITORY R108 KWin REVISION DETAIL

D8344: Add physicalSize to the Screens API

2017-10-22 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D8344#158553, @bshah wrote: > > This breaks the build.. will fix it however. > > Tricky, the method using `m_physicalSize` is static method, would it cause any issue if I make `m_physicalSize` also static? Maybe there i

D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

2017-10-22 Thread Jan Grulich
jgrulich requested changes to this revision. jgrulich added a comment. This revision now requires changes to proceed. This looks good, you will just need to update it to reflect requested changes in your other review. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-22 Thread Jan Grulich
jgrulich requested changes to this revision. jgrulich added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > security8021xsetting.h:66 > > +void setDomain(const QString &domain); > +QString domain() const; Usually these methods are named according to pr

D8424: Folder View location properties: Improve visual layout

2017-10-22 Thread Eike Hein
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Thanks for the patch! Can you push this or do you need someone to push for you? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8424 To: marten, #plasma, h

D8344: Add physicalSize to the Screens API

2017-10-22 Thread Bhushan Shah
bshah added a comment. > This breaks the build.. will fix it however. Tricky, the method using `m_physicalSize` is static method, would it cause any issue if I make `m_physicalSize` also static? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8344 To: graesslin, #

D8344: Add physicalSize to the Screens API

2017-10-22 Thread Bhushan Shah
bshah added inline comments. INLINE COMMENTS > hwcomposer_backend.cpp:197 > static const qreal factor = 25.4; > - o->setPhysicalSize(QSizeF(qreal(pixel.width() * 1000) / > qreal(attr_values[2]) * factor, > - qreal(pixel.height() * 1000) / > qr

D1230: GBM remote access support for KWin

2017-10-22 Thread Oleg Chernovskiy
Kanedias added a comment. In https://phabricator.kde.org/D1230#158542, @ngraham wrote: > With https://phabricator.kde.org/D6186 merged, is this now ready to go in? Yes, just waits for @graesslin's final review :) REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.or

D1231: Add Remote Access interface to KWayland

2017-10-22 Thread Nathaniel Graham
ngraham added a comment. Is this mergeable? @graesslin? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohame

D1230: GBM remote access support for KWin

2017-10-22 Thread Nathaniel Graham
ngraham added a comment. With https://phabricator.kde.org/D6186 merged, is this now ready to go in? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson Cc: ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, plasma-devel, bw

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

2017-10-22 Thread Nathaniel Graham
ngraham added a comment. What's next for this? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D4193 To: arichardson, #plasma Cc: ngraham, krzyc, anthonyfieroni, elvisangelaccio, graesslin, plasma-devel, ZrenBot, progwolff, lesliezha

D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

2017-10-22 Thread Nathaniel Graham
ngraham added a comment. What's next for this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 To: xuetianweng, davidedmundson Cc: ngraham, knambiar, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apo

D4979: Add places:/ KIO slave

2017-10-22 Thread Nathaniel Graham
ngraham added a comment. What's the status of this patch? Are changes required to proceed? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4979 To: broulik, #plasma, hein, dfaure Cc: ngraham, elvisangelaccio, plasma-devel, ZrenBot, progwolff, lesliezhai, al

D6799: Apply maximize effect to full screen changes

2017-10-22 Thread Nathaniel Graham
ngraham added a comment. Can we land this? It's a nice little polish change. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6799 To: broulik, #plasma, graesslin, #vdg Cc: ngraham, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-10-22 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg Cc: januz, progwolff, broulik, sebas, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

Kirigami/qmake problems (updated)

2017-10-22 Thread Camilo Higuita Rodriguez
Hi, sorry for spamming but in my last message i was missing some information. I'm trying to build an application using Kirigami, but i'm stuck with a few issues, and i thought maybe you could help me figure out what's wrong, since i lack experience. I'm using qmake and QtCreator to deploy the ap

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-10-22 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg Cc: januz, progwolff, broulik, sebas, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterber

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-10-22 Thread Nathaniel Graham
ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg Cc: januz, progwolff, broulik, sebas, plasma-devel, Zre

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-10-22 Thread Nathaniel Graham
ngraham updated this revision to Diff 21144. ngraham added a comment. Reduce intensity of the change; don't touch almost-white colors, and only slightly darken the dark grays REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7424?vs=18419&id=21144 BRANCH arc

D8380: Modernize: use nullptr

2017-10-22 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R104 KScreen BRANCH remove_unsed_variable REVISION DETAIL https://phabricator.kde.org/D8380 To: mlaurent, afiestas, sebas, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreute

D7047: Wallpaper blur background filling effect feature

2017-10-22 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. It occurs to me that only the "Scaled, Keep Proportions" and "Centered" positioning modes require any kind of background effect or color. With other positioning modes, the exist

Fwd: Kirigami/qmake deployment on Android problems

2017-10-22 Thread Camilo Higuita Rodriguez
Hi, I've been trying for the past two days to get my Kirigami application up and working on Android. It all works fine in the desktop, but when i try to deploy it to an android device the application dies. I'm using qmake, because with cmake i haven't been able to get pass this error: /usr/share/

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-10-22 Thread Nathaniel Graham
ngraham planned changes to this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg Cc: januz, progwolff, broulik, sebas, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abe

D7246: Tooltips in Breeze theme

2017-10-22 Thread Nathaniel Graham
ngraham added a comment. @McPain, any update? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ma

D7747: Added an extra fuzzytime setting - Hobbit Time

2017-10-22 Thread Jay Turner
jayturner added a comment. In https://phabricator.kde.org/D7747#158471, @ngraham wrote: > @davidedmundson, is "kobbit" good enough? I don't know the history of "kandalf" here. I think the Hobbit books are in public domain nowadays? REPOSITORY R114 Plasma Addons REVISION DETAIL

D7747: Added an extra fuzzytime setting - Hobbit Time

2017-10-22 Thread Nathaniel Graham
ngraham added a comment. @davidedmundson, is "kobbit" good enough? I don't know the history of "kandalf" here. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7747 To: jayturner, ngraham Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai

D7747: Added an extra fuzzytime setting - Hobbit Time

2017-10-22 Thread Jay Turner
jayturner added a comment. In https://phabricator.kde.org/D7747#158466, @ngraham wrote: > @jayturner, do you have commit access? No, sorry REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7747 To: jayturner, ngraham Cc: ngraham, davidedmundson, plas

D7747: Added an extra fuzzytime setting - Hobbit Time

2017-10-22 Thread Nathaniel Graham
ngraham added a comment. @jayturner, do you have commit access? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7747 To: jayturner, ngraham Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, a

D7747: Added an extra fuzzytime setting - Hobbit Time

2017-10-22 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Hilarious. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7747 To: jayturner, ngraham Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesli

D7849: Fix the tray icon scaling on HiDPI screens

2017-10-22 Thread Nathaniel Graham
ngraham added a comment. Any chance we can reach some kind of consensus here? REVISION DETAIL https://phabricator.kde.org/D7849 To: pgkos, #plasma Cc: ngraham, anthonyfieroni, broulik, #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8362: Added setting to toggle drawing of title bar separator

2017-10-22 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. https://phabricator.kde.org/tag/vdg/ seems MIA. @broulik, I propose we land this in a week or two if nobody else objects. REPOSITORY R31 Breeze BRANCH titlebar-highlight REVISION DE

[kio-extras] [Bug 375840] MTP connection crashes after few minutes on several phones

2017-10-22 Thread Michał Walenciak
https://bugs.kde.org/show_bug.cgi?id=375840 --- Comment #7 from Michał Walenciak --- some output from kdeinit5: kamera.kio: KameraProtocol::~KameraProtocol() kf5.kio.core: Refilling KProtocolInfoFactory cache in the hope to find "stash" qt.accessibility.core: Cannot create accessible child interf

[kio-extras] [Bug 375840] MTP connection crashes after few minutes on several phones

2017-10-22 Thread Michał Walenciak
https://bugs.kde.org/show_bug.cgi?id=375840 Michał Walenciak changed: What|Removed |Added CC||kice...@gmail.com --- Comment #6 from Michał

D7999: Drop workaround for QQC1 QGuiApplication crashes

2017-10-22 Thread Antonio Rojas
arojas added a comment. In https://phabricator.kde.org/D7999#158351, @arojas wrote: > Ping, can this go in? AFAIK the QGUIApplication crashes only happen now when explicitely setting the QQC*2* style to org.kde.desktop, which is unrelated to this change (and should be properly fixed inst

D8421: Port the dict applet to KF5 and QtQuick 2

2017-10-22 Thread David Edmundson
davidedmundson added a comment. Cool, thanks! > Adding dict applet to desktop, works. Have you added it to the panel? INLINE COMMENTS > main.qml:20 > +placeholderText: i18n("Enter word to define here") > +// If this was widgets, I'd use QFontMetrics... > +imp

D7999: Drop workaround for QQC1 QGuiApplication crashes

2017-10-22 Thread Antonio Rojas
arojas added a comment. Ping, can this go in? AFAIK the QGUIApplication crashes only happen now when explicitely setting the QQC*2* style to org.kde.desktop, which is unrelated to this change (and should be properly fixed instead of worked around here IMO) REPOSITORY R135 Integration for Q

D8419: Dict Engine: improve error handling.

2017-10-22 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D8419 To: dfaure, #plasma, davidedmundson Cc: plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-

D8424: Folder View location properties: Improve visual layout

2017-10-22 Thread Jonathan Marten
marten created this revision. marten added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The current appearance of this dialogue: F5443493: folderview-properties-location_BEFORE.png

D8405: Allow to set "domain-suffix-match" in Wi-Fi settings

2017-10-22 Thread Marius Kittler
Martchus added a comment. When doing that I'm getting the following error: > Unhandled Exception ("PhabricatorEdgeCycleException") > Graph cycle detected (type=5, cycle=PHID-DREV-pkm36mw773wvsopfgiic, PHID-DREV-4dp34miciioa53ocgthf, PHID-DREV-pkm36mw773wvsopfgiic). So I'll better

[kwrited] [Bug 386067] New: Use seperate notifications for each message

2017-10-22 Thread Sefa Eyeoglu
https://bugs.kde.org/show_bug.cgi?id=386067 Bug ID: 386067 Summary: Use seperate notifications for each message Product: kwrited Version: 5.11.1 Platform: Neon Packages OS: Linux Status: UNCONFIRMED Severi

D8421: Port the dict applet to KF5 and QtQuick 2

2017-10-22 Thread David Faure
dfaure created this revision. dfaure added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY My wife was missing this applet, after migrating to Plasma 5. Therefore I had to learn how to write QML-based

D8320: Dictionary Engine: fix synchronization issues.

2017-10-22 Thread David Faure
This revision was automatically updated to reflect the committed changes. Closed by commit R114:02d8fbfb1928: Dictionary Engine: fix synchronization issues. (authored by dfaure). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8320?vs=20832&id=21125 REVI

D8419: Dict Engine: improve error handling.

2017-10-22 Thread David Faure
dfaure created this revision. dfaure added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead of returning "\n\n" when the word doesn't exist, return a proper readable string so users know that

D8397: Align logout screen action buttons to the top

2017-10-22 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8397 To: aleksejshilin, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,