jgrulich requested changes to this revision. jgrulich added a comment. This revision now requires changes to proceed.
Now it looks good. Just one thing I forgot is a unit test for this property. You can add it to autotests/settings/8021xsettingtest.cpp and build the tests with "-DBUILD_TESTING=true" cmake command and then running "make tests" to verify your test passes. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D8402 To: Martchus, #plasma, jgrulich Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart