davidedmundson updated this revision to Diff 20888.
davidedmundson added a comment.
update
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8338?vs=20887&id=20888
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8338
AFFECTED FILES
davidedmundson updated this revision to Diff 20887.
davidedmundson added a comment.
Remove irrelevant code
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8338?vs=20880&id=20887
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8338
anthonyfieroni added inline comments.
INLINE COMMENTS
> graesslin wrote in main_wayland.cpp:91
> Could you please explain why you think that this function should be static?
> Please keep in mind that main_wayland.cpp is it's own translation unit.
It does not have other purpose, i don't see it's
graesslin added a comment.
Looks good!
INLINE COMMENTS
> startplasma.cmake:31
> +Xft.dpi: $QT_WAYLAND_FORCE_DPI
> EOF
>
This looks unrelated.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8338
To: davidedmundson, #plasma
Cc: graesslin, plasma-devel,
anthonyfieroni accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8339
To: davidedmundson, anthonyfieroni
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts
cfeck added a comment.
Not 100% sure, but I think those symlinks were created by a script or
template. Could you check if there are other references to those wrong names in
the Oxygen cursors source?
REPOSITORY
R113 Oxygen Theme
REVISION DETAIL
https://phabricator.kde.org/D8267
To: ost
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
Compiles
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8339
AFFECTED FILES
applets/appmenu/lib/appmenu
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG: 381174
TEST PLAN
Had debug in QtWayland
Clicked on systray
Had parent, menu was in
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
shell-client-rules
REVISION DETAIL
https://phabricator.kde.org/D8177
To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliez
graesslin added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in main_wayland.cpp:91
> static
Could you please explain why you think that this function should be static?
Please keep in mind that main_wayland.cpp is it's own translation unit.
REPOSITORY
R108 KWin
REVISION DETAIL
anthonyfieroni added inline comments.
INLINE COMMENTS
> main_wayland.cpp:91
> +
> +void gainRealTime(RealTimeFlags flags = RealTimeFlags::DontReset)
> +{
static
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8065
To: graesslin, #kwin, #plasma
Cc: anthonyfieroni, plasma-
ngraham added a comment.
Also, please add "BUG: 366266" to the Summary so that
https://bugs.kde.org/show_bug.cgi?id=366266 gets closed automatically when this
goes in.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D7087
To: gregormi, ngraham
Cc: sebas, elvisan
ngraham added a comment.
I agree with @elvisangelaccio that we should just have a simple "Copy to
clipboard" button--probably down at the bottom, aligned with the other buttons
(on the left side seems right to me). It seems a bit silly to have a menu
button with only two menu items in it, es
gregormi added a reviewer: ngraham.
gregormi added a comment.
Hi Nate, do you have any suggestions to add to this RR?
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D7087
To: gregormi, ngraham
Cc: sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff,
gregormi added a comment.
Any suggestions how to proceed with this?
I personally find the position of the menu not out of place because it is
centered like the main dialog's content.
The reason I put the "About KDE" item into the menu is because it is the
"Info" dialog and there an
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:507d83fb08ad: Ensure leave event is send to decoration
when a window maximizes (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8016?vs=20003&id
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
decoration-maximize-leave-5.11
REVISION DETAIL
https://phabricator.kde.org/D8016
To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwo
graesslin added a comment.
ping
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8177
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hardening, jensreuterberg, abetts, sebas, apol, mart
graesslin added a comment.
ping
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8169
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hardening, jensreuterberg, abetts, sebas, apol, mart
graesslin added a comment.
ping
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8095
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hardening, jensreuterberg, abetts, sebas, apol, mart
graesslin added a comment.
ping
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8016
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hardening, jensreuterberg, abetts, sebas, apol, mart
graesslin added a comment.
ping
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8065
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hardening, jensreuterberg, abetts, sebas, apol, mart
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
require-qt5.9
REVISION DETAIL
https://phabricator.kde.org/D8331
To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,
graesslin added a comment.
Request for update of FreeBSD image in: https://phabricator.kde.org/T7210
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8331
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hardening
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REPOSITORY
R108 KWin
BRANCH
require-qt5.9
REVISION DETAIL
https://phabricator.kde.org/D8331
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:7ef8409157c0: Move X11-only specific part of
EffectsHandlerImpl to x11 platform plugin (authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7955?vs=19835&id=20857#toc
REPOSI
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a1a85f95bb48: [Task Manager] Understand applications:
URLs in Unity launchers (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8327?vs=2
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:24c4be911fa8: kcm search: Change KCM title to
"Configure Search Bar" to disambiguate from… (authored by aspotashev).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kd
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3e9cf7a5b503: kcm baloo: Refuse to add root directory
(authored by aspotashev).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8326?vs=20846&id=20853
REVISI
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
refuse-add-root
REVISION DETAIL
https://phabricator.kde.org/D8326
To: aspotashev, plasma-devel, mart
Cc: ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
kcm-search-naming
REVISION DETAIL
https://phabricator.kde.org/D8328
To: aspotashev, plasma-devel, davidedmundson
Cc: ZrenBot, progwolff, lesliezhai, ali-mohamed, j
anthonyfieroni added inline comments.
INLINE COMMENTS
> smartlauncheritem.cpp:141-142
> +
> +if (m_storageId.isEmpty()) {
> +return;
> }
This check should be before init()? m_storageId can be empty but it can has an
override one, no?
REPOSITORY
R119 Plasma Deskto
broulik added inline comments.
INLINE COMMENTS
> broulik wrote in smartlauncheritem.cpp:141-142
> `unityMappingRules().value(m_storageId);` ← if `m_storageId` is empty, this
> call makes no sense?
But yeah I guess I'll move it to before `init` since the mapping rule might
overwrite it to be em
broulik added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in smartlauncheritem.cpp:141-142
> This check should be before init()? m_storageId can be empty but it can has
> an override one, no?
`unityMappingRules().value(m_storageId);` ← if `m_storageId` is empty, this
call makes no
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:dea8a1ed5f2f: [FrameSvg] Optimize updateSizes (authored
by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8135?vs=20332&id=20851
REVIS
aspotashev created this revision.
aspotashev added a reviewer: plasma-devel.
Restricted Application added a project: Plasma.
REPOSITORY
R119 Plasma Desktop
BRANCH
kcm-search-naming
REVISION DETAIL
https://phabricator.kde.org/D8328
AFFECTED FILES
kcms/runners/kcm.cpp
kcms/runners/kcm_p
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8327
To: broulik, #plasma, hein, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
It only understood absolute desktop file paths so mapping would fail.
CHANGELOG: Fixed application
apol added a comment.
Note I never submitted the patch because Akonadi got fixed.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8318
To: dfaure, #plasma, davidedmundson, broulik
Cc: apol, plasma-devel, mlaurent, ZrenBot, progwolff, lesliezhai, ali-mohamed,
aspotashev created this revision.
aspotashev added a reviewer: plasma-devel.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Before this change you could either have or not have the root folder in
the list of excluded folders and get the same behaviour - that was
confusing.
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5fee12f8bee6: [LauncherTasksModel] Try resolving absolute
path to applications: URL before… (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kd
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:88dbb40ddede: [Task Tools] Treat applications: and
respective absolute path equal in… (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9a257ab60b91: [StartupTasksModel] Try resolving startup
application id to applications: URL (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kd
aspotashev created this revision.
aspotashev added a reviewer: plasma-devel.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Fix extraction of folder basename when it has a trailing slash.
TEST PLAN
Manually tested by me.
REPOSITORY
R119 Plasma Desktop
BRANCH
fix-basena
dfaure abandoned this revision.
dfaure added a comment.
Ah OK. I'm using Plasma/5.11 so I didn't have that fix.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8318
To: dfaure, #plasma, davidedmundson, broulik
Cc: apol, plasma-devel, mlaurent, ZrenBot, progw
45 matches
Mail list logo
