broulik added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in smartlauncheritem.cpp:141-142
> This check should be before init()? m_storageId can be empty but it can has 
> an override one, no?

`unityMappingRules().value(m_storageId);` ← if `m_storageId` is empty, this 
call makes no sense?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8327

To: broulik, #plasma, hein, davidedmundson
Cc: anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to