D8178: Fix editing items in SimpleFavoritesModel

2017-10-07 Thread Rik Mills
rikmills added a comment. Built with the above patch, and on quick testing it seems to resolve the issue for me. I am not a user of activities, so my testing there to make sure existing behaviour on the standard favourites was still the same, may not be as thorough as desirable. REPOSITORY

Re: Plasma Team Communication & Development Practices [MUST READ]

2017-10-07 Thread Ben Cooksley
On Sat, Oct 7, 2017 at 11:57 PM, Martin Flöser wrote: > Am 2017-10-07 11:22, schrieb Ben Cooksley: >> >> *Pulls up a chair* >> >> We need to have a talk. The way things are proceeding currently in >> regards to how you (the Plasma folks) work with the rest of us is >> severely and fundamentally br

D6163: [Icon Applet] Get favicon for website shortcuts

2017-10-07 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6163 To: broulik, #plasma, dfaure Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

[PATCH] Update the kirigami.pri file

2017-10-07 Thread Dirk Hohndel
>From b24003c485f8180b190c653bc5a5744fae4f2284 Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Sat, 7 Oct 2017 09:50:13 -0700 Subject: [PATCH] Update the kirigami.pri file Match the actual file names in libkirigami. Signed-off-by: Dirk Hohndel --- kirigami.pri | 4 ++-- 1 file changed, 2 ins

D8177: Implement Apply desktop rule for ShellClient

2017-10-07 Thread Martin Flöser
graesslin added a dependent revision: D8182: Support initial minimize rule in ShellClient. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8177 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterb

D8182: Support initial minimize rule in ShellClient

2017-10-07 Thread Martin Flöser
graesslin added a dependency: D8177: Implement Apply desktop rule for ShellClient. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8182 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abe

D8182: Support initial minimize rule in ShellClient

2017-10-07 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Honors the rules for minimizing a window on initial show. REPOSITORY R108 KWin BRANCH shell

D8178: Fix editing items in SimpleFavoritesModel

2017-10-07 Thread Fabian Vogt
fvogt added a comment. Someone needs to have a look at the kickoff tools.js diff - it got out of sync apparently. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8178 To: fvogt, #plasma Cc: rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8168: kcm_input: Refactor the code and add support for libinput under X11

2017-10-07 Thread Xuetian Weng
xuetianweng retitled this revision from "kcm_input: Refactor the code to enable support of multiple backends." to "kcm_input: Refactor the code and add support for libinput under X11". xuetianweng edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://ph

D8168: kcm_input: Refactor the code and add support for libinput under X11

2017-10-07 Thread Xuetian Weng
xuetianweng edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8168 To: xuetianweng, davidedmundson, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8168: kcm_input: Refactor the code to enable support of multiple backends.

2017-10-07 Thread Xuetian Weng
xuetianweng updated this revision to Diff 20440. xuetianweng added a comment. using a UI file and add libinput support. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8168?vs=20421&id=20440 BRANCH master REVISION DETAIL https://phabricator.kde.

D8178: Fix editing items in SimpleFavoritesModel

2017-10-07 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. REVISION SUMMARY tools.js is supposed to support both KaStatsFavoritesModel (used for favorite applications) and SimpleFavoritesModel (used for system actions, like poweroff/reboot/lo

D8177: Implement Apply desktop rule for ShellClient

2017-10-07 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This change sets up ShellClient for supporting window rules by reading in the rules once it get

Re: Plasma Team Communication & Development Practices [MUST READ]

2017-10-07 Thread Martin Flöser
Am 2017-10-07 11:22, schrieb Ben Cooksley: *Pulls up a chair* We need to have a talk. The way things are proceeding currently in regards to how you (the Plasma folks) work with the rest of us is severely and fundamentally broken. Which means we need to fix it. Lets start with development practi

D8159: Add API for setting server decoration palettes

2017-10-07 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D8159 To: davidedmundson, #plasma, graesslin Cc: graesslin, broulik, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin,

D8094: Port RuleBook::discardUsed from Client to AbstractClient

2017-10-07 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:35bcc9fc3519: Port RuleBook::discardUsed from Client to AbstractClient (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8094?vs=20205&id=20423

D8169: Support user fullscreen for XdgShellSurfaces

2017-10-07 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far ShellClient did not support that the user can set a window to fullscreen. This was omitt

Plasma Team Communication & Development Practices [MUST READ]

2017-10-07 Thread Ben Cooksley
*Pulls up a chair* We need to have a talk. The way things are proceeding currently in regards to how you (the Plasma folks) work with the rest of us is severely and fundamentally broken. Which means we need to fix it. Lets start with development practices. Over the past few weeks, there have been

D8168: kcm_input: Refactor the code to enable support of multiple backends.

2017-10-07 Thread Xuetian Weng
xuetianweng created this revision. xuetianweng added reviewers: davidedmundson, mart. Restricted Application added a project: Plasma. REVISION SUMMARY Refactor the code like kcm_touchpad to enable support for different backend. Right now we only have X11. TEST PLAN Manually tested on weston