This revision was automatically updated to reflect the committed changes.
Closed by commit R108:7c8003f7f621: Use real-time scheduling policy for
kwin_wayland (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7757?vs=19375&id=20113
REVISION
mart updated this revision to Diff 20111.
mart added a comment.
support icon coloring
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7940?vs=20109&id=20111
BRANCH
arcpatch-D7940
REVISION DETAIL
https://phabricator.kde
mart updated this revision to Diff 20110.
mart added a comment.
- support for custom colors
- support "color" property for icons
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7939?vs=20106&id=20110
BRANCH
mart/colorcontext
REVISION DETAIL
https://
mart updated this revision to Diff 20109.
mart added a comment.
- use new KIconLoader api
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7940?vs=20105&id=20109
BRANCH
arcpatch-D7940
REVISION DETAIL
https://phabricator
mart added a comment.
https://phabricator.kde.org/D8060 solves the same problem without new
dependencies
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D7891
To: mart, #frameworks, #plasma, hein, dfaure
Cc: rikmills, plasma-devel, #frameworks, ZrenBot, progwolff
davidedmundson added a comment.
It doesn't explicitly say anything, but I don't see how we can.
I do have an approach where we would be able to show a polkit dialog
described in https://phabricator.kde.org/T4437.
REPOSITORY
R127 KWayland
BRANCH
filter2
REVISION DETAIL
https://pha
mart updated this revision to Diff 20106.
mart added a comment.
- bind missing colors
- add missing roles
- complete colors definition for fallback qml themes
- active coloring when pressed
- Merge branch 'master' into mart/colorcontext
- support static linking with included pri and q
graesslin added a comment.
In https://phabricator.kde.org/D8040#150577, @davidedmundson wrote
> If you do want to set this based on the initial scene backend, skip using
this method and call the static method on QQuickWindow instead.
After reading through the docs I think the comb
mart updated this revision to Diff 20105.
mart added a comment.
- don't connect to null object, warnings--
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7940?vs=20102&id=20105
BRANCH
arcpatch-D7940
REVISION DETAIL
ht
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Due you know whether we are allowed to block? E.g. to show a polkit dialog?
My assumption would be we are not allowed to block here.
REPOSITORY
R127 KWayland
BRANCH
filter2
REVI
davidedmundson added a comment.
> Let's assume we use XRender or QPainter compositor: how can we switch to
software in this case? In KWin that is before we load any QtQuick (at least on
Wayland on X11 I'm not sure, Aurorae might be loaded before).
Unlike scene we can't switch this at run
mart updated this revision to Diff 20102.
mart added a comment.
- adapt to api change
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7940?vs=20047&id=20102
BRANCH
arcpatch-D7940
REVISION DETAIL
https://phabricator.kde
davidedmundson edited the summary of this revision.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8040
To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff,
lesliezhai, ali-mohamed, hardening, jensreu
davidedmundson updated this revision to Diff 20101.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
updates
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8050?vs=20069&id=20101
BRANCH
fil
davidedmundson added inline comments.
INLINE COMMENTS
> apol wrote in aurorae.cpp:344
> `#if QT_VERSION < QT_VERSION_CHECK(5,10,0)`?
Yeah, makes sense, it got +2'd quicker than I expected.
> graesslin wrote in aurorae.cpp:354
> stupid question: but why is this code working? I would assume that
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in filtered_display.cpp:41
> I tried.
>
> modding getConnection means modding modding ClientConnection constructor,
> modding that means modding the Private ctor
>
> that gets into
>
> wl_client_add_destroy_listener(c,
graesslin added a comment.
Btw. today is a great day: I finally can clean up my whiteboard. I had
drafted an idea how to do what this change does more than a year ago and it's
still waiting for the future me to implement it. But with this change I can
finally clean it without having a bad co
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in filtered_display.cpp:41
> Why a const cast? Or other said: could we overload the getConnection to
> accept a const wl_client*?
I tried.
modding getConnection means modding modding ClientConnection constructor,
modding
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Let's assume we use XRender or QPainter compositor: how can we switch to
software in this case? In KWin that is before we load any QtQuick (at least on
Wayland on X11 I'm not sure, Au
graesslin added inline comments.
INLINE COMMENTS
> aurorae.cpp:354
> [this] {
> if (!m_context->makeCurrent(m_offscreenSurface.data())) {
> return;
stupid question: but why is this code working? I would assume that making the
context current wi
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in filtered_display.cpp:62
> Somewhat.
> This is new in 1.13, we depend on 1.7.
>
> Debian is currently on 1.12.
> (my general rule is: "is Debian has it, everyone else must do")
>
> Should we #ifdefs and then no-op (with
graesslin added inline comments.
INLINE COMMENTS
> filtered_display.cpp:41
> +auto t = static_cast(data);
> +auto clientConnection =
> t->q->getConnection(const_cast(client));
> +auto interface = wl_global_get_interface(global);
Why a const cast? Or other said: could we
rikmills added a comment.
Since this change, polkit-kde-agent-1 fails to build from source with the
error:
> In file included from /usr/include/KF5/KIconThemes/KIconLoader:1:0,
> from
/<>/polkit-kde-agent-1-5.10.95+p17.10+git20170929.1419/AuthDialog.cpp:37:
> /usr/include/KF5/K
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in filtered_display.cpp:62
> I didn't know such API exists! This is great ;-)
>
> But I think you need to increase the minimum Wayland version.
Somewhat.
This is new in 1.13, we depend on 1.7.
Debian is currently on 1.12.
mart added inline comments.
INLINE COMMENTS
> dfaure wrote in kiconloader.h:465
> I guess this is OK as is, so remove the comment (it's not we can change this
> later)
apparently this is giving problems indeed, polkit is now failing to build since
it wasn't explicitly linking to KConfigWidgets
graesslin added inline comments.
INLINE COMMENTS
> filtered_display.cpp:62
> +}
> +wl_display_set_global_filter(*this, Private::globalFilterCallback,
> d.data());
> +});
I didn't know such API exists! This is great ;-)
But I think you need to increase the minimum Wayland ve
antlarr added a comment.
Thanks for the hint! I didn't know I could use FormFactor directly to
reference the Device's formFactor property. Indeed now it looks much better.
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D8054
To: antlarr, #plasma,
antlarr marked an inline comment as done.
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D8054
To: antlarr, #plasma, davidedmundson, drosca
Cc: drosca, sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, apol, mar
antlarr updated this revision to Diff 20094.
antlarr added a comment.
- Use the formFactor attribute of the Device directly
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8054?vs=20090&id=20094
BRANCH
master
REVISION DETAIL
https://
>
>
> I'm still not very familiar with developing Plasma datasources, but I try
> to investigate ways of integrating libdbusmenu as a datasource.
>
> We have: org.kde.plasma.private.appmenu in plasma-workspace/applets/appme
nu.
Which is libdbusmenuqt as a model. It needs some cleanup, docs and the
drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.
Perfect solution!
But why is it in Profile when it is device property? Just remove it from
Profile and leave it only in Device.
INLINE COMMENTS
> DeviceListItem.qml:30
>
antlarr updated this revision to Diff 20090.
antlarr added a comment.
- Use form_factor from device to select the icon for a profile
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8054?vs=20082&id=20090
BRANCH
master
REVISION DETAIL
davidedmundson abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8014
To: davidedmundson, #plasma, broulik, bcooksley
Cc: mart, bcooksley, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, a
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:b3020d6f5a96: Don't recreate kwayland blurmanager on
screen size changes (authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7877?vs=19669&id=
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:55d219429a54: Don't reload background contrast
effect on screen resize (authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7937?vs=19791&id=20
Hello Everybody,
From an email Todd Weaver, CEO at Purism, sent us recently:
>We are planning on hiring staff in November, and that is where we have the
plan of spearheading KDE on our hardware.
>
> We have a few early production development boards, we plan to get into the
hands of
drosca added a comment.
`pactl list sinks`
`pactl list sources`
If pulseaudio even differentiates between headset and headphones.
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D8054
To: antlarr, #plasma, davidedmundson, drosca
Cc: drosca, s
antlarr added a comment.
I wrote in the description the contents of the string variables we could work
with so that it's clear I couldn't find any other way to extract that
information. If you have any other idea (any other variable to use for the
match?) I'm happy to test it.
REPOSITORY
davidedmundson abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8013
To: davidedmundson, #plasma, broulik, bcooksley
Cc: bcooksley, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts,
drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.
Isn't there a better way to test it without using Description (human readable
string - usually device model name)?
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
antlarr added a comment.
Perfect, thanks, I'll do that
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8054
To: antlarr, #plasma, davidedmundson
Cc: sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
sebas added a comment.
Ah okay, I guess then keep this patch in, and ask for the breeze icon. :)
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8054
To: antlarr, #plasma, davidedmundson
Cc: sebas, plasma-devel, ZrenBot, progwolff,
antlarr added a comment.
If I move it to the end, then the player device will show a headset correctly
anyway since no other condition matches but for the capture device, a
microphone icon will be shown instead of the headset.
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
master
RE
sebas added a comment.
Perhaps move the conditional to the end, so it is taken if there's nothing
else, that's making "surer" that nothing that currently works is changed, and
at the same time, request a headset icon for breeze?
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
master
antlarr added a comment.
Hmm, you're right, there's no audio-headset icon in breeze, it's inherited
from oxygen. Should we use it while we request an audio-headset icon for
breeze? or should I revert that change and use headphones in the meantime?
REPOSITORY
R115 Plasma Audio Volume Applet
sebas added a comment.
Where is the headset icon? I can't see it in breeze...
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8054
To: antlarr, #plasma, davidedmundson
Cc: sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mo
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8054
To: antlarr, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moh
antlarr retitled this revision from "Show headphone icons for devices
identifying as "Headset" in Description" to "Show headset icons for devices
identifying as "Headset" in Description".
antlarr edited the summary of this revision.
antlarr edited the test plan for this revision.
REPOSITORY
R1
antlarr updated this revision to Diff 20082.
antlarr added a comment.
- We have a headset icon, so use it for headsets
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8054?vs=20078&id=20082
BRANCH
master
REVISION DETAIL
https://phabr
davidedmundson added a comment.
@mart Kai did it already.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8014
To: davidedmundson, #plasma, broulik, bcooksley
Cc: mart, bcooksley, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-moha
mart added inline comments.
INLINE COMMENTS
> iconitem.cpp:624
> +
> +if (QQuickWindow::sceneGraphBackend() == QLatin1String("software")) {
> +animated = false;
enclose this part with #ifdef on Qt version?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabr
antlarr added a comment.
Note that the test for "headset" takes precedence with respect to the
microphone, so for the capture device, now a headphone is shown instead of a
microphone. I think it's more accurate (since it represents the microphone in
the headset better than a microphone icon,
antlarr created this revision.
antlarr added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
A Logitech H600 / H800 headset was showing an "unknown" icon.
These devices use the following identifier
bcooksley requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8014
To: davidedmundson, #plasma, broulik, bcooksley
Cc: bcooksley, plasma-devel, #frameworks, ZrenBot, progwol
bcooksley requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8013
To: davidedmundson, #plasma, broulik, bcooksley
Cc: bcooksley, plasma-devel, #frameworks, ZrenBot, progwol
bcooksley reopened this revision.
bcooksley added a comment.
This revision is now accepted and ready to land.
Reopening - This breaks the build with Qt 5.7 based systems, which is the
minimum requirement for Frameworks.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://p
bcooksley reopened this revision.
bcooksley added a comment.
This revision is now accepted and ready to land.
Reopening - This breaks the build with Qt 5.7 based systems, which is the
minimum requirement for Frameworks.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://p
57 matches
Mail list logo
