drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.
Perfect solution!
But why is it in Profile when it is device property? Just remove it from
Profile and leave it only in Device.
INLINE COMMENTS
> DeviceListItem.qml:30
> if (currentPort) {
> - if (currentPort.name.indexOf("speaker") != -1) {
> - return "audio-speakers-symbolic";
> - } else if (currentPort.name.indexOf("headphones") != -1) {
> - return "audio-headphones";
> - } else if (currentPort.name.indexOf("hdmi") != -1) {
> - return "video-television";
> - } else if (currentPort.name.indexOf("mic") != -1) {
> - return "audio-input-microphone";
> - } else if (currentPort.name.indexOf("phone") != -1) {
> - return "phone";
> + switch(currentPort.formFactor) {
> + case "internal":
Form factor will be the same for all ports, so just use `switch (FormFactor)`
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D8054
To: antlarr, #plasma, davidedmundson, drosca
Cc: drosca, sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, apol, mart
