D3805: Per-activity favorites (Final, again?)

ivan added a comment. > Good news: There's actually nothing to do on the favorite ids, Kicker already uses > KService::storageId as favorite id, which will be the menuId when it's available. Great :) > I didn't write the Kickoff UI code btw so I don't know about the empty place

D3805: Per-activity favorites (Final, again?)

ivan updated this revision to Diff 19034. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3805?vs=18220&id=19034 REVISION DETAIL https://phabricator.kde.org/D3805 AFFECTED FILES applets/kicker/CMakeLists.txt applets/kicker/package/contents/code/tools.js applets/kicker/package/co

D3805: Per-activity favorites (Final, again?)

hein added a comment. Good news: There's actually nothing to do on the favorite ids, Kicker already uses KService::storageId as favorite id, which will be the menuId when it's available. Due to Kai giving me https://bugs.kde.org/show_bug.cgi?id=351553 I thought this was an issue, but th

D7567: Support edit and appstream actions also for application search results

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ee7078864b75: Support edit and appstream actions also for application search results (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7567?

Plasma 5.11 Release announcement / feature list

Hi all,I just figured we've got two weeks left until the 5.11 Beta release on Thursday, 14 September with final release on Tuesday, 10 October, so I started an Etherpad:https://notes.kde.org/p/plasma_5_11Please fill in all the noteworthy features and fixes you made!Thanks Kai Uwe 

D6183: [Digital Clock] Allow copying current date and time to clipboard

broulik added a comment. There's still two weeks left until feature freeze for 5.11 on 14 September ;) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6183 To: bschiffner, #plasma, broulik Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali

D6183: [Digital Clock] Allow copying current date and time to clipboard

bschiffner added a comment. I think you get it much faster done. Please do it. I'am sitting in a hotel now without tools do to something software related :-( REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6183 To: bschiffner, #plasma, broulik Cc: davidedm

D6183: [Digital Clock] Allow copying current date and time to clipboard

broulik added a comment. > But if the user decides not to see seconds displayed, it can be interpreted plausibly he doesn't want to see them in the clipboard too. Good idea! Why didn't I think of this. I think this is a perfectly valid assumption. Can you take a look at this (and possibl

D6183: [Digital Clock] Allow copying current date and time to clipboard

bschiffner added a comment. Ah, I got it now and will try it. But if the user decides not to see seconds displayed, it can be interpreted plausibly he doesn't want to see them in the clipboard too. Pseudocode: if config.seconds() then ... REPOSITORY R120 Plasma Workspace REVISION DE

D6183: [Digital Clock] Allow copying current date and time to clipboard

broulik added a comment. If you do not have seconds enabled in digital clock, the data source is only updated once every minute. You might not see this if you try it right after startup but eventually the seconds will always be :00 making it pointless to copy seconds. Ideally, we find a way

D6183: [Digital Clock] Allow copying current date and time to clipboard

bschiffner added a comment. Sorry for not understanding the (perhaps your?) problem with the seconds. Do you like to express that you: 1.) do not get seconds at all (erverytime 00 or 59) or 2.) do not get an actualized value of seconds (or time) in very the moment of clicking the intende

D7616: Don't dissallow open with write flag syscall on NVIDIA

graesslin added a comment. In https://phabricator.kde.org/D7616#141852, @davidedmundson wrote: > Users of LTS might get a new nvidia driver too. > Maybe worth cherry-picking. the problematic code is new in 5.10, so not an issue (luckily) REPOSITORY R133 KScreenLocker REVISI

D3805: Per-activity favorites (Final, again?)

ivan added a comment. This might be a hint: contents/ui/KickoffItem.qml:191:9: QML Text: Binding loop detected for property "y" REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D3805: Per-activity favorites (Final, again?)

ivan added a comment. Regarding Kickoff - it looks like there are some problems in its model handling: F3894000: Spectacle.m20682.png This does not happen with Kicker, Dash nor the KAStats test application. The empty spaces seem to be empty

D3805: Per-activity favorites (Final, again?)

hein added a comment. > I haven't managed to make this work. The problem is that the favourites are added asynchronously, and setting the ordering for a bunch of them at once fails because the items do not exist. Hmm ... are they added one-by-one? Maybe we need an atomic API to insert m

D3805: Per-activity favorites (Final, again?)

ivan added a comment. > The initial sorting of the migrated superset seems random. How is it done? I haven't managed to make this work. The problem is that the favourites are added asynchronously, and setting the ordering for a bunch of them at once fails because the items do not exist.

Kscreenlocker 5.10.5.1

Kscreenlocker has a feature that doesn't play nicely with the latest nvidia driver making the entire thing crash. Given locking the screen is quite an important operation, we've made an immediate release that works round that issue. The tarball is named 5.10.5.1 as 5.10.5 has already been public

D7616: Don't dissallow open with write flag syscall on NVIDIA

davidedmundson added a comment. Users of LTS might get a new nvidia driver too. Maybe worth cherry-picking. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D7616 To: graesslin, #plasma, davidedmundson Cc: davidedmundson, jriddell, plasma-devel, ZrenBot, progw

D7631: [Folder View] Accept and reject Escape event appropriately

hein added a comment. Does this have any ramifications in widget mode (panel, etc)? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7631 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, a

D7632: [Folder View] Also handle Enter key (on numpad) to run files and cd into folders

hein accepted this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7632 To: broulik, #plasma, hein, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7616: Don't dissallow open with write flag syscall on NVIDIA

This revision was automatically updated to reflect the committed changes. Closed by commit R133:2136a38d88c8: Don't dissallow open with write flag syscall on NVIDIA (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7616?vs=18970&id=

D6183: [Digital Clock] Allow copying current date and time to clipboard

broulik added a comment. So, the question is what to do regarding the seconds :/ I couldn't figure out a way to cause a refresh of the data source. (A hack could be to disconnect and connect sources before showing the menu but urgh). In doubt we can just get rid of the seconds altogether

Re: qqc2-desktop-style not release

On Thu, Aug 31, 2017 at 05:12:48PM +0200, Marco Martin wrote: > Hi all, > this is connected with previous email (qqc2-desktop-style as framework) it is > also important that it does *not* get released with Plasma 5.11 (if people > are > ok with eventually maing it a frameowrk) as will make it v

D7633: [Digital Clock] Compact and move to the end font setup

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This makes the font selector more compact and moves it to the end of the dialog. Settings like show seconds and date are more important than

D7630: [DesktopView] Move cancelling showing desktop into keyPressEvent

This revision was automatically updated to reflect the committed changes. Closed by commit R120:55d74c682197: [DesktopView] Move cancelling showing desktop into keyPressEvent (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7630?v

qqc2-desktop-style not release

Hi all, this is connected with previous email (qqc2-desktop-style as framework) it is also important that it does *not* get released with Plasma 5.11 (if people are ok with eventually maing it a frameowrk) as will make it very painful to framework it later, any place to modify release scripts to

qqc2-desktop-style as framework

Hi all, we have a qtquickcontrols style that is right now in workspace (unrelased, to be released with Plasma 5.11) it makes controls paint with qstyle to give it a reasonable desktop appearance, plus some fixes/workarounds to make qml a bit more desktop friendly (for instance fixes scrollwheel

D7632: [Folder View] Also handle Enter key (on numpad) to run files and cd into folders

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7632 To: broulik, #plasma, hein, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7630: [DesktopView] Move cancelling showing desktop into keyPressEvent

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7630 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D7629: Do not show reveal password button on login screen

davidedmundson added a comment. So the killer issue from your bug report is that there's no "eye" icon in your SDDM login. That definitely is a big problem and needs a solution. But just removing the setting isn't really trying to address the actual bug at all, it's just avoiding it. RE

D7632: [Folder View] Also handle Enter key (on numpad) to run files and cd into folders

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN I can now also hit Enter on my numpad to open files rather than just the big Return key (dunnow hat's up with teh SmooedAnimation change, I just

D7631: [Folder View] Accept and reject Escape event appropriately

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When renaming, accept the Escape key event to prevent the containment from leaving Showing Desktop mode. Otherwise don't accept it and let the

D7630: [DesktopView] Move cancelling showing desktop into keyPressEvent

broulik added a dependent revision: D7631: [Folder View] Accept and reject Escape event appropriately. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7630 To: broulik, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D7630: [DesktopView] Move cancelling showing desktop into keyPressEvent

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This will route the event through the containment first which can then intercept it, e.g. to prevent Escape from exiting showing desktop while

D7629: Do not show reveal password button on login screen

rharishnavnit added a comment. Personally, I believe that the reveal password feature should stay. There's an eye icon shown in the password field too IIRC(just checked my lock screen) and I'm puzzled how that can be confusing. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://ph

D7629: Do not show reveal password button on login screen

siteshwarv created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Reveal password button on the login screen is unnecessary. It can be clicked accidentally and is confusing to the users. Related bug https

D7628: Clear previous actions on update

This revision was automatically updated to reflect the committed changes. Closed by commit R308:d727165b08c9: Clear previous actions on update (authored by davidedmundson). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7628?vs=19008&id=19009 REVISION DETAIL

D7628: Clear previous actions on update

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH master REVISION DETAIL https://phabricator.kde.org/D7628 To: davidedmundson, #plasma, broulik Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensre

D7628: Clear previous actions on update

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY addAction() doesn't check if an action already exists with that name so we have a tiny memory leak. Also I

D7601: [EventPluginsManager] Expose pluginPath in model

This revision was automatically updated to reflect the committed changes. Closed by commit R242:d574dec0f80a: [EventPluginsManager] Expose pluginPath in model (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7601?vs=1891

D7626: [CurrentContainmentActionsModel] Emit configurationChanged when action is added/removed/edited

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Removes the need for the UI to explicitly do this on every action. TEST PLAN Removed the manual invocations of `root.configurationChanged()`

D6443: [CurrentContainmentActionsModel] Add configurationChanged signal

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3257f5f92373: [CurrentContainmentActionsModel] Add configurationChanged signal (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6443?v

D7603: [Digital Clock] Show event plugin configurations only if enabled

This revision was automatically updated to reflect the committed changes. Closed by commit R120:03b37c94bd3b: [Digital Clock] Show event plugin configurations only if enabled (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7603?v

D7602: [ConfigModel] Allow programmatically adding and removing ConfigCategory

This revision was automatically updated to reflect the committed changes. Closed by commit R242:11e416bea6cd: [ConfigModel] Allow programmatically adding and removing ConfigCategory (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricato

[kio-extras] [Bug 366638] [16.04] sftp stuck operations. Can operate only if reopening Dolphin

https://bugs.kde.org/show_bug.cgi?id=366638 Sebastian Kügler changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org -- You are receiving th

D7155: Implement sorting of the device tree items

isaact added a comment. In https://phabricator.kde.org/D7155#138825, @cfeck wrote: > Isaac, do you want to work on the requested changes? Sorry for the long delay in responding - I will work on the suggestions this weekend. REPOSITORY R102 KInfoCenter REVISION DETAIL https:/

[kio-extras] [Bug 366638] [16.04] sftp stuck operations. Can operate only if reopening Dolphin

https://bugs.kde.org/show_bug.cgi?id=366638 --- Comment #7 from Germano Massullo --- Is anybody working on this? -- You are receiving this mail because: You are the assignee for the bug.

Re: Plasma Mobile on the Librem 5

On 08/31/2017 11:21 AM, Sebastian Kügler wrote: > > > 2017-08-29 16:44 GMT+02:00 Sebastian Kügler : > > >> Would it make sense to get together and look at Plasma Mobile and > > >> Purism's plans, and devise a possible strategy and next steps? Maybe > > >> get together in a video conference with e

D7624: [Containment Actions Config] Cleanup layout and support multiple modifiers

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently we only manage to display one modifier for each action but you can setup multiple (which work fine, it's just the UI). While at it

D6443: [CurrentContainmentActionsModel] Add configurationChanged signal

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6443 To: broulik, #plasma, mart Cc: davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, ab

Re: Plasma Mobile on the Librem 5

> > 2017-08-29 16:44 GMT+02:00 Sebastian Kügler : > >> Would it make sense to get together and look at Plasma Mobile and > >> Purism's plans, and devise a possible strategy and next steps? Maybe > >> get together in a video conference with everybody interested in this > >> project, and see how we c

D7567: Support edit and appstream actions also for application search results

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D7567_2 REVISION DETAIL https://phabricator.kde.org/D7567 To: hein, #plasma, broulik, davidedmundson Cc: mak, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-m

D7586: [Folder View] Delay delegate creation until plasmoid expands

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3a5369e86f33: [Folder View] Delay delegate creation until plasmoid expands (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7586?vs=1894

Re: Problem building Kirigami example.

Pats, On Mon, Aug 28, 2017 at 6:27 PM, patrick JP wrote: > I am trying to compile kirigami apk. This is my command line to use cmake: > > cmake .. > -DCMAKE_TOOLCHAIN_FILE=/usr/share/cmake-3.9/Modules/Platform/Android.cmake > \ > -DQTANDROID_EXPORTED_TARGET=kirigami2gallery > -DANDROID_APK_DIR

D7586: [Folder View] Delay delegate creation until plasmoid expands

hein added a comment. Looks good, go. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7586 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

Re: Plasma Mobile on the Librem 5

On 08/30/2017 03:43 PM, Matthias Klumpp wrote: > 2017-08-29 16:44 GMT+02:00 Sebastian Kügler : > [...] >> Would it make sense to get together and look at Plasma Mobile and >> Purism's plans, and devise a possible strategy and next steps? Maybe >> get together in a video conference with everybody

Re: Plasma Mobile on the Librem 5

On 08/30/2017 03:50 PM, Matthias Klumpp wrote: > 2017-08-29 18:39 GMT+02:00 Martin Flöser : > >> One of the things currently being worked on for the phone is to get rid of >> XWayland. This could give you a nice performance boost as you have a Wayland >> only system (of course it's also nice to h

Problem building Kirigami example.

I am trying to compile kirigami apk. This is my command line to use cmake: cmake .. -DCMAKE_TOOLCHAIN_FILE=/usr/share/cmake-3.9/Modules/Platform/Android.cmake \ -DQTANDROID_EXPORTED_TARGET=kirigami2gallery -DANDROID_APK_DIR=../examples/galleryapp/ \ -DCMAKE_PREFIX_PATH=/opt/android-qt5/5.9.1/armea

Re: Retirement of Reviewboard - Transition to Phabricator

On Friday August 25 2017 07:33:43 Ben Cooksley wrote: Hi, >> Note that due to how Reviewboard stores diffs and reproduces them for >> use, some reviews may have decayed and may no longer be readable. This >> is due to short-hashes which are used by Git/Reviewboard in diffs now >> having collision

Re: Retirement of Reviewboard - Transition to Phabricator

On Mon, Aug 28, 2017 at 8:20 PM, René J.V. Bertin wrote: > On Friday August 25 2017 07:33:43 Ben Cooksley wrote: > > Hi, Hi Rene, > >>> Note that due to how Reviewboard stores diffs and reproduces them for >>> use, some reviews may have decayed and may no longer be readable. This >>> is due to s