graesslin added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in surface_interface.cpp:813
> UniqueConnection with lambda ?
Yeah, I don't think unique will work here. But looking at the code it also
doesn't matter if the lambda is executed multiple times.
REPOSITORY
R127 KWayland
anthonyfieroni added inline comments.
INLINE COMMENTS
> surface_interface.cpp:813
> +setOutputs(outputs);
> +}}, Qt::UniqueConnection);
> }
UniqueConnection with lambda ?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7531
To: davide
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
createObjectFromSource can return a null on error. This needs guarding.
REPOSITORY
R242 Plasma Framework (Libra
davidedmundson created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
As per existing TODO.
A new signal is added on Global to emit so we can process the result
whist
i.Dark_Templar updated this revision to Diff 18717.
i.Dark_Templar added a comment.
Updated patch for plasma-workspace 5.10, I'm using it with 5.10.4, but it
should apply to master too. I've tried adding appmenu panel to desktop, still
works fine for me. A bit of clarification. I'm not sure i
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:9cd2cf7adc46: Use QTEST_GUILESS_MAIN (authored by
heikobecker).
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7525?vs=18714&id=18716
REVISION DETAIL
https://pha
heikobecker created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Otherwise they fail quite miserably.
REPOSITORY
R871 DrKonqi
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7526
AFFE
El dijous, 24 d’agost de 2017, a les 21:07:49 CEST, Ben Cooksley va escriure:
> Hi all,
>
> The following is Sysadmin's suggested plan for the retirement of
> Reviewboard now that Phabricator is fully up and running for hosting
> of code reviews.
>
> Phase 1: Commences September 2: All repositori
On 25/08/2017 5:41 AM, "Albert Astals Cid" wrote:
El dijous, 24 d’agost de 2017, a les 21:07:49 CEST, Ben Cooksley va
escriure:
> Hi all,
>
> The following is Sysadmin's suggested plan for the retirement of
> Reviewboard now that Phabricator is fully up and running for hosting
> of code reviews.
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R871 DrKonqi
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7525
To: heikobecker, #plasma, sitter, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, j
heikobecker created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Allowing the test to pass without a running X server.
TEST PLAN
Test still passes.
REPOSITORY
R871 DrKonqi
BRANCH
master
REVISION
graesslin added a comment.
ASAN detected a heap-use-after-free:
=
==10094==ERROR: AddressSanitizer: heap-use-after-free on address
0x6033b060 at pc 0x7fa28cc7782f bp 0x7fff015a5610 sp 0x7fff015a5608
READ of size
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The sync is broken due to updateXTime not working correctly on Wayland.
As the broken sync results in a very unsmooth resize experience
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:1cc38c929a10: Move updateXTime into the X11 standalone
platform (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7515?vs=18707&id=18708
REVISIO
graesslin updated this revision to Diff 18707.
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Fix arc mess
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7515?vs=18706&id=18707
BRANCH
update-xtime-platform
RE
graesslin updated this revision to Diff 18706.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
- Disable synced resizing for X11 clients on Xwayland
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7515?vs=18680&id=
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:2c1303a0f1a7: Automatic scaling selection (authored by
davidedmundson).
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7482?vs=18698&id=18704
REVISION DETAIL
htt
sebas added a comment.
Be careful pushing, by the way. It seems you've branched this off of my
rotationplasmoid branch. Should obviously go into master.
REPOSITORY
R104 KScreen
BRANCH
sebas/rotationplasmoid
REVISION DETAIL
https://phabricator.kde.org/D7482
To: davidedmundson, #plasma
sebas accepted this revision.
REPOSITORY
R104 KScreen
BRANCH
sebas/rotationplasmoid
REVISION DETAIL
https://phabricator.kde.org/D7482
To: davidedmundson, #plasma, broulik, sebas
Cc: sebas, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, apol, m
graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> shell_client.cpp:1319
> +if (m_XdgForeign) {
> +s = m_XdgForeign->transientFor(surface());
> +}
I would delegate this to waylandServer,
sebas added a comment.
-1, we discussed this in a bugreport already recently. The rationale in there
applies here, too. It's a conscious design choice made, and it's easy enough to
ship a color scheme with more contrast.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R104 KScreen
BRANCH
sebas/rotationplasmoid
REVISION DETAIL
https://phabricator.kde.org/D7482
To: davidedmundson, #plasma, broulik
Cc: sebas, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, a
davidedmundson updated this revision to Diff 18698.
davidedmundson added a comment.
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7482?vs=18696&id=18698
BRANCH
sebas/rotationplasmoid
REVISION DETAIL
https://phabricator.kde.org/D7482
AFFECTED FILES
davidedmundson added a comment.
get a better screen!
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D7482
To: davidedmundson, #plasma
Cc: sebas, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, apol, mart, lukas
broulik added a comment.
Greater *or equal to* plus :)
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D7482
To: davidedmundson, #plasma
Cc: sebas, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, apol, mart, lukas
davidedmundson updated this revision to Diff 18696.
davidedmundson added a comment.
Update
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7482?vs=18589&id=18696
BRANCH
sebas/rotationplasmoid
REVISION DETAIL
https://phabricator.kde.org/D7482
AFFECTED
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:95c983e6d858: Handle buffer scales changing dynamically
(authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7486?vs=18672&id=18692
REVISION D
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:f0971532c90b: Send output enter/leave events to surfaces
(authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7359?vs=18314&id=18691
REVISION
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
Kill 'em all
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7516
To: broulik, #plasma, mart
Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff
davidedmundson added a comment.
Looks good to me.
> not sure how to test it further
If you did want to autotest it, it'd be in the integration folder; it uses
the real shell_client with a fake workspace.
If you want a real world use-case for this:
kde-polkit-agent-1 has a s
mart created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
not sure if that is the right "parent" that has
to be set, set the transient for surfaces that
have setParentOf of an imported set
T
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
update-xtime-platform
REVISION DETAIL
https://phabricator.kde.org/D7515
To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,
broulik added inline comments.
INLINE COMMENTS
> sebas wrote in generator.cpp:553
> But standard DPI will be filtered out with your dpi > 96 check (which we
> could even make a bit stricter, like dpi > 150 or so...?
The sanity check is mostly for screens that report stupid dpi. Unfortunately,
sebas added inline comments.
INLINE COMMENTS
> davidedmundson wrote in generator.cpp:553
> Unfortunately there's also some screens at 2560x1440 and standard DPI.
>
> I'll change it anyway, it only affects wayland users so we have time to tweak
> things.
But standard DPI will be filtered out wi
broulik updated this revision to Diff 18684.
broulik added a comment.
- Use positioner's setRangeSelected
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6881?vs=17128&id=18684
REVISION DETAIL
https://phabricator.kde.org/D6881
AFFECTED FILES
con
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:07c2bf0c53d5: [Folder View] Clear selection on Escape
(authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7511?vs=18674&id=18683
REVISION
hein updated this revision to Diff 18682.
hein added a comment.
Fix prop description
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7509?vs=18670&id=18682
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7509
AFFECTED FILES
src/controls/
hein added a comment.
I thought I had written a comment to this, but apparently not - couldn't
selectAll just use the existing range select method instead of adding a new
one? But then again I'm fine with this too.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.o
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6881
To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart,
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D7511
To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart,
hein added a comment.
I had a feeling it was like that, WM::Name always coming from KWin seemed
weird somehow.
Ok, so we need the name props and selectively icon.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7481
To: davidedmundson, #plasma
Cc: brou
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
It's not being set to anything anymore and people typically don't have 256
color displays these days.
TEST PLAN
Compi
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
KWin::updateXTime only delegates into the platform API where the method
is a no-op. The actual implementation is moved into the X11 stan
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The SyncManager is highly X11 dependent and doesn't make much sense on
Wayland. It should already be guarded by the check for
GL_EXT_x
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:981662a6b5e0: [effects] Don't register touch edges which
don't exist (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7508?vs=18669&id=18676
RE
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
xdgv6
REVISION DETAIL
https://phabricator.kde.org/D7486
To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai,
ali-moha
broulik added a comment.
Ping
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6881
To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Matches Dolphin behavior.
TEST PLAN
Pressed Escape, selection was lost.
Started renaming a file, pressed Escape, rename was canceled, file
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in PageRow.qml:96
> A bit misleading, as when container.level is 0 this isn't false.
the wording should be
"True if the separator between pages should be visible"
when the level is 0 this is false anyways as this property is set
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
I don't get the comment on why it is `/dev/null` instead of `QString()` but
using `SimpleConfig` at least saves 0.3ms pe
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
effects-dont-register-incorrect-touch-edges
REVISION DETAIL
https://phabricator.kde.org/D7508
To: graesslin, #kwin, #plasma, broulik
Cc: plasma-devel, kwin, ZrenBot, progwolff, les
davidedmundson updated this revision to Diff 18672.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Move into scene
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7486?vs=18601&id=18672
BRANCH
xdgv6
REVIS
davidedmundson added inline comments.
INLINE COMMENTS
> PageRow.qml:96
> + * separatorVisible: bool
> + * True if the separator between pages is visible
> + * default: true
A bit misleading, as when container.level is 0 this isn't false.
REPOSITORY
R169 Kirigami
REVISION DETAIL
hein created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7509
AFFECTED FILES
src/controls/PageRow.qml
To: hein, mart
Cc: pla
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Apparently some old configs made PresentWindows register the top left
corner which does not make any sense as that's not supported by to
graesslin added a comment.
In https://phabricator.kde.org/D7481#139276, @hein wrote:
> Sounds good, then we really only care about the title and icon.
>
> Let's do the title in KWin, then, AIUI? But we still need this patch for
the icon. But we could now limit it to windows that are a
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d545538e5a9d: Drop unnecessary dependency on
KF5XmlRpcClient (authored by heikobecker).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7506?vs=18661&id=186
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7506
To: heikobecker, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
davidedmundson added inline comments.
INLINE COMMENTS
> sebas wrote in generator.cpp:553
> Same vertical resolution here, and my hardware is also something that users
> with normal eyes would like to see scaled. ~1400ish seems a better threshold,
> I guess?
Unfortunately there's also some scre
heikobecker created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
It was required by drkonqi, but that was split out from plasma-workspace.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DE
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:46ab5b1bbe62: Fix deprecated usage of ecm_install_icons
(authored by heikobecker).
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7488?vs=18607&id=18662
REVISION D
sebas added a comment.
This one slipped my attention. I think it's still relevant?
INLINE COMMENTS
> doctor.h:54
> bool setPosition(int id, const QPoint &pos);
> +bool setScale(int id, int scale);
> bool setMode(int id, const QString &mode_id);
Unrelated?
REPOSITORY
R110 KSc
sebas accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R104 KScreen
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7488
To: heikobecker, #plasma, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, se
sebas added a comment.
Patch looks fine, other than the heuristics @broulik already pointed out.
INLINE COMMENTS
> broulik wrote in generator.cpp:553
> My laptop has 230dpi but only a vertical resolution of 1440, so this wouldn't
> work for me.
Same vertical resolution here, and my hardware
broulik added inline comments.
INLINE COMMENTS
> generator.cpp:553
> +//you'd find in a high res screen
> +if (dpi > 96 * 1.5 && mode->size().height() > 1200 * 1.5) {
> +return 2.0;
My laptop has 230dpi but only a vertical resolution of 1440, so this wouldn't
work for me.
> gen
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4ec4a739a345: [PanelShadows] Update m_windows in
setEnabledBorders (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7505?vs=18658&id=1
Hi all,
The following is Sysadmin's suggested plan for the retirement of
Reviewboard now that Phabricator is fully up and running for hosting
of code reviews.
Phase 1: Commences September 2: All repositories are closed for
accepting new reviews on Reviewboard. A notice is added to the top of
the
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7505
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abet
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
m_windows keeps track of which window has which borders so it can update them
when e.g. theme changes. Unfortunately, it was never updated aft
hein added a comment.
Sounds good, then we really only care about the title and icon.
Let's do the title in KWin, then, AIUI? But we still need this patch for the
icon. But we could now limit it to windows that are actually on the fallback
path that does anything in response to icon chan
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The compositor needs to claim the X11 compositor selection and redirect
the X11 windows. This of course only makes sense when having X11
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:2cdd0402bf9c: Get rid of warnings about setting both
pixel and point sizes (authored by leinir).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7483?vs=18590&id=18
72 matches
Mail list logo
