sebas added a comment.

  Patch looks fine, other than the heuristics @broulik already pointed out.

INLINE COMMENTS

> broulik wrote in generator.cpp:553
> My laptop has 230dpi but only a vertical resolution of 1440, so this wouldn't 
> work for me.

Same vertical resolution here, and my hardware is also something that users 
with normal eyes would like to see scaled. ~1400ish seems a better threshold, I 
guess?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D7482

To: davidedmundson, #plasma
Cc: sebas, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart, lukas

Reply via email to